[CodeCache] Proactively pass PendingBackends to renderers [chromium/src : main]

0 views
Skip to first unread message

Greg Thompson (Gerrit)

unread,
Jul 7, 2026, 8:59:08 AM (2 days ago) Jul 7
to Charlie Reis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Hiroki Nakagawa, extension...@chromium.org, chromium-a...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Charlie Reis

Greg Thompson added 1 comment

Patchset-level comments
File-level comment, Patchset 19 (Latest):
Greg Thompson . resolved

@cr...@chromium.org: PTAL this change to send PersistentCaches to renderers when committing navigations so that they can fetch resources immediately rather than waiting for an extra round-trip to the browser. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Charlie Reis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id73b26b9c33de6a20ef5038dcf34b17a328b1b27
Gerrit-Change-Number: 8004431
Gerrit-PatchSet: 19
Gerrit-Owner: Greg Thompson <g...@chromium.org>
Gerrit-Reviewer: Charlie Reis <cr...@chromium.org>
Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Charlie Reis <cr...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Jul 2026 12:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Greg Thompson (Gerrit)

unread,
Jul 8, 2026, 5:50:46 AM (23 hours ago) Jul 8
to Mike West, Charlie Reis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Hiroki Nakagawa, extension...@chromium.org, chromium-a...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Charlie Reis and Mike West

Greg Thompson added 1 comment

Patchset-level comments
Greg Thompson . resolved

@mk...@chromium.org: PTAL //third_party/blink at your leisure. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Charlie Reis
  • Mike West
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id73b26b9c33de6a20ef5038dcf34b17a328b1b27
Gerrit-Change-Number: 8004431
Gerrit-PatchSet: 19
Gerrit-Owner: Greg Thompson <g...@chromium.org>
Gerrit-Reviewer: Charlie Reis <cr...@chromium.org>
Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Charlie Reis <cr...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 09:50:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tsuyoshi Horo (Gerrit)

unread,
Jul 8, 2026, 10:49:47 PM (6 hours ago) Jul 8
to Greg Thompson, Mike West, Charlie Reis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Hiroki Nakagawa, extension...@chromium.org, chromium-a...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Charlie Reis, Greg Thompson and Mike West

Tsuyoshi Horo added 1 comment

File content/browser/renderer_host/code_cache_backend_preparation_commit_deferring_condition.cc
Line 85, Patchset 19 (Latest):CodeCacheBackendPreparationCommitDeferringCondition::WillCommitNavigation(
Tsuyoshi Horo . unresolved

Could you add a UMA metric to measure the time elapsed from CodeCacheBackendPreparationCommitDeferringCondition::WillCommitNavigation to CodeCacheBackendPreparationCommitDeferringCondition::OnBackendsPrepared?

I am concerned that initiating the ShareReadOnlyConnection process at the time of WillCommitNavigation might be a bit too late. Wouldn't it be better to start the ShareReadOnlyConnection process earlier, such as during NavigationRequest::OnStartChecksComplete() and NavigationRequest::OnRedirectChecksComplete(), similar to the approach in my Renderer-Accessible HTTP Cache prototype?

https://crrev.com/c/7207174/355/content/browser/renderer_host/navigation_request.cc

Furthermore, although it might increase the code complexity in the renderer side, another option could be to pass a mojo remote via CommitNavigation specifically to receive the PreparedCodeCacheBackendsPtr. This approach would allow us to avoid blocking (deferring) the navigation even if the ShareReadOnlyConnection hasn't completed by the time of the navigation commit.

Open in Gerrit

Related details

Attention is currently required from:
  • Charlie Reis
  • Greg Thompson
  • Mike West
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id73b26b9c33de6a20ef5038dcf34b17a328b1b27
    Gerrit-Change-Number: 8004431
    Gerrit-PatchSet: 19
    Gerrit-Owner: Greg Thompson <g...@chromium.org>
    Gerrit-Reviewer: Charlie Reis <cr...@chromium.org>
    Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Tsuyoshi Horo <ho...@chromium.org>
    Gerrit-Attention: Greg Thompson <g...@chromium.org>
    Gerrit-Attention: Charlie Reis <cr...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 02:49:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages