Remove subresource_filter::ActivationList::SUBRESOURCE_FILTER code [chromium/src : main]

0 views
Skip to first unread message

thefrog (Gerrit)

unread,
Aug 19, 2026, 12:52:32 PM (23 hours ago) Aug 19
to Charles Harrison, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org
Attention needed from Charles Harrison

thefrog added 1 comment

Commit Message
Line 14, Patchset 5 (Latest):matches with no metadata, no such Finch config is in use.
thefrog . unresolved

@cshar...@chromium.org: could you confirm it is fine to be deprecating this?

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Harrison
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iba2da6effb3e58add1c036a24056aa39c5196f16
Gerrit-Change-Number: 8265939
Gerrit-PatchSet: 5
Gerrit-Owner: thefrog <the...@chromium.org>
Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
Gerrit-Reviewer: thefrog <the...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 16:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Charles Harrison (Gerrit)

unread,
Aug 19, 2026, 4:11:37 PM (20 hours ago) Aug 19
to thefrog, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org
Attention needed from thefrog

Charles Harrison voted and added 1 comment

Votes added by Charles Harrison

Code-Review+1

1 comment

Commit Message
Line 14, Patchset 5 (Latest):matches with no metadata, no such Finch config is in use.
thefrog . resolved

@cshar...@chromium.org: could you confirm it is fine to be deprecating this?

Charles Harrison

Yeah it's fine

Open in Gerrit

Related details

Attention is currently required from:
  • thefrog
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iba2da6effb3e58add1c036a24056aa39c5196f16
Gerrit-Change-Number: 8265939
Gerrit-PatchSet: 5
Gerrit-Owner: thefrog <the...@chromium.org>
Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
Gerrit-Reviewer: thefrog <the...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: thefrog <the...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 20:11:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: thefrog <the...@chromium.org>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages