[M151] Validate browser-initiated file uploads [chromium/src : refs/branch-heads/7922]
0 views
Skip to first unread message
Nidhi Jaju (Gerrit)
Jul 7, 2026, 4:44:20 AM (2 days ago) Jul 7
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Message from Nidhi Jaju![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jul 7, 2026, 4:45:27 AM (2 days ago) Jul 7
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Nidhi Jaju, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Message from rubber-...@appspot.gserviceaccount.com![]( "Open in Gerrit")
The current revision changed the following files compared with the initial revision: content/browser/loader/navigation_url_loader_impl.cc, services/network/public/cpp/features.cc, services/network/public/cpp/features.h. Learn more: go/rubber-stamper-user-guide.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Jul 7, 2026, 6:42:47 AM (2 days ago) Jul 7
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Nidhi Jaju, Mike West, Takashi Toyoshima, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Attention needed from Mike West, Nidhi Jaju and Takashi Toyoshima
Rakina Zata Amni voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Mike West
- Nidhi Jaju
- Takashi Toyoshima
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Jul 7, 2026, 12:15:56 PM (2 days ago) Jul 7
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Nidhi Jaju, Rakina Zata Amni, Takashi Toyoshima, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Attention needed from Nidhi Jaju and Takashi Toyoshima
Mike West voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Nidhi Jaju
- Takashi Toyoshima
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nidhi Jaju (Gerrit)
Jul 8, 2026, 1:07:23 AM (yesterday) Jul 8
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Mike West, Rakina Zata Amni, Takashi Toyoshima, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Attention needed from Mike West, Rakina Zata Amni and Takashi Toyoshima
Message from Nidhi Jaju![]( "Open in Gerrit")
Attention is currently required from:
- Mike West
- Rakina Zata Amni
- Takashi Toyoshima
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
Jul 8, 2026, 1:37:55 AM (yesterday) Jul 8
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Nidhi Jaju, Mike West, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Attention needed from Mike West, Nidhi Jaju and Rakina Zata Amni
Takashi Toyoshima voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mike West
- Nidhi Jaju
- Rakina Zata Amni
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nidhi Jaju (Gerrit)
Jul 8, 2026, 2:13:32 AM (yesterday) Jul 8
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Takashi Toyoshima, Mike West, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Attention needed from Mike West and Rakina Zata Amni
Nidhi Jaju voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Mike West
- Rakina Zata Amni
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nidhi Jaju (Gerrit)
Jul 8, 2026, 3:51:09 AM (yesterday) Jul 8
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, Takashi Toyoshima, Mike West, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Nidhi Jaju (Gerrit)
Jul 8, 2026, 5:24:51 AM (23 hours ago) Jul 8
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, Takashi Toyoshima, Mike West, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org
Nidhi Jaju submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M151] Validate browser-initiated file uploads
Original change's description:
> Validate browser-initiated file uploads
>
> This CL introduces token-based tracking and validation for files
> uploaded by the browser process to the network service.
>
> We introduce `BrowserFileAccessCallbacks` to `SimpleURLLoader`, allowing
> the browser to register file paths with `ChildProcessSecurityPolicy`.
> `ScopedBrowserFileAccess` manages token lifetimes for file paths
> originating from navigations (e.g., Web Share Target).
>
> Finally, `NetworkContextClientBaseImpl::HandleFileUploadRequest` is
> updated to validate the tokens using `CanBrowserReadFile()` when the
> originating process is the browser. This entire mechanism is gated
> behind the `kFileUploadTokenRegistration` feature flag, which is
> enabled by default.
>
> Bug: 497428001
> Change-Id: I8a06849dc69b19d3fa71c62ba2ed63813db686fa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7968017
> Reviewed-by: Alex Moshchuk <ale...@chromium.org>
> Auto-Submit: Nidhi Jaju <nidh...@chromium.org>
> Commit-Queue: Nidhi Jaju <nidh...@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1657089}
(cherry picked from commit 1fc7b5f1b300973956c4edcb7e3f8f8d56a56e6a)
Bug: 532002490,497428001
Change-Id: I8a06849dc69b19d3fa71c62ba2ed63813db686fa
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Reviewed-by: Mike West <mk...@chromium.org>
Commit-Queue: Nidhi Jaju <nidh...@chromium.org>
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7922@{#580}
Cr-Branched-From: 059c884787b1bc15faa5afe5250f7d3a7e0ef64a-refs/heads/main@{#1654411}
Files:
- M content/browser/BUILD.gn
- M content/browser/browser_main_loop.cc
- M content/browser/loader/navigation_url_loader_impl.cc
- M content/browser/loader/navigation_url_loader_impl.h
- M content/browser/network_context_client_base_impl.cc
- M content/browser/network_context_client_base_impl_unittest.cc
- A content/browser/scoped_browser_file_access.cc
- A content/browser/scoped_browser_file_access.h
- M content/browser/security/cpsp/child_process_security_policy_impl.cc
- M content/browser/security/cpsp/child_process_security_policy_impl.h
- M content/browser/security/cpsp/child_process_security_policy_unittest.cc
- M content/public/browser/child_process_security_policy.h
- M services/network/public/cpp/features.cc
- M services/network/public/cpp/features.h
- M services/network/public/cpp/simple_url_loader.cc
- M services/network/public/cpp/simple_url_loader.h
Change size: L
Delta: 16 files changed, 369 insertions(+), 15 deletions(-)
Branch: refs/branch-heads/7922
Submit Requirements:
Code-Review: +1 by Mike West, +1 by Takashi Toyoshima, +1 by Rakina Zata Amni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages