[SAA] Remove renderer->browser IPC and fix race condition [chromium/src : main]
Chris Fredrickson (Gerrit)
Chris Fredrickson added 1 comment![]( "Open in Gerrit")
+ari for force-allow-storage-access removals;
+elklm for permission_controller_impl.cc;
I'll tag more reviewers later if this looks fine to you both.
Related details
- Ari Chivukula
- Elias Klim
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ari Chivukula
| Code-Review | +1 |
1 comment
net::StorageAccessApiStatus::kAccessViaAPI);We only worry about grants because denials don't change state, and revocations are another path requiring navigation retry?
Related details
- Chris Fredrickson
- Elias Klim
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Fredrickson (Gerrit)
Chris Fredrickson added 1 comment![]( "Open in Gerrit")
We only worry about grants because denials don't change state, and revocations are another path requiring navigation retry?
Right, `ask->denied` doesn't change RFH state; `granted->denied` and `granted->ask` doesn't trigger a state change for non-overridden permissions so we don't trigger one here either. (The granted->not granted transition triggers a butter bar asking the user to reload, IIRC. It doesn't reload automatically because the user might have been in the middle of something on the page.)
Related details
- Elias Klim
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |