Remove no-longer-needed dependency on DataDecoder service [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Jul 30, 2026, 1:24:36 PM (16 hours ago) Jul 30
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, Nate Chapin, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, zol...@webkit.org
Attention needed from Lei Zhang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2b8af2cff0dda6f201cb1ff455cf49acac5b92e0
Gerrit-Change-Number: 7934651
Gerrit-PatchSet: 19
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 17:24:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jul 30, 2026, 1:31:30 PM (16 hours ago) Jul 30
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, Nate Chapin, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, zol...@webkit.org
Attention needed from Daniel Cheng

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2b8af2cff0dda6f201cb1ff455cf49acac5b92e0
Gerrit-Change-Number: 7934651
Gerrit-PatchSet: 20
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 17:31:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jul 30, 2026, 2:01:29 PM (16 hours ago) Jul 30
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, Nate Chapin, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, zol...@webkit.org

Daniel Cheng voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2b8af2cff0dda6f201cb1ff455cf49acac5b92e0
Gerrit-Change-Number: 7934651
Gerrit-PatchSet: 21
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 18:01:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 30, 2026, 2:08:45 PM (15 hours ago) Jul 30
to Daniel Cheng, Lei Zhang, chromium...@chromium.org, Hans Wennborg, Nate Chapin, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, zol...@webkit.org

Chromium LUCI CQ submitted the change

Unreviewed changes

20 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Remove no-longer-needed dependency on DataDecoder service

All uses have been migrated to use base::JSONReader directly.
Bug: 459848478
Change-Id: I2b8af2cff0dda6f201cb1ff455cf49acac5b92e0
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1671236}
Files:
  • M chrome/browser/new_tab_page/BUILD.gn
Change size: XS
Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lei Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2b8af2cff0dda6f201cb1ff455cf49acac5b92e0
Gerrit-Change-Number: 7934651
Gerrit-PatchSet: 22
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages