[gin] Move HeapMojoRemote to gin [chromium/src : main]

0 views

Skip to first unread message

Andreas Haas (Gerrit)

unread,

Sep 15, 2025, 7:54:18 AM (2 days ago) Sep 15

to Nate Chapin, Alex Keng, Chromium LUCI CQ, AyeAye, loading...@chromium.org, gavinp...@chromium.org, feature-me...@chromium.org, blink-revi...@chromium.org, steimel+watch...@chromium.org, video-networking...@google.com, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org

Attention needed from Andreas Haas

Message from Andreas Haas

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Andreas Haas

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

AI Code Reviewer (Gerrit)

unread,

Sep 15, 2025, 8:00:45 AM (2 days ago) Sep 15

to Andreas Haas, Nate Chapin, Alex Keng, Chromium LUCI CQ, AyeAye, loading...@chromium.org, gavinp...@chromium.org, feature-me...@chromium.org, blink-revi...@chromium.org, steimel+watch...@chromium.org, video-networking...@google.com, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org

Attention needed from Andreas Haas

AI Code Reviewer added 1 comment

File third_party/blink/renderer/platform/context_lifecycle_notifier.h

Line 29, Patchset 10 (Latest): const HeapObserverList<gin::ContextLifecycleObserver>& observers() const {

AI Code Reviewer . unresolved

nit: Blink Style Guide: Naming - Use 'CamelCase' for all function names. Please rename `observers` to `Observers` to follow the CamelCase convention used by other functions in this file.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_