[soft navs] Move soft LCP into PageLoadMetricsUpdateDispatcher [chromium/src : main]
0 views
Skip to first unread message
Johannes Henkel (Gerrit)
Feb 19, 2026, 12:06:09 AM (yesterday) Feb 19
to Annie Sullivan, Michal Mocny, Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Michal Mocny and Scott Haseley
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Annie Sullivan
- Michal Mocny
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Feb 19, 2026, 12:00:20 PM (22 hours ago) Feb 19
to Johannes Henkel, Annie Sullivan, Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Johannes Henkel and Scott Haseley
Michal Mocny voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Annie Sullivan
- Johannes Henkel
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Feb 19, 2026, 12:34:48 PM (22 hours ago) Feb 19
to Scott Haseley, Annie Sullivan, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Johannes Henkel . resolved
Thanks a lot, will get this one submitted.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 19, 2026, 12:38:00 PM (22 hours ago) Feb 19
to Johannes Henkel, Scott Haseley, Annie Sullivan, Michal Mocny, chromium...@chromium.org, bmcquad...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[soft navs] Move soft LCP into PageLoadMetricsUpdateDispatcher
This makes soft lcp consistent with soft inp and soft cls, to make the
ownership of the objects / data more consistent.
Previously (-> means owns):
page load tracker
-> page load metrics update dispatcher
-> soft inp info
-> soft cls info
-> lcp handler
-> soft lcp info
Now:
page load tracker
-> page load metrics update dispatcher
-> soft inp info
-> soft cls info
-> soft lcp info
-> lcp handler
This is a pure refactoring; the objective is to prepare for revamping
the logic in void PageLoadMetricsUpdateDispatcher::UpdateMetrics, which
updates soft inp / cls, then informs the page load tracker of a new soft
navigation (and along with it potentially a new soft lcp) so that the
tracker informs the observers and then resets things for the next round.
With the current ownership structure of the data, it would be very
difficult to change this logic - so here, I'd like to simply move the
soft LCP part into the page load metrics update dispatcher. This means
later, this dispatcher can more directly update the soft lcp, and the
notification for the new soft nav no longer needs to carry the soft lcp.
Bug: 485887821
Change-Id: I11064afb3049a21c5b480cfcccdea2cd06f665c2
Reviewed-by: Michal Mocny <mmo...@chromium.org>
Commit-Queue: Johannes Henkel <joha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1587222}
Files:
- M chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer.cc
- M components/page_load_metrics/browser/fake_page_load_metrics_observer_delegate.cc
- M components/page_load_metrics/browser/fake_page_load_metrics_observer_delegate.h
- M components/page_load_metrics/browser/observers/core/largest_contentful_paint_handler.cc
- M components/page_load_metrics/browser/observers/core/largest_contentful_paint_handler.h
- M components/page_load_metrics/browser/page_load_metrics_observer_delegate.h
- M components/page_load_metrics/browser/page_load_metrics_update_dispatcher.cc
- M components/page_load_metrics/browser/page_load_metrics_update_dispatcher.h
- M components/page_load_metrics/browser/page_load_tracker.cc
- M components/page_load_metrics/browser/page_load_tracker.h
Change size: M
Delta: 10 files changed, 74 insertions(+), 49 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michal Mocny
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages