Ken Okada (Gerrit)

unread,

Aug 14, 2026, 8:53:23 AM (6 days ago) Aug 14

to Taiyo Mizuhashi, Huanpo Lin, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Huanpo Lin and Taiyo Mizuhashi

Ken Okada added 2 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Ken Okada . resolved

Could you have a look?

File components/page_load_metrics/browser/observers/preload_serving_metrics_page_load_metrics_observer.cc

Line 114, Patchset 3: CHECK(navigation_initiator_string_.has_value());

Ken Okada . unresolved

See https://chromium-review.git.corp.google.com/c/chromium/src/+/8255994 for refcatoring.

Open in Gerrit

Related details

Attention is currently required from:

Huanpo Lin
Taiyo Mizuhashi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Taiyo Mizuhashi (Gerrit)

unread,

Aug 19, 2026, 2:14:17 AM (yesterday) Aug 19

to Ken Okada, Huanpo Lin, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Huanpo Lin and Ken Okada

Taiyo Mizuhashi voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Huanpo Lin
Ken Okada

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Okada (Gerrit)

unread,

Aug 19, 2026, 2:59:50 AM (yesterday) Aug 19

to Simon Pelchat, Taiyo Mizuhashi, Huanpo Lin, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Huanpo Lin and Simon Pelchat

Ken Okada added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Ken Okada . resolved

Owner review. Simon, could you have a look at histograms?

Open in Gerrit

Related details

Attention is currently required from:

Huanpo Lin
Simon Pelchat

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simon Pelchat (Gerrit)

unread,

Aug 19, 2026, 12:49:57 PM (23 hours ago) Aug 19

to Ken Okada, Taiyo Mizuhashi, Huanpo Lin, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Huanpo Lin and Ken Okada

Simon Pelchat voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Huanpo Lin
Ken Okada

satisfied_requirement

unsatisfied_requirement

open

diffy

Huanpo Lin (Gerrit)

unread,

Aug 19, 2026, 10:47:14 PM (13 hours ago) Aug 19

to Ken Okada, Simon Pelchat, Taiyo Mizuhashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Ken Okada

Huanpo Lin voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ken Okada

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Okada (Gerrit)

unread,

1:59 AM (10 hours ago) 1:59 AM

to Takashi Toyoshima, Huanpo Lin, Simon Pelchat, Taiyo Mizuhashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Takashi Toyoshima

Ken Okada added 2 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Ken Okada . resolved

Owner review

toyoshim@, could you have a look at PLMO?

File components/page_load_metrics/browser/observers/preload_serving_metrics_page_load_metrics_observer.cc

Line 114, Patchset 3: CHECK(navigation_initiator_string_.has_value());

Ken Okada . resolved

See https://chromium-review.git.corp.google.com/c/chromium/src/+/8255994 for refcatoring.

Ken Okada

Done

Open in Gerrit

Related details

Attention is currently required from:

Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Okada (Gerrit)

unread,

2:21 AM (9 hours ago) 2:21 AM

to Rakina Zata Amni, Takashi Toyoshima, Huanpo Lin, Simon Pelchat, Taiyo Mizuhashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Rakina Zata Amni and Takashi Toyoshima

Ken Okada added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Ken Okada . resolved

+rakina@ for content/public/browser/preload_serving_metrics_capsule.h

Open in Gerrit

Related details

Attention is currently required from:

Rakina Zata Amni
Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rakina Zata Amni (Gerrit)

unread,

3:36 AM (8 hours ago) 3:36 AM

to Ken Okada, Takashi Toyoshima, Huanpo Lin, Simon Pelchat, Taiyo Mizuhashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Ken Okada and Takashi Toyoshima

Rakina Zata Amni voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ken Okada
Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Takashi Toyoshima (Gerrit)

unread,

4:12 AM (8 hours ago) 4:12 AM

to Ken Okada, Rakina Zata Amni, Huanpo Lin, Simon Pelchat, Taiyo Mizuhashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Ken Okada

Takashi Toyoshima voted and added 2 comments

Votes added by Takashi Toyoshima

Commit-Queue

+2

2 comments

File content/browser/preloading/preload_serving_metrics.cc

Line 506, Patchset 11 (Latest): const std::array<std::string_view, 2> navigation_initiators = {

Takashi Toyoshima . unresolved

Suggestion: We can avoid the std::vector heap allocation on the FCP recording path by using base::span with static constexpr arrays, e.g.:

```cpp
  static constexpr std::string_view kAllOnly[] = {"All"};
  static constexpr std::string_view kAllAndSrp[] = {"All", "SRP"};
  const base::span<const std::string_view> srp_alls =
      is_url_srp ? kAllAndSrp : kAllOnly;

File content/public/browser/preload_serving_metrics_capsule.h

Line 40, Patchset 11 (Latest): const std::string& navigation_initiator_string,

Takashi Toyoshima . unresolved

Suggestion: Consider using `std::string_view` instead of `const std::string&` for `navigation_initiator_string` to follow modern Chromium C++ string parameter conventions (and similarly in `preload_serving_metrics.h` / `.cc`).

Open in Gerrit

Related details

Attention is currently required from:

Ken Okada

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Takashi Toyoshima (Gerrit)

unread,

4:12 AM (8 hours ago) 4:12 AM

to Ken Okada, Rakina Zata Amni, Huanpo Lin, Simon Pelchat, Taiyo Mizuhashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Ken Okada

Takashi Toyoshima voted Commit-Queue+1

Commit-Queue

+1

satisfied_requirement

unsatisfied_requirement

open

diffy

Takashi Toyoshima (Gerrit)

unread,

4:13 AM (8 hours ago) 4:13 AM

to Ken Okada, Rakina Zata Amni, Huanpo Lin, Simon Pelchat, Taiyo Mizuhashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Ken Okada and Takashi Toyoshima

Takashi Toyoshima voted and added 1 comment

Votes added by Takashi Toyoshima

Code-Review	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Takashi Toyoshima . resolved

+1 with nits
(sorry, mistakenly pushed CQ+2)

Open in Gerrit

Related details

Attention is currently required from:

Ken Okada
Takashi Toyoshima

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Okada (Gerrit)

unread,

5:00 AM (7 hours ago) 5:00 AM

to Takashi Toyoshima, Rakina Zata Amni, Huanpo Lin, Simon Pelchat, Taiyo Mizuhashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Attention needed from Takashi Toyoshima

Ken Okada added 2 comments

File content/browser/preloading/preload_serving_metrics.cc

Line 506, Patchset 11: const std::array<std::string_view, 2> navigation_initiators = {

Takashi Toyoshima . resolved

Suggestion: We can avoid the std::vector heap allocation on the FCP recording path by using base::span with static constexpr arrays, e.g.:
```cpp
  static constexpr std::string_view kAllOnly[] = {"All"};
  static constexpr std::string_view kAllAndSrp[] = {"All", "SRP"};
  const base::span<const std::string_view> srp_alls =
      is_url_srp ? kAllAndSrp : kAllOnly;

Ken Okada

Done

File content/public/browser/preload_serving_metrics_capsule.h

Line 40, Patchset 11: const std::string& navigation_initiator_string,

Takashi Toyoshima . resolved

Suggestion: Consider using `std::string_view` instead of `const std::string&` for `navigation_initiator_string` to follow modern Chromium C++ string parameter conventions (and similarly in `preload_serving_metrics.h` / `.cc`).

Ken Okada

Done

Open in Gerrit

Related details

Attention is currently required from:

Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

7:39 AM (4 hours ago) 7:39 AM

to Ken Okada, Takashi Toyoshima, Rakina Zata Amni, Huanpo Lin, Simon Pelchat, Taiyo Mizuhashi, chromium...@chromium.org, prerendering-reviews, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, gavin...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

11 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: content/browser/preloading/preload_serving_metrics.h
Insertions: 5, Deletions: 4.

The diff is too large to show. Please review the diff.
```
```
The name of the file: content/browser/preloading/preload_serving_metrics.cc
Insertions: 11, Deletions: 7.

The diff is too large to show. Please review the diff.
```
```
The name of the file: content/public/browser/preload_serving_metrics_capsule.h
Insertions: 3, Deletions: 2.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

PreloadServingMetrics: Record FCP with InitiatorLocation and SRP variants

This is a preparation of https://crrev.com/c/8255995.

Record UMA
PreloadServingMetrics.PageLoad.Clients.PaintTiming.NavigationToFirstContentfulPaint.WithoutFiltering.{InitiatorLocation}.{NavigationDestinationSuffix}.{UsedInstantLoad}.

Note that FCP for BFCache is not recorded. See [1] how
`BackForwardCachePageLoadMetricsObserver` handles it.

[1]
https://source.chromium.org/chromium/chromium/src/+/main:components/page_load_metrics/browser/observers/back_forward_cache_page_load_metrics_observer.cc;l=194-195;drc=7dba004a4ad3584c1e1555a7d62eefb62ec00775

TAG=agy
CONV=5d71549e-0061-42b8-a2c5-9289dcd6183d

Bug: 517725655

Change-Id: I6b5cd20be987c91106adf9a5f4611d24842c3907

Co-Authored-By: Gemini <nor...@google.com>

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8255993

Reviewed-by: Huanpo Lin <robe...@chromium.org>

Reviewed-by: Rakina Zata Amni <rak...@chromium.org>

Reviewed-by: Simon Pelchat <spel...@chromium.org>

Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>

Reviewed-by: Taiyo Mizuhashi <ta...@chromium.org>

Commit-Queue: Ken Okada <ken...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1683039}

Files:

M components/page_load_metrics/browser/observers/preload_serving_metrics_page_load_metrics_observer.cc
M content/browser/preloading/preload_serving_metrics.cc
M content/browser/preloading/preload_serving_metrics.h
M content/browser/preloading/preload_serving_metrics_unittest.cc
M content/public/browser/preload_serving_metrics_capsule.h
M tools/metrics/histograms/metadata/preloading/histograms.xml

Change size: M

Delta: 6 files changed, 171 insertions(+), 41 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Taiyo Mizuhashi, +1 by Takashi Toyoshima, +1 by Simon Pelchat, +1 by Huanpo Lin, +1 by Rakina Zata Amni

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

PreloadServingMetrics: Record FCP with InitiatorLocation and SRP variants [chromium/src : main]

Ken Okada (Gerrit)

Ken Okada added 2 comments

Related details

Taiyo Mizuhashi (Gerrit)

Taiyo Mizuhashi voted Code-Review+1

Related details

Ken Okada (Gerrit)

Ken Okada added 1 comment

Related details

Simon Pelchat (Gerrit)

Simon Pelchat voted Code-Review+1

Related details

Huanpo Lin (Gerrit)

Huanpo Lin voted Code-Review+1

Related details

Ken Okada (Gerrit)

Ken Okada added 2 comments

Related details

Ken Okada (Gerrit)

Ken Okada added 1 comment

Related details

Rakina Zata Amni (Gerrit)

Rakina Zata Amni voted Code-Review+1

Related details

Takashi Toyoshima (Gerrit)

Takashi Toyoshima voted and added 2 comments

Votes added by Takashi Toyoshima

2 comments

Related details

Takashi Toyoshima (Gerrit)

Takashi Toyoshima voted Commit-Queue+1

Takashi Toyoshima (Gerrit)

Takashi Toyoshima voted and added 1 comment

Votes added by Takashi Toyoshima

1 comment

Related details

Ken Okada (Gerrit)

Ken Okada added 2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information