Navigation-Timing: destination-based TAO [chromium/src : main]

0 views

Skip to first unread message

Yoav Weiss (@Shopify) (Gerrit)

unread,

Jun 10, 2026, 5:45:23 AM (yesterday) Jun 10

to Noam Rosenthal, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org

Attention needed from Noam Rosenthal

Yoav Weiss (@Shopify) voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Noam Rosenthal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Noam Rosenthal (Gerrit)

unread,

Jun 10, 2026, 6:29:33 AM (yesterday) Jun 10

to Yoav Weiss (@Shopify), Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org

Attention needed from Yoav Weiss (@Shopify)

Noam Rosenthal added 2 comments

File third_party/blink/renderer/core/loader/document_load_timing.h

Line 70, Patchset 4 (Latest): bool navigation_timing_allow_check_set_has_wildcard = true;

Noam Rosenthal . unresolved

Maybe just hold a TimingAllowPtr? It's anyway a union of "All" and a vector of strings. This way if there's just one you clone it as is.

File third_party/blink/renderer/core/loader/document_load_timing.cc

Line 202, Patchset 4 (Latest):void DocumentLoadTiming::RestrictNavigationTimingAllowCheckSet(

Noam Rosenthal . unresolved

This seems like a lot of work. Why not save a vector of TimingAllowOriginPtr, and iterate over it in a method called from ComputeExposeCrossOriginRedirectTiming