Revert "Keep browser alive while fetch keepalive URLLoaders exist" [chromium/src : main]

0 views
Skip to first unread message

Shunya Shishido (Gerrit)

unread,
Jul 30, 2026, 9:56:56 PM (8 hours ago) Jul 30
to rubber-...@appspot.gserviceaccount.com, Helmut Januschka, Chromium LUCI CQ, Nicolas Ouellet-Payeur, Ryan Sultanem, Greg Thompson, Ming-Ying Chung, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, Barry Pollard, chromium...@chromium.org, Chromium Metrics Reviews, loading...@chromium.org, asvitkine...@chromium.org
Attention needed from Greg Thompson, Helmut Januschka, Ming-Ying Chung, Nicolas Ouellet-Payeur, Rakina Zata Amni and Ryan Sultanem

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Greg Thompson
  • Helmut Januschka
  • Ming-Ying Chung
  • Nicolas Ouellet-Payeur
  • Rakina Zata Amni
  • Ryan Sultanem
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e19338c81b70007affc4f74b6688984e458ec28
Gerrit-Change-Number: 8174046
Gerrit-PatchSet: 1
Gerrit-Owner: Shunya Shishido <sisid...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Ming-Ying Chung <my...@chromium.org>
Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>
Gerrit-CC: Barry Pollard <barryp...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
Gerrit-Attention: Ryan Sultanem <rs...@google.com>
Gerrit-Attention: Greg Thompson <g...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Attention: Ming-Ying Chung <my...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Jul 2026 01:56:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 30, 2026, 9:57:23 PM (8 hours ago) Jul 30
to Shunya Shishido, Helmut Januschka, Chromium LUCI CQ, Nicolas Ouellet-Payeur, Ryan Sultanem, Greg Thompson, Ming-Ying Chung, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, Barry Pollard, chromium...@chromium.org, Chromium Metrics Reviews, loading...@chromium.org, asvitkine...@chromium.org
Attention needed from Greg Thompson, Helmut Januschka, Ming-Ying Chung, Nicolas Ouellet-Payeur, Rakina Zata Amni and Ryan Sultanem

Related details

Attention is currently required from:
  • Greg Thompson
  • Helmut Januschka
  • Ming-Ying Chung
  • Nicolas Ouellet-Payeur
  • Rakina Zata Amni
  • Ryan Sultanem
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Comment-Date: Fri, 31 Jul 2026 01:57:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Shunya Shishido (Gerrit)

    unread,
    Jul 30, 2026, 9:58:11 PM (8 hours ago) Jul 30
    to rubber-...@appspot.gserviceaccount.com, Helmut Januschka, Chromium LUCI CQ, Nicolas Ouellet-Payeur, Ryan Sultanem, Greg Thompson, Ming-Ying Chung, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, Barry Pollard, chromium...@chromium.org, Chromium Metrics Reviews, loading...@chromium.org, asvitkine...@chromium.org
    Attention needed from Greg Thompson, Helmut Januschka, Ming-Ying Chung, Nicolas Ouellet-Payeur, Rakina Zata Amni and Ryan Sultanem

    Shunya Shishido voted

    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Greg Thompson
    • Helmut Januschka
    • Ming-Ying Chung
    • Nicolas Ouellet-Payeur
    • Rakina Zata Amni
    • Ryan Sultanem
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8e19338c81b70007affc4f74b6688984e458ec28
    Gerrit-Change-Number: 8174046
    Gerrit-PatchSet: 1
    Gerrit-Owner: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Ming-Ying Chung <my...@chromium.org>
    Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Barry Pollard <barryp...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Attention: Ryan Sultanem <rs...@google.com>
    Gerrit-Attention: Greg Thompson <g...@chromium.org>
    Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Attention: Ming-Ying Chung <my...@chromium.org>
    Gerrit-Comment-Date: Fri, 31 Jul 2026 01:57:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 30, 2026, 9:58:39 PM (8 hours ago) Jul 30
    to Shunya Shishido, rubber-...@appspot.gserviceaccount.com, Helmut Januschka, Nicolas Ouellet-Payeur, Ryan Sultanem, Greg Thompson, Ming-Ying Chung, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, Barry Pollard, chromium...@chromium.org, Chromium Metrics Reviews, loading...@chromium.org, asvitkine...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Keep browser alive while fetch keepalive URLLoaders exist"

    This reverts commit 4400961e2e454193ca1685207ee9eb065ddd665c.

    Reason for revert: Multiple tests are failing on Linux UBSan Tests.

    Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/17350/overview

    Original change's description:
    > Keep browser alive while fetch keepalive URLLoaders exist
    >
    > Holds a ScopedKeepAlive while any fetch keepalive URLLoader (including
    > pending fetchLater) exists, gated by the default-off
    > kKeepAliveBrowserProcessAlive feature, so closing the last window does
    > not drop pending requests.
    >
    > Bug: 408010432
    > Change-Id: I8a8d2d7a8770e8f1cdedf9d279db2359a5192ff4
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7972217
    > Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
    > Reviewed-by: Ming-Ying Chung <my...@chromium.org>
    > Reviewed-by: Ryan Sultanem <rs...@google.com>
    > Auto-Submit: Helmut Januschka <hel...@januschka.com>
    > Reviewed-by: Nicolas Ouellet-Payeur <nico...@chromium.org>
    > Reviewed-by: Greg Thompson <g...@chromium.org>
    > Commit-Queue: Helmut Januschka <hel...@januschka.com>
    > Cr-Commit-Position: refs/heads/main@{#1670925}
    Bug: 408010432, 541001622
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 408010432
    Change-Id: I8e19338c81b70007affc4f74b6688984e458ec28
    Owners-Override: Shunya Shishido <sisid...@chromium.org>
    Commit-Queue: Shunya Shishido <sisid...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1671591}
    Files:
    • M chrome/browser/chrome_content_browser_client.cc
    • M chrome/browser/chrome_content_browser_client.h
    • M chrome/browser/loader/BUILD.gn
    • D chrome/browser/loader/features.cc
    • D chrome/browser/loader/features.h
    • D chrome/browser/loader/fetch_keepalive_process_manager.cc
    • D chrome/browser/loader/fetch_keepalive_process_manager.h
    • D chrome/browser/loader/keep_alive_browser_process_alive_browsertest.cc
    • M chrome/browser/profiles/keep_alive/profile_keep_alive_types.cc
    • M chrome/browser/profiles/keep_alive/profile_keep_alive_types.h
    • M components/keep_alive_registry/keep_alive_types.cc
    • M components/keep_alive_registry/keep_alive_types.h
    • M content/browser/loader/keep_alive_url_loader.cc
    • M content/public/browser/content_browser_client.cc
    • M content/public/browser/content_browser_client.h
    • M tools/metrics/histograms/metadata/chrome/histograms.xml
    • M tools/metrics/histograms/metadata/profile/enums.xml
    Change size: L
    Delta: 17 files changed, 1 insertion(+), 479 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8e19338c81b70007affc4f74b6688984e458ec28
    Gerrit-Change-Number: 8174046
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages