[Fenced Frames] Remove window.fence.disableUntrustedNetwork code [chromium/src : main]
0 views
Skip to first unread message
Daniel Ramoz (Gerrit)
Apr 4, 2026, 1:04:49 PMApr 4
to Shivani Sharma, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Shivani Sharma
Daniel Ramoz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Shivani Sharma
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaochen Zhou (Gerrit)
Apr 6, 2026, 5:29:56 PMApr 6
to Shivani Sharma, Andrew Verge, AyeAye, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Shivani Sharma
Xiaochen Zhou voted and added 3 comments![]( "Open in Gerrit")
Votes added by Xiaochen Zhou
| Code-Review | +1 |
3 comments
Patchset-level comments
File services/network/public/mojom/network_context.mojom
Line 971, Patchset 21 (Latest):
// why network restrictions doesn’t apply to that request. More context onXiaochen Zhou . unresolved
nit: don't instead of doesn't
File tools/metrics/histograms/metadata/blink/enums.xml
Line 5993, Patchset 21 (Latest):
<int value="5378" label="OBSOLETE_FencedFrameDisableUntrustedNetwork"/>Xiaochen Zhou . unresolved
nit: Add an obsoletion message to CL description:
`OBSOLETE_HISTOGRAM[Blink.FencedFrame.DisableUntrustedNetworkOutcome]=Feature has been deprecated`
Histogram [doc](https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#add-an-obsoletion-message).
Related details
Attention is currently required from:
- Shivani Sharma
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shivani Sharma (Gerrit)
Apr 7, 2026, 7:17:40 PMApr 7
to Xiaochen Zhou, Andrew Verge, AyeAye, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Shivani Sharma added 2 comments![]( "Open in Gerrit")
File services/network/public/mojom/network_context.mojom
Line 971, Patchset 21:
// why network restrictions doesn’t apply to that request. More context onXiaochen Zhou . resolved
nit: don't instead of doesn't
Shivani Sharma
Done
File tools/metrics/histograms/metadata/blink/enums.xml
Line 5993, Patchset 21:
<int value="5378" label="OBSOLETE_FencedFrameDisableUntrustedNetwork"/>Xiaochen Zhou . resolved
nit: Add an obsoletion message to CL description:
`OBSOLETE_HISTOGRAM[Blink.FencedFrame.DisableUntrustedNetworkOutcome]=Feature has been deprecated`Histogram [doc](https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#add-an-obsoletion-message).
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaochen Zhou (Gerrit)
Apr 16, 2026, 8:17:21 AM (13 days ago) Apr 16
to Shivani Sharma, Andrew Verge, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Shivani Sharma
Xiaochen Zhou voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Shivani Sharma
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shivani Sharma (Gerrit)
Apr 16, 2026, 10:15:23 AM (13 days ago) Apr 16
to Mike West, Xiaochen Zhou, Andrew Verge, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Mike West
Shivani Sharma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 28 (Latest):
Shivani Sharma . unresolved
Mike, in addition to the files you have ownership for, can you also PTAL at services/network/network_context.cc since it interacts with the Connection Allowlists logic, thanks!
Related details
Attention is currently required from:
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Apr 17, 2026, 8:54:55 AM (12 days ago) Apr 17
to Shivani Sharma, Xiaochen Zhou, Andrew Verge, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Shivani Sharma
Mike West voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mike West
| Code-Review | +1 |
1 comment
Patchset-level comments
Mike West . resolved
-7k lines is a lot. 😊
I walked through the mojo files, the blink files, and the change to network context. They look reasonable to me. I don't have the context to know whether there are other bits and pieces that should be removed along with this; I'll rely on you, Andrew, and Xiaochen for completeness.
Related details
Attention is currently required from:
- Shivani Sharma
Shivani Sharma (Gerrit)
Apr 17, 2026, 9:43:36 AM (12 days ago) Apr 17
to Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Andrew Verge
Shivani Sharma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mike West . resolved
-7k lines is a lot. 😊
I walked through the mojo files, the blink files, and the change to network context. They look reasonable to me. I don't have the context to know whether there are other bits and pieces that should be removed along with this; I'll rely on you, Andrew, and Xiaochen for completeness.
Attention is currently required from:
- Andrew Verge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shivani Sharma (Gerrit)
Apr 17, 2026, 9:44:38 AM (12 days ago) Apr 17
to Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Andrew Verge
Shivani Sharma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Shivani Sharma . resolved
Mike, in addition to the files you have ownership for, can you also PTAL at services/network/network_context.cc since it interacts with the Connection Allowlists logic, thanks!
Shivani Sharma
Done
Related details
Attention is currently required from:
- Andrew Verge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Verge (Gerrit)
Apr 24, 2026, 10:42:17 AM (5 days ago) Apr 24
to Shivani Sharma, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Shivani Sharma
Andrew Verge voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andrew Verge
| Code-Review | +1 |
2 comments
File services/network/network_context.cc
Line 3754, Patchset 28 (Latest):
} /* kConnectionAllowlists */Andrew Verge . unresolved
Is putting the name of the feature flag at the bottom of the block common practice?
Line 3786, Patchset 28 (Parent):
// Temporary disgusting hack: if we have a NetworkRestriction but we've notAndrew Verge . resolved
Perhaps the first time in history that this statement was true 😊
Related details
Attention is currently required from:
- Shivani Sharma
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shivani Sharma (Gerrit)
Apr 24, 2026, 11:02:15 AM (5 days ago) Apr 24
to Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Shivani Sharma added 1 comment![]( "Open in Gerrit")
File services/network/network_context.cc
Line 3754, Patchset 28 (Latest):
} /* kConnectionAllowlists */Andrew Verge . resolved
Is putting the name of the feature flag at the bottom of the block common practice?
Shivani Sharma
The if statement got so long that I added this for readability.
The plan is to actually do an early return if the feature is not enabled, but I will do it in a follow up, so that this CL is primarily removing code.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shivani Sharma (Gerrit)
Apr 25, 2026, 11:02:53 AM (4 days ago) Apr 25
to Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Kenichi Ishibashi
Shivani Sharma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 29 (Latest):
Shivani Sharma . resolved
@bashi@: PTAL at services/network for owners approval, thanks!
Related details
Attention is currently required from:
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
Apr 26, 2026, 8:49:07 PM (3 days ago) Apr 26
to Shivani Sharma, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Shivani Sharma
Kenichi Ishibashi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Shivani Sharma
Shivani Sharma (Gerrit)
Apr 27, 2026, 9:44:13 AM (2 days ago) Apr 27
to Alex Moshchuk, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Alex Moshchuk
Shivani Sharma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Shivani Sharma . resolved
Alex, PTAL at content/browser/renderer_host and content/public/browser for owner's approval, thanks!
Related details
Attention is currently required from:
- Alex Moshchuk
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shivani Sharma (Gerrit)
Apr 27, 2026, 10:26:20 AM (2 days ago) Apr 27
to Sophie Chang, Alex Moshchuk, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Alex Moshchuk and Sophie Chang
Shivani Sharma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 30 (Latest):
Shivani Sharma . resolved
Sophie, PTAL at chrome/browser/* for owner's approval, thanks!
Related details
Attention is currently required from:
- Alex Moshchuk
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
Apr 27, 2026, 12:25:16 PM (2 days ago) Apr 27
to Shivani Sharma, Alex Moshchuk, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Alex Moshchuk and Shivani Sharma
Sophie Chang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Moshchuk
- Shivani Sharma
Shivani Sharma (Gerrit)
Apr 27, 2026, 5:33:52 PM (2 days ago) Apr 27
to Mason Freed, Sophie Chang, Alex Moshchuk, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Alex Moshchuk and Mason Freed
Shivani Sharma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Shivani Sharma . resolved
Mason, PTAL at VirtualTestSuites for owners approval, thanks!
Related details
Attention is currently required from:
- Alex Moshchuk
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Moshchuk (Gerrit)
Apr 27, 2026, 5:57:46 PM (2 days ago) Apr 27
to Shivani Sharma, Mason Freed, Sophie Chang, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Mason Freed and Shivani Sharma
Alex Moshchuk voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Moshchuk
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 29:
Shivani Sharma . resolved
Alex MoshchukAlex, PTAL at content/browser/renderer_host and content/public/browser for owner's approval, thanks!
Those LGTM, thanks!
Related details
Attention is currently required from:
- Mason Freed
- Shivani Sharma
Mason Freed (Gerrit)
Apr 28, 2026, 10:51:46 AM (yesterday) Apr 28
to Shivani Sharma, Alex Moshchuk, Sophie Chang, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Shivani Sharma
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 30 (Latest):
Mason Freed . resolved
third_party/blink/web_tests/VirtualTestSuites LGTM!
Kudos on removing 7000+ lines of code! 🎉
Related details
Attention is currently required from:
- Shivani Sharma
Shivani Sharma (Gerrit)
Apr 28, 2026, 1:42:50 PM (yesterday) Apr 28
to Nicolás Peña, Mason Freed, Alex Moshchuk, Sophie Chang, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Nicolás Peña
Shivani Sharma added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Nicolás Peña
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Apr 28, 2026, 3:26:25 PM (yesterday) Apr 28
to Shivani Sharma, Mason Freed, Alex Moshchuk, Sophie Chang, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Attention needed from Shivani Sharma
Nicolás Peña voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicolás Peña
| Code-Review | +1 |
1 comment
Patchset-level comments
Nicolás Peña . resolved
tools/metrics/histograms/metadata/blink/histograms.xml lgtm
Related details
Attention is currently required from:
- Shivani Sharma
Submit Requirements:
Code-Coverage
Code-Owners
Shivani Sharma (Gerrit)
Apr 28, 2026, 3:54:21 PM (yesterday) Apr 28
to Nicolás Peña, Mason Freed, Alex Moshchuk, Sophie Chang, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Shivani Sharma added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Mason Freed . resolved
third_party/blink/web_tests/VirtualTestSuites LGTM!
Kudos on removing 7000+ lines of code! 🎉
Shivani Sharma
Thanks 😊
Shivani Sharma (Gerrit)
Apr 28, 2026, 3:54:23 PM (yesterday) Apr 28
to Nicolás Peña, Mason Freed, Alex Moshchuk, Sophie Chang, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Shivani Sharma voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Apr 28, 2026, 4:00:09 PM (yesterday) Apr 28
to Shivani Sharma, Nicolás Peña, Mason Freed, Alex Moshchuk, Sophie Chang, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Fenced Frames] Remove window.fence.disableUntrustedNetwork code
This is the 2nd CL in a series that removes fenced storage read(FSR)
code. This CL does the following:
- removes window.fence.disableUntrustedNetwork API surface and its
implementation.
1st CL: https://chromium-review.googlesource.com/c/chromium/src/+/7709973
Follow up CLs will remove fence.notifyEvent
Fenced Storage Read's "do not launch" status announcement:
https://privacysandbox.google.com/overview/status
window.fence.disableUntrustedNetwork is gated behind a default disabled
feature flag and it was never enabled, so this CL does not impact any
launched behavior.
OBSOLETE_HISTOGRAM[Blink.FencedFrame.DisableUntrustedNetworkOutcome]=Feature has been deprecated
Also modified
NetworkServiceRestartBrowserTest.RestoreNetworkRevocationNonces to work
for Connection Allowlists.
Bug: 499191497
Change-Id: Ie03a9fd24dda8850ee25bd5407f4961743fefded
Reviewed-by: Andrew Verge <ave...@chromium.org>
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Reviewed-by: Xiaochen Zhou <xiaoc...@chromium.org>
Reviewed-by: Mike West <mk...@chromium.org>
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Reviewed-by: Alex Moshchuk <ale...@chromium.org>
Reviewed-by: Nicolás Peña <n...@chromium.org>
Commit-Queue: Shivani Sharma <shiva...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1621983}
Files:
- M chrome/browser/chrome_navigation_browsertest.cc
- M chrome/browser/extensions/api/web_request/web_request_apitest.cc
- M chrome/browser/predictors/loading_predictor_browsertest.cc
- M chrome/browser/privacy_sandbox/fenced_frame_viewport_observer_interactive_uitest.cc
- M chrome/browser/renderer_context_menu/render_view_context_menu.cc
- M chrome/browser/renderer_context_menu/render_view_context_menu.h
- M chrome/browser/renderer_context_menu/render_view_context_menu_interactive_uitest.cc
- M chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h
- M chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
- D chrome/test/data/extensions/api_test/webrequest/fencedFrames/page_with_network_revoked_fenced_frame.html
- D chrome/test/data/extensions/api_test/webrequest/fencedFrames/revoke_network.html
- D chrome/test/data/extensions/api_test/webrequest/fencedFrames/revoke_network.html.mock-http-headers
- M content/browser/download/download_browsertest.cc
- M content/browser/fenced_frame/PERMISSIONS_POLICIES.md
- M content/browser/fenced_frame/fenced_document_data.cc
- M content/browser/fenced_frame/fenced_document_data.h
- M content/browser/fenced_frame/fenced_frame.cc
- M content/browser/fenced_frame/fenced_frame_browsertest.cc
- M content/browser/fenced_frame/fenced_frame_config.cc
- M content/browser/fenced_frame/fenced_frame_config.h
- M content/browser/fenced_frame/redacted_fenced_frame_config_mojom_traits_unittest.cc
- M content/browser/loader/prefetch_browsertest.cc
- M content/browser/network_service_restart_browsertest.cc
- M content/browser/renderer_host/frame_tree_node.cc
- M content/browser/renderer_host/navigation_request.cc
- M content/browser/renderer_host/navigation_request.h
- M content/browser/renderer_host/navigation_state_keep_alive.cc
- M content/browser/renderer_host/navigation_state_keep_alive.h
- M content/browser/renderer_host/navigator.cc
- M content/browser/renderer_host/navigator.h
- M content/browser/renderer_host/render_frame_host_impl.cc
- M content/browser/renderer_host/render_frame_host_impl.h
- M content/public/browser/render_frame_host.h
- M content/public/test/fenced_frame_test_util.cc
- M content/public/test/fenced_frame_test_util.h
- M content/test/content_test_bundle_data.filelist
- D content/test/data/fenced_frames/link_rel_module_preload_disable_network.html
- D content/test/data/fenced_frames/link_rel_preload_disable_network.html
- D content/test/data/link_rel_preconnect_disable_network.html
- D content/test/data/link_rel_prefetch_disable_network.html
- M services/network/cors/cors_url_loader.cc
- M services/network/cors/cors_url_loader.h
- M services/network/cors/cors_url_loader_factory.cc
- M services/network/cors/cors_url_loader_factory.h
- M services/network/network_context.cc
- M services/network/network_context.h
- M services/network/network_context_unittest.cc
- M services/network/prefetch_matching_url_loader_factory.cc
- M services/network/prefetch_matching_url_loader_factory.h
- M services/network/public/mojom/network_context.mojom
- M services/network/test/test_network_context.h
- M services/network/url_loader.cc
- M services/network/url_loader.h
- M services/network/web_transport.cc
- M services/network/web_transport.h
- M services/network/websocket.cc
- M services/network/websocket.h
- M services/network/websocket_factory.cc
- M services/network/websocket_factory.h
- M third_party/blink/common/features.cc
- M third_party/blink/common/fenced_frame/fenced_frame_utils.cc
- M third_party/blink/common/fenced_frame/redacted_fenced_frame_config_mojom_traits.cc
- M third_party/blink/public/common/features.h
- M third_party/blink/public/common/fenced_frame/fenced_frame_utils.h
- M third_party/blink/public/common/fenced_frame/redacted_fenced_frame_config.h
- M third_party/blink/public/common/fenced_frame/redacted_fenced_frame_config_mojom_traits.h
- M third_party/blink/public/mojom/fenced_frame/fenced_frame_config.mojom
- M third_party/blink/public/mojom/frame/frame.mojom
- M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
- M third_party/blink/renderer/core/html/fenced_frame/fence.cc
- M third_party/blink/renderer/core/html/fenced_frame/fence.h
- M third_party/blink/renderer/core/html/fenced_frame/fence.idl
- M third_party/blink/renderer/core/testing/fake_local_frame_host.cc
- M third_party/blink/renderer/core/testing/fake_local_frame_host.h
- M third_party/blink/renderer/core/testing/internals.cc
- M third_party/blink/renderer/core/testing/internals.h
- M third_party/blink/renderer/core/testing/internals.idl
- M third_party/blink/web_tests/VirtualTestSuites
- M third_party/blink/web_tests/external/wpt/interfaces/fenced-frame.idl
- D third_party/blink/web_tests/wpt_internal/attribution-reporting/fenced-frame-network-revocation.sub.https.html
- D third_party/blink/web_tests/wpt_internal/attribution-reporting/resources/fenced-frame-network-revocation-inner.https.html
- D third_party/blink/web_tests/wpt_internal/attribution-reporting/resources/fenced-frame-network-revocation-inner.https.html.headers
- D third_party/blink/web_tests/wpt_internal/fenced_frame/disable-untrusted-network-ongoing-navigation.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/disable-untrusted-network-remove-frame.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/disable-untrusted-network.https.html
- M third_party/blink/web_tests/wpt_internal/fenced_frame/resources/remote-context-executor.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/resources/revoke-dedicated-worker.js
- D third_party/blink/web_tests/wpt_internal/fenced_frame/resources/revoke-service-worker.js
- D third_party/blink/web_tests/wpt_internal/fenced_frame/resources/revoke-shared-worker.js
- M third_party/blink/web_tests/wpt_internal/fenced_frame/resources/utils.js
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-automatic-beacons.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-credentialless-iframe-fetch.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-credentialless-iframe-navigation.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-dedicated-workers.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-fetch.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-iframe-navigation.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-manual-report-event-beacons.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-nested-fenced-frame-in-iframe-navigation.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-nested-fenced-frame-navigation.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-popup.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-reporting-api.sub.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-self-navigation.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-service-workers-cached-load.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-service-workers.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-shared-workers.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-unfenced-top-navigation.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-websockets.sub.https.html
- D third_party/blink/web_tests/wpt_internal/fenced_frame/revoke-webtransport.sub.https.html
- D third_party/blink/web_tests/wpt_internal/private-aggregation/fenced-frame-network-revocation.sub.www.https.html
- M tools/metrics/histograms/metadata/blink/enums.xml
- M tools/metrics/histograms/metadata/blink/histograms.xml
Change size: XL
Delta: 111 files changed, 59 insertions(+), 7076 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sophie Chang, +1 by Nicolás Peña, +1 by Xiaochen Zhou, +1 by Kenichi Ishibashi, +1 by Andrew Verge, +1 by Mason Freed, +1 by Alex Moshchuk, +1 by Mike West
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 28, 2026, 5:45:59 PM (22 hours ago) Apr 28
to Shivani Sharma, Chromium LUCI CQ, Nicolás Peña, Mason Freed, Alex Moshchuk, Sophie Chang, Kenichi Ishibashi, Andrew Verge, Mike West, Xiaochen Zhou, android-bu...@system.gserviceaccount.com, Daniel Ramoz, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, fenced-fra...@chromium.org, network-ser...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, storage...@chromium.org, tburkar...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59521
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages