Hiroshige Hayashizaki (Gerrit)

unread,

May 13, 2026, 11:21:38 PM (6 days ago) May 13

to Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Kenichi Ishibashi

Hiroshige Hayashizaki added 1 comment

Patchset-level comments

File-level comment, Patchset 9:

Hiroshige Hayashizaki . unresolved

WDYT?

A specific alternative might be to define `FollowRedirectParams` that includes `new_url` + `HttpRequestHeadersUpdateParams`, while I don't have any specific reason to (or not to) do so.

(bot failures are due to recent addition of `FollowRedirect` overrides; I'll rebase/rerun later).

Open in Gerrit

Related details

Attention is currently required from:

Kenichi Ishibashi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kenichi Ishibashi (Gerrit)

unread,

May 14, 2026, 12:19:12 AM (6 days ago) May 14

to Hiroshige Hayashizaki, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Hiroshige Hayashizaki

Kenichi Ishibashi added 3 comments

File android_webview/browser/network_service/aw_proxying_url_loader_factory.cc

Line 169, Patchset 11 (Latest): network::HttpRequestHeadersUpdateParams headers_update_params,

Kenichi Ishibashi . unresolved

Now we pass by value instead of reference. Does that mean we add extra copies?

File services/network/public/cpp/http_request_headers_mojom_traits.cc

Line 52, Patchset 11 (Latest):bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,

Kenichi Ishibashi . unresolved

Maybe nice to add unitteest.

File services/network/public/mojom/http_request_headers.mojom

Line 24, Patchset 11 (Latest):struct HttpRequestHeadersUpdateParams {

Kenichi Ishibashi . unresolved

```
// Typemapped to `network::HttpRequestHeadersUpdateParams`.
```

Also, consider using `IFFT` so that we don't forget update them each other?

Open in Gerrit

Related details

Attention is currently required from:

Hiroshige Hayashizaki

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hiroshige Hayashizaki (Gerrit)

unread,

May 14, 2026, 5:59:11 PM (5 days ago) May 14

to Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Kenichi Ishibashi

Hiroshige Hayashizaki added 1 comment

File android_webview/browser/network_service/aw_proxying_url_loader_factory.cc

Line 169, Patchset 11: network::HttpRequestHeadersUpdateParams headers_update_params,

Kenichi Ishibashi . unresolved

Now we pass by value instead of reference. Does that mean we add extra copies?

Hiroshige Hayashizaki

No, `HttpRequestHeadersUpdateParams` is passed by move, not copy.

Open in Gerrit

Related details

Attention is currently required from:

Kenichi Ishibashi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kenichi Ishibashi (Gerrit)

unread,

May 14, 2026, 10:20:14 PM (5 days ago) May 14

to Hiroshige Hayashizaki, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Hiroshige Hayashizaki

Kenichi Ishibashi added 1 comment

File android_webview/browser/network_service/aw_proxying_url_loader_factory.cc

Line 169, Patchset 11: network::HttpRequestHeadersUpdateParams headers_update_params,

Kenichi Ishibashi . resolved

Now we pass by value instead of reference. Does that mean we add extra copies?

Hiroshige Hayashizaki

No, `HttpRequestHeadersUpdateParams` is passed by move, not copy.

Kenichi Ishibashi

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Hiroshige Hayashizaki

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hiroshige Hayashizaki (Gerrit)

unread,

May 17, 2026, 9:37:53 PM (2 days ago) May 17

to Zijie He, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Kenichi Ishibashi

Hiroshige Hayashizaki added 2 comments

File services/network/public/cpp/http_request_headers_mojom_traits.cc

Line 52, Patchset 11:bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,

Kenichi Ishibashi . resolved

Maybe nice to add unitteest.

Hiroshige Hayashizaki

Created: https://crrev.com/c/7855487

File services/network/public/mojom/http_request_headers.mojom

Line 24, Patchset 11:struct HttpRequestHeadersUpdateParams {

Kenichi Ishibashi . resolved

```
// Typemapped to `network::HttpRequestHeadersUpdateParams`.
```
Also, consider using `IFFT` so that we don't forget update them each other?

Hiroshige Hayashizaki

```
// Typemapped to `network::HttpRequestHeadersUpdateParams`.
```

Done.

Also, consider using `IFFT` so that we don't forget update them each other?

Created: https://crrev.com/c/7853915.

Open in Gerrit

Related details

Attention is currently required from:

Kenichi Ishibashi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kenichi Ishibashi (Gerrit)

unread,

May 18, 2026, 2:51:44 AM (2 days ago) May 18

to Hiroshige Hayashizaki, Zijie He, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Hiroshige Hayashizaki

Kenichi Ishibashi added 1 comment

File services/network/public/cpp/http_request_headers_mojom_traits.cc

Line 52, Patchset 11:bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,

Kenichi Ishibashi . resolved

Maybe nice to add unitteest.

Hiroshige Hayashizaki

Created: https://crrev.com/c/7855487

Kenichi Ishibashi

It would be nice to submit the test together with the implementation, ideally factoring out in two CLs: 1. impl + test, 2. other stuff in this CL.

I don't meant to block this CL though.

Open in Gerrit

Related details

Attention is currently required from:

Hiroshige Hayashizaki

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hiroshige Hayashizaki (Gerrit)

unread,

May 19, 2026, 6:28:31 PM (9 hours ago) May 19

to Zijie He, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, mac-r...@chromium.org, fuchsia...@chromium.org, android-web...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, japhet+...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, lingqi...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, network-ser...@chromium.org, philli...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, twifka...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Kenichi Ishibashi

Hiroshige Hayashizaki added 1 comment

File services/network/public/cpp/http_request_headers_mojom_traits.cc

Line 52, Patchset 11:bool StructTraits<network::mojom::HttpRequestHeadersUpdateParamsDataView,

Kenichi Ishibashi . unresolved

Maybe nice to add unitteest.

Hiroshige Hayashizaki

Created: https://crrev.com/c/7855487

Kenichi Ishibashi

It would be nice to submit the test together with the implementation, ideally factoring out in two CLs: 1. impl + test, 2. other stuff in this CL.
I don't meant to block this CL though.

Hiroshige Hayashizaki

Merged https://crrev.com/c/7855487.

What do you mean by "other stuff in this CL"?

Everything related to the `network::mojom::URLLoader::FollowRedirect` change should be committed at once and can't be split.

The other parts of

- Defines `network.mojom.HttpRequestHeadersUpdateParams` mojo struct.
  - `services/network/public/mojom/http_request_headers.mojom`
- Maps it to `network::HttpRequestHeadersUpdateParams`.
  - `services/network/public/mojom/BUILD.gn`
  - `services/network/public/cpp/http_request_headers_mojom_traits.*`

can be split into a preparation CL, but is this what you mean?

Open in Gerrit

Related details

Attention is currently required from:

Kenichi Ishibashi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Use HttpRequestHeadersUpdateParams in mojom::URLLoader::FollowRedirect [chromium/src : main]

Hiroshige Hayashizaki (Gerrit)

Hiroshige Hayashizaki added 1 comment

Related details

Kenichi Ishibashi (Gerrit)

Kenichi Ishibashi added 3 comments

Related details

Hiroshige Hayashizaki (Gerrit)

Hiroshige Hayashizaki added 1 comment

Related details

Kenichi Ishibashi (Gerrit)

Kenichi Ishibashi added 1 comment

Related details

Hiroshige Hayashizaki (Gerrit)

Hiroshige Hayashizaki added 2 comments

Related details

Kenichi Ishibashi (Gerrit)

Kenichi Ishibashi added 1 comment

Related details

Hiroshige Hayashizaki (Gerrit)

Hiroshige Hayashizaki added 1 comment

Related details