[cc] Add more BeginMainFrameReason [chromium/src : main]

[Stefan Zager (Gerrit)]

Attention needed from Jonathan Ross and Thiabaud Engelbrecht

Stefan Zager voted and added 1 comment

Votes added by Stefan Zager

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Stefan Zager . resolved

lgtm, thanks for the cleanup.

Open in Gerrit

Related details

Attention is currently required from:

• Jonathan Ross
• Thiabaud Engelbrecht

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I7cde18c0400095a8697fe7ef3a5439931cbfec7f

Gerrit-Change-Number: 7847835

Gerrit-PatchSet: 7

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Xida Chen <xida...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jonathan Ross <jon...@chromium.org>

Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Comment-Date: Mon, 18 May 2026 18:19:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Thiabaud Engelbrecht (Gerrit)]

Attention needed from Jonathan Ross

Thiabaud Engelbrecht voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Jonathan Ross

Gerrit-Comment-Date: Tue, 19 May 2026 14:02:57 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

[cc] Add more BeginMainFrameReason

This CL updates the BeginMainFrameReasons to include a generic "LayoutTreeUpdate" reason.

Bug: 467969029

Change-Id: I7cde18c0400095a8697fe7ef3a5439931cbfec7f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7847835

Reviewed-by: Stefan Zager <sza...@chromium.org>

Commit-Queue: Thiabaud Engelbrecht <thia...@google.com>

Cr-Commit-Position: refs/heads/main@{#1632937}

Files:

• M cc/metrics/begin_main_frame_metrics.h
• M cc/trees/proxy_main.cc
• M third_party/blink/renderer/core/dom/document.cc
• M third_party/blink/renderer/core/exported/web_page_popup_impl.cc
• M third_party/blink/renderer/core/frame/local_frame_view_test.cc
• M third_party/blink/renderer/core/loader/empty_clients.h
• M third_party/blink/renderer/core/page/chrome_client.h
• M third_party/blink/renderer/core/page/chrome_client_impl.cc
• M third_party/blink/renderer/core/page/chrome_client_impl.h
• M third_party/blink/renderer/core/page/page_animator.cc
• M third_party/blink/renderer/core/page/page_animator.h
• M third_party/blink/renderer/core/page/validation_message_overlay_delegate.cc
• M third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.cc
• M third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.h
• M third_party/blink/renderer/core/svg/svg_resource_document_content.cc
• M third_party/blink/renderer/core/testing/core_unit_test_helper.h
• M third_party/blink/renderer/modules/csspaint/nativepaint/clip_path_paint_definition_test.cc
• M tools/metrics/histograms/metadata/compositing/histograms.xml

Change size: M

Delta: 18 files changed, 38 insertions(+), 36 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Stefan Zager

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I7cde18c0400095a8697fe7ef3a5439931cbfec7f

Gerrit-Change-Number: 7847835

Gerrit-PatchSet: 8

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>