Speedometer 3 winning architectural optimizations [chromium/src : main]

0 views

Skip to first unread message

AI Code Reviewer (Gerrit)

unread,

9:30 AM (2 hours ago) 9:30 AM

to Anton Bikineev, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, Chromium LUCI CQ, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, pdr+svgw...@chromium.org

Attention needed from Anton Bikineev

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/css/check_pseudo_has_fast_reject_filter.h

Line 62, Patchset 1 (Latest): bool filter_allocated_ = false;

AI Code Reviewer . unresolved

nit: Precede boolean values with words like “is” and “did”. Consider renaming 'filter_allocated_' to 'is_filter_allocated_'. (Blink Style Guide: Naming - Precede boolean values with words like “is” and “did”)

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:

Anton Bikineev

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages