Remove superfluous base/gtest_prod_util.h includes from headers [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Dec 9, 2025, 11:54:01 AM (7 days ago) Dec 9
to Lei Zhang, Mark Mentovai, Menard, Alexis, Avi Drissman, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Olga Gerchikov, Heron Yang, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Mangesh Ghiware, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, Rijubrata Bhaumik, James Su, Ian Vollick, Wanming Lin, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, bici...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+wa...@google.com, cros-ed...@google.com, dcheng+c...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, longbowei+watc...@google.com, lucasrada...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, nona+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, performance-m...@chromium.org, print-revi...@chromium.org, pushi+watc...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-...@chromium.org, scheduler-b...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, toshikikikuch...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zol...@webkit.org
Attention needed from Mark Mentovai

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie998958f1622dd7bc6a7bfafd7dd6f737abbc909
Gerrit-Change-Number: 7240634
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Daniel Andersson <dande...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 16:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Dec 11, 2025, 3:00:38 PM (5 days ago) Dec 11
to Lei Zhang, Code Review Nudger, Menard, Alexis, Avi Drissman, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Olga Gerchikov, Heron Yang, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Mangesh Ghiware, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, Rijubrata Bhaumik, James Su, Ian Vollick, Wanming Lin, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, bici...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+wa...@google.com, cros-ed...@google.com, dcheng+c...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, longbowei+watc...@google.com, lucasrada...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, nona+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, performance-m...@chromium.org, print-revi...@chromium.org, pushi+watc...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-...@chromium.org, scheduler-b...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, toshikikikuch...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zol...@webkit.org
Attention needed from Lei Zhang

Mark Mentovai voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie998958f1622dd7bc6a7bfafd7dd6f737abbc909
Gerrit-Change-Number: 7240634
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Daniel Andersson <dande...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 20:00:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 12, 2025, 8:52:45 PM (4 days ago) Dec 12
to Lei Zhang, Mark Mentovai, Code Review Nudger, Menard, Alexis, Avi Drissman, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Olga Gerchikov, Heron Yang, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Mangesh Ghiware, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, Rijubrata Bhaumik, James Su, Ian Vollick, Wanming Lin, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, bici...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+wa...@google.com, cros-ed...@google.com, dcheng+c...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, longbowei+watc...@google.com, lucasrada...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, nona+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, performance-m...@chromium.org, print-revi...@chromium.org, pushi+watc...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-...@chromium.org, scheduler-b...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, toshikikikuch...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zol...@webkit.org

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie998958f1622dd7bc6a7bfafd7dd6f737abbc909
Gerrit-Change-Number: 7240634
Gerrit-PatchSet: 3
Gerrit-Comment-Date: Sat, 13 Dec 2025 01:52:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 12, 2025, 9:10:30 PM (4 days ago) Dec 12
to Lei Zhang, Mark Mentovai, Code Review Nudger, Akihiro Ota, Menard, Alexis, Avi Drissman, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Olga Gerchikov, Heron Yang, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Mangesh Ghiware, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, Rijubrata Bhaumik, James Su, Ian Vollick, Wanming Lin, AyeAye Python Dispatcher, abigailbk...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, bici...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+wa...@google.com, cros-ed...@google.com, dcheng+c...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, longbowei+watc...@google.com, lucasrada...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, nona+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, performance-m...@chromium.org, print-revi...@chromium.org, pushi+watc...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-...@chromium.org, scheduler-b...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, toshikikikuch...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Remove superfluous base/gtest_prod_util.h includes from headers

Remove unnecessary includes. Removal mostly automated with:

git ls-files | grep '\.h$' | xargs grep -l base/gtest_prod_util.h | \
xargs grep -L FRIEND_TEST | xargs grep -L FORWARD_DECLARE_TEST | \
xargs ./tools/add_header.py --remove --header '"base/gtest_prod_util.h"'
Bug: 40318405
Change-Id: Ie998958f1622dd7bc6a7bfafd7dd6f737abbc909
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Owners-Override: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558386}
Files:
  • M ash/accelerators/accelerator_controller_impl.h
  • M ash/system/network/cellular_setup_notifier.h
  • M ash/system/network/managed_sim_lock_notifier.h
  • M ash/system/notification_center/ash_message_center_lock_screen_controller.h
  • M ash/wm/desks/desk_mini_view.h
  • M ash/wm/float/float_controller.h
  • M base/files/block_tests_writing_to_special_dirs.h
  • M base/time/time.h
  • M base/trace_event/trace_log.h
  • M cc/animation/worklet_animation.h
  • M chrome/browser/android/favicon_helper.h
  • M chrome/browser/apps/app_preload_service/app_preload_service.h
  • M chrome/browser/ash/android_sms/connection_manager.h
  • M chrome/browser/ash/apps/apk_web_app_service.h
  • M chrome/browser/ash/device_name/device_name_store.h
  • M chrome/browser/ash/extensions/file_manager/system_notification_manager.h
  • M chrome/browser/ash/login/error_screens_histogram_helper.h
  • M chrome/browser/ash/login/quick_unlock/pin_storage_prefs.h
  • M chrome/browser/ash/login/test/cryptohome_mixin.h
  • M chrome/browser/ash/net/secure_dns_manager.h
  • M chrome/browser/ash/power/smart_charging/smart_charging_manager.h
  • M chrome/browser/bookmarks/android/bookmark_bridge.h
  • M chrome/browser/component_updater/file_type_policies_component_installer.h
  • M chrome/browser/extensions/api/identity/identity_api.h
  • M chrome/browser/extensions/extension_safety_check_utils.h
  • M chrome/browser/glic/host/glic_region_capture_controller.h
  • M chrome/browser/media/router/chrome_media_router_factory.h
  • M chrome/browser/media/router/discovery/access_code/access_code_cast_discovery_interface.h
  • M chrome/browser/media/router/discovery/access_code/access_code_cast_sink_service.h
  • M chrome/browser/media/router/discovery/access_code/access_code_cast_sink_service_factory.h
  • M chrome/browser/media/router/discovery/dial/dial_app_discovery_service.h
  • M chrome/browser/media/router/mojo/media_router_mojo_metrics.h
  • M chrome/browser/on_device_translation/translation_manager_impl.h
  • M chrome/browser/profiles/gaia_info_update_service.h
  • M chrome/browser/push_messaging/push_messaging_app_identifier.h
  • M chrome/browser/resource_coordinator/lifecycle_unit_base.h
  • M chrome/browser/resource_coordinator/session_restore_policy.h
  • M chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h
  • M chrome/browser/safe_browsing/cloud_content_scanning/multipart_uploader.h
  • M chrome/browser/sessions/session_service_base.h
  • M chrome/browser/sessions/tab_loader.h
  • M chrome/browser/signin/bound_session_credentials/bound_session_cookie_observer.h
  • M chrome/browser/signin/web_signin_interceptor.h
  • M chrome/browser/themes/theme_syncable_service.h
  • M chrome/browser/tracing/chrome_tracing_delegate.h
  • M chrome/browser/ui/browser_command_controller.h
  • M chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.h
  • M chrome/browser/ui/performance_controls/performance_intervention_button_controller.h
  • M chrome/browser/ui/search/search_tab_helper.h
  • M chrome/browser/ui/tab_contents/core_tab_helper.h
  • M chrome/browser/ui/toolbar/cast/cast_toolbar_button_controller.h
  • M chrome/browser/ui/views/location_bar/zoom_bubble_view.h
  • M chrome/browser/ui/views/sync/one_click_signin_dialog_view.h
  • M chrome/browser/ui/views/tabs/tab_strip.h
  • M chrome/browser/ui/views/tabs/tab_strip_action_container.h
  • M chrome/browser/ui/views/toolbar/toolbar_controller.h
  • M chrome/browser/ui/views/user_education/impl/browser_feature_promo_controller_20.h
  • M chrome/browser/ui/webui/access_code_cast/access_code_cast_handler.h
  • M chrome/browser/ui/webui/history/history_ui.h
  • M chrome/browser/ui/webui/management/management_ui_handler.h
  • M chrome/browser/ui/webui/print_preview/print_preview_handler_chromeos.h
  • M chrome/browser/ui/webui/settings/site_settings_handler.h
  • M chrome/browser/ui/webui/signin/dice_web_signin_intercept_handler.h
  • M chrome/browser/ui/webui/signin/inline_login_handler_impl.h
  • M chrome/updater/cleanup_task.h
  • M chrome/updater/usage_stats_permissions.h
  • M chromeos/ash/components/dbus/featured/featured_client.h
  • M chromeos/ash/components/geolocation/location_fetcher.h
  • M chromeos/ash/components/local_search_service/inverted_index.h
  • M chromeos/ash/components/network/cellular_connection_handler.h
  • M chromeos/ash/components/network/cellular_esim_uninstall_handler.h
  • M chromeos/ash/components/network/cellular_policy_handler.h
  • M chromeos/ash/components/network/network_state.h
  • M chromeos/ash/components/phonehub/recent_apps_interaction_handler.h
  • M chromeos/ash/components/phonehub/recent_apps_interaction_handler_impl.h
  • M chromeos/ash/components/tether/top_level_host_scan_cache.h
  • M chromeos/ash/services/cellular_setup/euicc.h
  • M components/affiliations/core/browser/affiliation_backend.h
  • M components/autofill/core/browser/form_import/form_data_importer.h
  • M components/autofill/core/browser/form_parsing/address_field_parser.h
  • M components/autofill/core/browser/form_parsing/form_field_parser.h
  • M components/autofill/core/browser/form_parsing/name_field_parser.h
  • M components/autofill/core/browser/form_parsing/phone_field_parser.h
  • M components/autofill/core/browser/form_structure.h
  • M components/autofill/core/browser/foundations/browser_autofill_manager.h
  • M components/autofill/core/browser/payments/credit_card_access_manager.h
  • M components/autofill/core/browser/payments/iban_manager.h
  • M components/autofill/core/browser/payments/legal_message_line.h
  • M components/autofill/core/browser/single_field_fillers/autocomplete/autocomplete_history_manager.h
  • M components/autofill/core/browser/ui/autofill_external_delegate.h
  • M components/component_updater/installer_policies/first_party_sets_component_installer_policy.h
  • M components/component_updater/installer_policies/optimization_hints_component_installer.h
  • M components/history/core/browser/history_database.h
  • M components/history_embeddings/history_embeddings_service.h
  • M components/input/input_router_impl.h
  • M components/legion/phosphor/token_fetcher_impl.h
  • M components/media_router/browser/media_router_metrics.h
  • M components/metrics/drive_metrics_provider.h
  • M components/metrics/file_metrics_provider.h
  • M components/net_log/net_export_file_writer.h
  • M components/network_time/network_time_tracker.h
  • M components/omnibox/browser/document_provider.h
  • M components/omnibox/browser/history_quick_provider.h
  • M components/omnibox/browser/history_url_provider.h
  • M components/omnibox/browser/scored_history_match.h
  • M components/omnibox/browser/shortcuts_backend.h
  • M components/omnibox/browser/shortcuts_provider.h
  • M components/omnibox/browser/suggestion_answer.h
  • M components/page_image_annotation/content/renderer/content_page_annotator_driver.h
  • M components/password_manager/core/browser/password_store/password_store.h
  • M components/performance_manager/persistence/site_data/site_data_cache_impl.h
  • M components/permissions/permission_decision_auto_blocker.h
  • M components/prefs/json_pref_store.h
  • M components/privacy_sandbox/privacy_sandbox_settings_impl.h
  • M components/privacy_sandbox/tracking_protection_onboarding.h
  • M components/push_messaging/app_identifier.h
  • M components/regional_capabilities/regional_capabilities_service.h
  • M components/safe_browsing/content/browser/triggers/ad_sampler_trigger.h
  • M components/safe_browsing/content/browser/triggers/trigger_throttler.h
  • M components/search_engines/keyword_table.h
  • M components/services/storage/dom_storage/session_storage_impl.h
  • M components/services/storage/indexed_db/transactional_leveldb/transactional_leveldb_transaction.h
  • M components/sharing_message/sharing_device_registration.h
  • M components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos.h
  • M components/supervised_user/core/browser/remote_web_approvals_manager.h
  • M components/supervised_user/core/browser/supervised_user_service.h
  • M components/sync/engine/net/sync_server_connection_manager.h
  • M components/sync/engine/sync_manager_impl.h
  • M components/sync/engine/syncer.h
  • M components/tracing/common/background_tracing_state_manager.h
  • M components/translate/core/browser/translate_manager.h
  • M components/url_pattern/simple_url_pattern_matcher.h
  • M components/user_education/common/tutorial/tutorial.h
  • M components/variations/variations_ids_provider.h
  • M components/viz/service/transitions/surface_animation_manager.h
  • M components/webapps/browser/installable/installable_task_queue.h
  • M components/webapps/services/web_app_origin_association/web_app_origin_association_fetcher.h
  • M content/browser/cpu_performance/cpu_performance.h
  • M content/browser/devtools/shared_storage_worklet_devtools_manager.h
  • M content/browser/devtools/shared_worker_devtools_manager.h
  • M content/browser/digital_credentials/cross_device_transaction_impl.h
  • M content/browser/media/midi_host.h
  • M content/browser/renderer_host/direct_manipulation_helper_win.h
  • M content/browser/renderer_host/mixed_content_navigation_throttle.h
  • M content/browser/scheduler/responsiveness/metric_source.h
  • M content/browser/service_worker/service_worker_host.h
  • M content/browser/service_worker/service_worker_main_resource_loader_interceptor.h
  • M content/browser/service_worker/service_worker_process_manager.h
  • M content/browser/speech/tts_controller_impl.h
  • M content/browser/web_package/signed_exchange_prologue.h
  • M content/browser/webui/web_ui_data_source_impl.h
  • M content/public/browser/web_ui_message_handler.h
  • M device/bluetooth/cast/bluetooth_device_cast.h
  • M device/bluetooth/floss/floss_lescan_client.h
  • M extensions/browser/api/web_request/web_request_api.h
  • M extensions/common/manifest_handler.h
  • M google_apis/calendar/calendar_api_response_types.h
  • M google_apis/gaia/oauth2_mint_token_flow.h
  • M ios/chrome/browser/device_sharing/model/device_sharing_manager_impl.h
  • M ios/web/public/init/network_context_owner.h
  • M media/audio/audio_thread_hang_monitor.h
  • M net/base/network_change_notifier_passive.h
  • M net/disk_cache/memory/mem_entry_impl.h
  • M net/nqe/network_quality.h
  • M net/proxy_resolution/proxy_info.h
  • M net/quic/quic_session_pool.h
  • M net/socket/ssl_client_socket.h
  • M net/socket/udp_socket_win.h
  • M net/spdy/spdy_session.h
  • M remoting/base/rate_counter.h
  • M remoting/host/heartbeat_sender.h
  • M remoting/protocol/negotiating_authenticator_base.h
  • M services/audio/input_sync_writer.h
  • M services/cert_verifier/cert_verifier_service_factory.h
  • M services/device/generic_sensor/sensor_provider_impl.h
  • M services/resource_coordinator/memory_instrumentation/graph.h
  • M services/video_capture/broadcasting_receiver.h
  • M storage/browser/blob/blob_storage_context.h
  • M third_party/blink/renderer/core/css/parser/css_parser_impl.h
  • M third_party/blink/renderer/core/dom/element.h
  • M third_party/blink/renderer/core/frame/history.h
  • M third_party/blink/renderer/core/html/forms/html_select_element.h
  • M third_party/blink/renderer/core/layout/layout_box.h
  • M third_party/blink/renderer/modules/peerconnection/rtc_encoded_underlying_sink_wrapper.h
  • M third_party/blink/renderer/modules/peerconnection/rtc_encoded_underlying_source_wrapper.h
  • M third_party/blink/renderer/modules/webaudio/script_processor_node.h
  • M third_party/blink/renderer/modules/webaudio/stereo_panner_node.h
  • M third_party/blink/renderer/platform/blob/blob_data.h
  • M third_party/blink/renderer/platform/loader/fetch/resource_loader.h
  • M third_party/blink/renderer/platform/scheduler/public/aggregated_metric_reporter.h
  • M third_party/blink/renderer/platform/weborigin/security_origin.h
  • M ui/accessibility/platform/ax_platform_node_win.h
  • M ui/base/clipboard/clipboard_mac.h
  • M ui/base/ime/win/on_screen_keyboard_display_manager_tab_tip.h
  • M ui/base/interaction/interactive_test_internal.h
  • M ui/compositor/presentation_time_recorder.h
  • M ui/display/manager/display_manager.h
  • M ui/display/manager/display_port_observer.h
  • M ui/events/ozone/evdev/input_controller_evdev.h
  • M ui/gfx/color_space.h
  • M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h
  • M ui/ozone/platform/wayland/host/wayland_clipboard.h
  • M ui/ozone/platform/wayland/host/wayland_window_drag_controller.h
  • M ui/views/controls/button/label_button.h
  • M ui/views/controls/scroll_view.h
  • M ui/views/window/dialog_client_view.h
  • M url/origin.h
Change size: M
Delta: 207 files changed, 2 insertions(+), 208 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie998958f1622dd7bc6a7bfafd7dd6f737abbc909
Gerrit-Change-Number: 7240634
Gerrit-PatchSet: 4
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages