Enable InitiatorUrl for ResourceTiming on static resources from CSS files [chromium/src : main]

0 views

Skip to first unread message

Guohui Deng (Gerrit)

unread,

Jul 8, 2026, 3:50:11 PM (13 hours ago) Jul 8

to Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org

Attention needed from Scott Haseley

Guohui Deng added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Guohui Deng . resolved

Thanks for reviewing!

Open in Gerrit

Related details

Attention is currently required from:

Scott Haseley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Scott Haseley (Gerrit)

unread,

Jul 8, 2026, 4:21:04 PM (12 hours ago) Jul 8

to Guohui Deng, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org

Attention needed from Guohui Deng

Scott Haseley voted and added 4 comments

Votes added by Scott Haseley

Code-Review

4 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Scott Haseley . resolved

LGTM w/ comments

File third_party/blink/web_tests/external/wpt/resource-timing/tentative/initiator-url/stylesheet-static.html

Line 8, Patchset 1 (Latest): <link rel="stylesheet" href="/resource-timing/resources/nested-initiator.css">

Scott Haseley . unresolved

Some other things that would be interesting to test (not sure if these exist already):
 1. A dynamically inserted CSS stylesheet (no subresources). I'd assume this should use the current context (null for initial loads, otherwise uses TaskAttribution)?
 2. Subresources of a dynamically inserted CSS stylesheet. I'd assume this should always use the refererrer?

Line 20, Patchset 1 (Latest):<script>

Scott Haseley . unresolved

nit: Can you put this <script> tag inside the <body> (or just get rid of the <body> tags altogether since they aren't needed (similarly the <head> tags aren't needed anymore))? I think this might work, but I'm not sure this is technically valid HTML.

Line 21, Patchset 1 (Latest):

Scott Haseley . unresolved

Ultra nit: remove the blank lines here and at the end (21 and 35) (not needed / better for readability since it's indented).

Open in Gerrit

Related details

Attention is currently required from:

Guohui Deng

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages