WTF: Rename AtomicString::Contains(char) to contains(char) [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Feb 19, 2026, 3:32:06 AM (yesterday) Feb 19
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Nate Chapin, Stephen Chenney, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ica6b76e47f6427cd981a3989997dec8a9708627f
Gerrit-Change-Number: 7591493
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 08:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Feb 19, 2026, 5:55:41 AM (yesterday) Feb 19
to Kent Tamura, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Nate Chapin, Stephen Chenney, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ica6b76e47f6427cd981a3989997dec8a9708627f
    Gerrit-Change-Number: 7591493
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 19 Feb 2026 10:55:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 19, 2026, 5:58:56 AM (yesterday) Feb 19
    to Kent Tamura, Fredrik Söderquist, AyeAye, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Nate Chapin, Stephen Chenney, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WTF: Rename AtomicString::Contains(char) to contains(char)

    The new name is consistent with `std::string::contains(char)`.
    This CL has no behavior changes.
    Bug: 473854537
    Change-Id: Ica6b76e47f6427cd981a3989997dec8a9708627f
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1586999}
    Files:
    • M third_party/blink/renderer/core/dom/document.cc
    • M third_party/blink/renderer/core/html/anchor_element_utils.cc
    • M third_party/blink/renderer/core/html/forms/text_control_element.cc
    • M third_party/blink/renderer/core/html/html_iframe_element.cc
    • M third_party/blink/renderer/core/loader/frame_load_request.cc
    • M third_party/blink/renderer/core/svg/svg_animate_element.cc
    • M third_party/blink/renderer/platform/network/http_header_map.h
    • M third_party/blink/renderer/platform/text/layout_locale.cc
    • M third_party/blink/renderer/platform/wtf/text/atomic_string.h
    Change size: S
    Delta: 9 files changed, 26 insertions(+), 21 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ica6b76e47f6427cd981a3989997dec8a9708627f
    Gerrit-Change-Number: 7591493
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages