Report prefetch activation to the activation beacon endpoint [chromium/src : main]

0 views
Skip to first unread message

Jiacheng Guo (Gerrit)

unread,
May 13, 2026, 5:04:50 AM (7 days ago) May 13
to chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org

Jiacheng Guo added 3 comments

File content/browser/preloading/prefetch/prefetch_container.h
Line 318, Patchset 1: void SetActivationBeaconUrl(const GURL& url) { activation_beacon_url_ = url; }
Jiacheng Guo . resolved

Is this method used?

Jiacheng Guo

Done

File content/browser/preloading/prefetch/prefetch_container.cc
Line 1079, Patchset 1: GURL resolved_url = GetCurrentURL().Resolve(endpoint);
Jiacheng Guo . resolved

The URL should be relative the the origin rather than the current URL.

Jiacheng Guo

Done

Line 1081, Patchset 1: url::Origin::Create(resolved_url)
Jiacheng Guo . resolved

If we use `Resolve` with the current origin, the returned URL is guaranteed to be same-origin.

Jiacheng Guo

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib3f38821a1ff5a3e94af0f55f959f20761bd4e84
Gerrit-Change-Number: 7838804
Gerrit-PatchSet: 3
Gerrit-Owner: Jiacheng Guo <g...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Comment-Date: Wed, 13 May 2026 09:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jiacheng Guo <g...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Jiacheng Guo (Gerrit)

unread,
May 13, 2026, 5:04:52 AM (7 days ago) May 13
to chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org

Jiacheng Guo added 1 comment

File content/browser/preloading/prefetch/nav_prefetch_browsertest.cc
Line 780, Patchset 1:IN_PROC_BROWSER_TEST_F(NavPrefetchBrowserTest, ActivationBeaconSent) {
Jiacheng Guo . resolved

Please add a test verifying that if the endpoint is set to a different origin such as `b.com/beacon`, the activation beacon should be sent.

Jiacheng Guo

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib3f38821a1ff5a3e94af0f55f959f20761bd4e84
    Gerrit-Change-Number: 7838804
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 May 2026 09:04:28 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rakina Zata Amni (Gerrit)

    unread,
    May 19, 2026, 7:23:58 PM (8 hours ago) May 19
    to Jiacheng Guo, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
    Attention needed from Hiroki Nakagawa and Jiacheng Guo

    Rakina Zata Amni voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hiroki Nakagawa
    • Jiacheng Guo
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib3f38821a1ff5a3e94af0f55f959f20761bd4e84
    Gerrit-Change-Number: 7838804
    Gerrit-PatchSet: 8
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 May 2026 23:23:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hiroki Nakagawa (Gerrit)

    unread,
    May 19, 2026, 11:35:54 PM (4 hours ago) May 19
    to Jiacheng Guo, Rakina Zata Amni, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
    Attention needed from Jiacheng Guo

    Hiroki Nakagawa added 3 comments

    File content/browser/preloading/prefetch/prefetch_container.cc
    Line 1066, Patchset 8 (Latest): head->parsed_headers->prefetch_activation_beacon_endpoint.has_value()) {
    Hiroki Nakagawa . unresolved

    Can we guard these changes with a feature flag?

    Line 1070, Patchset 8 (Latest): url::Origin::Create(GetCurrentURL()))) {
    Hiroki Nakagawa . unresolved

    (For a follow-up) It would be nice to report to DevTools console when the endpoint specified by the header is not in the same origin for debuggability.

    File content/browser/renderer_host/navigation_request.h
    Line 1843, Patchset 8 (Latest): const GURL& activation_beacon_url() const { return activation_beacon_url_; }
    Hiroki Nakagawa . unresolved

    This getter is not used in this CL. Can we remove this?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jiacheng Guo
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib3f38821a1ff5a3e94af0f55f959f20761bd4e84
      Gerrit-Change-Number: 7838804
      Gerrit-PatchSet: 8
      Gerrit-Owner: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Comment-Date: Wed, 20 May 2026 03:35:25 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages