[wip] memory-leaking 32-bit string [chromium/src : main]

0 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Dec 15, 2025, 2:16:49 PM (yesterday) Dec 15
to Raphael Kubo da Costa, chromium...@chromium.org, Menard, Alexis, Kentaro Hara, blink-re...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

[wip] memory-leaking 32-bit string
Change-Id: I72aa68e2ab304e7426533af2be9c789c79aecd34

Change diff


Change information

Files:
  • M third_party/blink/renderer/core/css/css_property_value.cc
  • M third_party/blink/renderer/core/dom/attribute.h
  • M third_party/blink/renderer/core/dom/element_data.cc
  • M third_party/blink/renderer/core/dom/node.cc
  • M third_party/blink/renderer/core/dom/qualified_name.cc
  • M third_party/blink/renderer/core/dom/qualified_name.h
  • M third_party/blink/renderer/core/html/parser/html_stack_item.h
  • M third_party/blink/renderer/core/style/style_cached_data.h
  • M third_party/blink/renderer/core/style/style_variables.h
  • M third_party/blink/renderer/platform/bindings/parkable_string.h
  • M third_party/blink/renderer/platform/wtf/text/atomic_string_table.cc
  • M third_party/blink/renderer/platform/wtf/text/string_hash.h
  • M third_party/blink/renderer/platform/wtf/text/string_impl.cc
  • M third_party/blink/renderer/platform/wtf/text/string_impl.h
  • M third_party/blink/renderer/platform/wtf/text/string_statics.cc
  • A third_party/blink/renderer/platform/wtf/text/string_table.h
  • M third_party/blink/renderer/platform/wtf/text/wtf_string.cc
  • M third_party/blink/renderer/platform/wtf/text/wtf_string.h
Change size: L
Delta: 18 files changed, 349 insertions(+), 167 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72aa68e2ab304e7426533af2be9c789c79aecd34
Gerrit-Change-Number: 7261501
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 15, 2025, 4:30:58 PM (yesterday) Dec 15
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, mac-r...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/167cd347310000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72aa68e2ab304e7426533af2be9c789c79aecd34
Gerrit-Change-Number: 7261501
Gerrit-PatchSet: 3
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 21:30:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
3:43 AM (19 hours ago) 3:43 AM
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, mac-r...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/139faeb0b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72aa68e2ab304e7426533af2be9c789c79aecd34
Gerrit-Change-Number: 7261501
Gerrit-PatchSet: 4
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 08:43:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
4:00 AM (18 hours ago) 4:00 AM
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, mac-r...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

😿 Job mac-m1_mini_2020-perf/speedometer3 failed.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/103acda8b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72aa68e2ab304e7426533af2be9c789c79aecd34
Gerrit-Change-Number: 7261501
Gerrit-PatchSet: 5
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 09:00:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
5:11 AM (17 hours ago) 5:11 AM
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, mac-r...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11cf8d18b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72aa68e2ab304e7426533af2be9c789c79aecd34
Gerrit-Change-Number: 7261501
Gerrit-PatchSet: 5
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 10:11:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
6:24 AM (16 hours ago) 6:24 AM
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, mac-r...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13c80098b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72aa68e2ab304e7426533af2be9c789c79aecd34
Gerrit-Change-Number: 7261501
Gerrit-PatchSet: 8
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 11:24:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages