Fix prewarm data missing in renderer process user data before commit [chromium/src : main]

0 views
Skip to first unread message

Jiacheng Guo (Gerrit)

unread,
7:43 AM (4 hours ago) 7:43 AM
to prerendering-reviews, chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org, bmcquad...@chromium.org, lingqi...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, gavin...@chromium.org, loading-rev...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org

Jiacheng Guo has uploaded the change for review

Commit message

Fix prewarm data missing in renderer process user data before commit

Attach SearchPreloadProcessData to the RenderProcessHost early when
initiating a DSE prewarm navigation. This resolves the telemetry blind
spot where in-flight prewarm process reuse was omitted prior to commit.
Bug: 473593133
Change-Id: I9fc8ca1358f22db5cef9d91ac61bc5bc52f97bec

Change diff


Change information

Files:
  • M chrome/browser/preloading/prerender/prerender_manager.cc
  • M components/page_load_metrics/google/browser/BUILD.gn
  • M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
  • M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.h
  • D components/page_load_metrics/google/browser/prerender_prewarm_navigation_data.cc
  • D components/page_load_metrics/google/browser/prerender_prewarm_navigation_data.h
  • A components/page_load_metrics/google/browser/search_preload_process_data.cc
  • A components/page_load_metrics/google/browser/search_preload_process_data.h
Change size: L
Delta: 8 files changed, 140 insertions(+), 173 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fc8ca1358f22db5cef9d91ac61bc5bc52f97bec
Gerrit-Change-Number: 8260259
Gerrit-PatchSet: 1
Gerrit-Owner: Jiacheng Guo <g...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages