import text: Add text mojom::RequestDestination (2/3) [chromium/src : main]

0 views
Skip to first unread message

Olivier Flückiger (Gerrit)

unread,
Jun 4, 2026, 9:34:10 AM (7 days ago) Jun 4
to Chromium IPC Reviews, Adam Rice, Nate Chapin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
Attention needed from Adam Rice and Chromium IPC Reviews

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 10:
Olivier Flückiger . resolved

Ptal, also open to suggestions on how to make this easier to get it reviewed by all owners 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Chromium IPC Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I52e851b4555e76e2f20816421e1d6c50f1bbae2f
Gerrit-Change-Number: 7895444
Gerrit-PatchSet: 13
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jun 2026 13:33:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jun 4, 2026, 9:36:42 AM (7 days ago) Jun 4
to Olivier Flückiger, Chromium IPC Reviews, Arthur Sonzogni, Adam Rice, Nate Chapin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
Attention needed from Adam Rice and Arthur Sonzogni

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: arthurs...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): arthurs...@chromium.org


Reviewer source(s):
arthurs...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Arthur Sonzogni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I52e851b4555e76e2f20816421e1d6c50f1bbae2f
Gerrit-Change-Number: 7895444
Gerrit-PatchSet: 13
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jun 2026 13:36:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Jun 4, 2026, 10:11:31 AM (7 days ago) Jun 4
to Olivier Flückiger, Chromium IPC Reviews, Adam Rice, Nate Chapin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
Attention needed from Adam Rice and Olivier Flückiger

Arthur Sonzogni added 2 comments

File third_party/blink/public/mojom/fetch/fetch_api_request.mojom
Line 30, Patchset 13 (Latest): ATTRIBUTION_SRC,
AUDIO,
BEACON,
CSP_REPORT,
DOWNLOAD,
EMBED,
EVENT_SOURCE,
FAVICON,
FETCH,
FONT,
FORM,
FRAME,
HYPERLINK,
IFRAME,
IMAGE,
IMAGE_SET,
INTERNAL,
JSON,
LOCATION,
MANIFEST,
OBJECT,
PING,
PLUGIN,
PREFETCH,
SCRIPT,
SERVICE_WORKER,
SHARED_WORKER,
SPECULATION_RULES,
SUBRESOURCE,
SUBRESOURCE_WEBBUNDLE,
STYLE,
TRACK,
VIDEO,
WORKER,
XML_HTTP_REQUEST,
XSLT,
TEXT,
Arthur Sonzogni . unresolved

This enum seems sorted. Should we continue to keep it sorted?

File third_party/blink/renderer/core/fetch/request.cc
Line 128, Patchset 13 (Latest): case network::mojom::RequestDestination::kText:
return V8RequestDestination::Enum::kText;
Arthur Sonzogni . unresolved

nit: In all of the enums, when it makes sense, keep the entries sorted.

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Olivier Flückiger
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I52e851b4555e76e2f20816421e1d6c50f1bbae2f
    Gerrit-Change-Number: 7895444
    Gerrit-PatchSet: 13
    Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
    Gerrit-Attention: Adam Rice <ri...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Jun 2026 14:11:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Olivier Flückiger (Gerrit)

    unread,
    Jun 4, 2026, 10:41:34 AM (7 days ago) Jun 4
    to Chromium IPC Reviews, Arthur Sonzogni, Adam Rice, Nate Chapin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
    Attention needed from Adam Rice and Arthur Sonzogni

    Olivier Flückiger added 3 comments

    Patchset-level comments
    File-level comment, Patchset 14 (Latest):
    Olivier Flückiger . resolved

    ptal again

    File third_party/blink/public/mojom/fetch/fetch_api_request.mojom
    Line 30, Patchset 13: ATTRIBUTION_SRC,
    Arthur Sonzogni . resolved

    This enum seems sorted. Should we continue to keep it sorted?

    Olivier Flückiger

    Done

    File third_party/blink/renderer/core/fetch/request.cc
    Line 128, Patchset 13: case network::mojom::RequestDestination::kText:
    return V8RequestDestination::Enum::kText;
    Arthur Sonzogni . resolved

    nit: In all of the enums, when it makes sense, keep the entries sorted.

    Olivier Flückiger

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Rice
    • Arthur Sonzogni
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I52e851b4555e76e2f20816421e1d6c50f1bbae2f
      Gerrit-Change-Number: 7895444
      Gerrit-PatchSet: 14
      Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: gwsq
      Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Attention: Adam Rice <ri...@chromium.org>
      Gerrit-Comment-Date: Thu, 04 Jun 2026 14:41:13 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Arthur Sonzogni <arthurs...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Arthur Sonzogni (Gerrit)

      unread,
      Jun 5, 2026, 8:34:09 AM (6 days ago) Jun 5
      to Olivier Flückiger, Chromium IPC Reviews, Adam Rice, Nate Chapin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
      Attention needed from Adam Rice and Olivier Flückiger

      Arthur Sonzogni voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Adam Rice
      • Olivier Flückiger
      Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
      Gerrit-Attention: Adam Rice <ri...@chromium.org>
      Gerrit-Comment-Date: Fri, 05 Jun 2026 12:33:50 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Olivier Flückiger (Gerrit)

      unread,
      Jun 9, 2026, 10:25:28 AM (2 days ago) Jun 9
      to Nate Chapin, Benoit Lize, Aldo Culquicondor, Kelvin Jiang, Ben Kelly, Arthur Sonzogni, Chromium IPC Reviews, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
      Attention needed from Adam Rice, Aldo Culquicondor, Ben Kelly, Benoit Lize, Kelvin Jiang and Nate Chapin

      Olivier Flückiger added 1 comment

      Patchset-level comments
      File-level comment, Patchset 15 (Latest):
      Olivier Flückiger . resolved

      ptal, adding additional reviewers now that the 1/3 part landed and we got the mojo review.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Adam Rice
      • Aldo Culquicondor
      • Ben Kelly
      • Benoit Lize
      • Kelvin Jiang
      • Nate Chapin
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I52e851b4555e76e2f20816421e1d6c50f1bbae2f
      Gerrit-Change-Number: 7895444
      Gerrit-PatchSet: 15
      Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Aldo Culquicondor <aco...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Ben Kelly <wande...@meta.com>
      Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
      Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
      Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
      Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-Attention: Ben Kelly <wande...@meta.com>
      Gerrit-Attention: Aldo Culquicondor <aco...@chromium.org>
      Gerrit-Attention: Benoit Lize <li...@chromium.org>
      Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
      Gerrit-Attention: Nate Chapin <jap...@chromium.org>
      Gerrit-Attention: Adam Rice <ri...@chromium.org>
      Gerrit-Comment-Date: Tue, 09 Jun 2026 14:25:09 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ben Kelly (Gerrit)

      unread,
      Jun 9, 2026, 10:34:59 AM (2 days ago) Jun 9
      to Olivier Flückiger, Nate Chapin, Benoit Lize, Aldo Culquicondor, Kelvin Jiang, Arthur Sonzogni, Chromium IPC Reviews, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
      Attention needed from Adam Rice, Aldo Culquicondor, Benoit Lize, Kelvin Jiang, Nate Chapin and Olivier Flückiger

      Ben Kelly voted and added 1 comment

      Votes added by Ben Kelly

      Code-Review+1

      1 comment

      Patchset-level comments
      Ben Kelly . resolved

      service_worker LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Adam Rice
      • Aldo Culquicondor
      • Benoit Lize
      • Kelvin Jiang
      • Nate Chapin
      • Olivier Flückiger
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I52e851b4555e76e2f20816421e1d6c50f1bbae2f
        Gerrit-Change-Number: 7895444
        Gerrit-PatchSet: 15
        Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
        Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
        Gerrit-Reviewer: Aldo Culquicondor <aco...@chromium.org>
        Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Ben Kelly <wande...@meta.com>
        Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
        Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
        Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
        Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: James Maclean <wjma...@chromium.org>
        Gerrit-CC: Kevin McNee <mc...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-Attention: Aldo Culquicondor <aco...@chromium.org>
        Gerrit-Attention: Benoit Lize <li...@chromium.org>
        Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
        Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
        Gerrit-Attention: Nate Chapin <jap...@chromium.org>
        Gerrit-Attention: Adam Rice <ri...@chromium.org>
        Gerrit-Comment-Date: Tue, 09 Jun 2026 14:34:44 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Aldo Culquicondor (Gerrit)

        unread,
        Jun 9, 2026, 10:40:38 AM (2 days ago) Jun 9
        to Olivier Flückiger, Ben Kelly, Nate Chapin, Benoit Lize, Kelvin Jiang, Arthur Sonzogni, Chromium IPC Reviews, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
        Attention needed from Adam Rice, Benoit Lize, Kelvin Jiang, Nate Chapin and Olivier Flückiger

        Aldo Culquicondor added 1 comment

        File extensions/browser/api/web_request/web_request_resource_type.cc
        Line 83, Patchset 15 (Latest): case network::mojom::RequestDestination::kText:
        Aldo Culquicondor . unresolved

        why is it grouped together?

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Adam Rice
        • Benoit Lize
        • Kelvin Jiang
        • Nate Chapin
        • Olivier Flückiger
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement is not satisfiedNo-Unresolved-Comments
            • requirement satisfiedReview-Enforcement
            Gerrit-Attention: Benoit Lize <li...@chromium.org>
            Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
            Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
            Gerrit-Attention: Nate Chapin <jap...@chromium.org>
            Gerrit-Attention: Adam Rice <ri...@chromium.org>
            Gerrit-Comment-Date: Tue, 09 Jun 2026 14:40:24 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Olivier Flückiger (Gerrit)

            unread,
            Jun 9, 2026, 10:54:11 AM (2 days ago) Jun 9
            to Ben Kelly, Nate Chapin, Benoit Lize, Aldo Culquicondor, Kelvin Jiang, Arthur Sonzogni, Chromium IPC Reviews, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
            Attention needed from Adam Rice, Aldo Culquicondor, Benoit Lize, Kelvin Jiang and Nate Chapin

            Olivier Flückiger added 1 comment

            File extensions/browser/api/web_request/web_request_resource_type.cc
            Line 83, Patchset 15 (Latest): case network::mojom::RequestDestination::kText:
            Aldo Culquicondor . unresolved

            why is it grouped together?

            Olivier Flückiger

            They are all used for JS modules. In the spec text and json are called "synthetic modules".

            See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Adam Rice
            • Aldo Culquicondor
            • Benoit Lize
            • Kelvin Jiang
            • Nate Chapin
            Gerrit-Attention: Aldo Culquicondor <aco...@chromium.org>
            Gerrit-Attention: Benoit Lize <li...@chromium.org>
            Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
            Gerrit-Attention: Nate Chapin <jap...@chromium.org>
            Gerrit-Attention: Adam Rice <ri...@chromium.org>
            Gerrit-Comment-Date: Tue, 09 Jun 2026 14:53:54 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Comment-In-Reply-To: Aldo Culquicondor <aco...@chromium.org>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Aldo Culquicondor (Gerrit)

            unread,
            Jun 9, 2026, 11:19:57 AM (2 days ago) Jun 9
            to Olivier Flückiger, Ben Kelly, Nate Chapin, Benoit Lize, Kelvin Jiang, Arthur Sonzogni, Chromium IPC Reviews, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
            Attention needed from Adam Rice, Benoit Lize, Kelvin Jiang, Nate Chapin and Olivier Flückiger

            Aldo Culquicondor voted and added 1 comment

            Votes added by Aldo Culquicondor

            Code-Review+1

            1 comment

            Patchset-level comments
            Aldo Culquicondor . resolved

            +1 on slim_web_view, assuming it matches extensions/

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Adam Rice
            • Benoit Lize
            • Kelvin Jiang
            • Nate Chapin
            • Olivier Flückiger
            Gerrit-Attention: Benoit Lize <li...@chromium.org>
            Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
            Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
            Gerrit-Attention: Nate Chapin <jap...@chromium.org>
            Gerrit-Attention: Adam Rice <ri...@chromium.org>
            Gerrit-Comment-Date: Tue, 09 Jun 2026 15:19:40 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Adam Rice (Gerrit)

            unread,
            Jun 9, 2026, 12:25:40 PM (2 days ago) Jun 9
            to Olivier Flückiger, Aldo Culquicondor, Ben Kelly, Nate Chapin, Benoit Lize, Kelvin Jiang, Arthur Sonzogni, Chromium IPC Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
            Attention needed from Benoit Lize, Kelvin Jiang, Nate Chapin and Olivier Flückiger

            Adam Rice voted and added 1 comment

            Votes added by Adam Rice

            Code-Review+1

            1 comment

            Patchset-level comments
            Adam Rice . resolved

            //services/network and //third_party/blink/renderer/core/fetch lgtm

            Open in Gerrit

            Related details

            Attention is currently required from:
            Gerrit-Comment-Date: Tue, 09 Jun 2026 16:25:06 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Nate Chapin (Gerrit)

            unread,
            Jun 9, 2026, 12:41:22 PM (2 days ago) Jun 9
            to Olivier Flückiger, Adam Rice, Aldo Culquicondor, Ben Kelly, Benoit Lize, Kelvin Jiang, Arthur Sonzogni, Chromium IPC Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
            Attention needed from Benoit Lize, Kelvin Jiang and Olivier Flückiger

            Nate Chapin voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Benoit Lize
            • Kelvin Jiang
            • Olivier Flückiger
            Gerrit-Comment-Date: Tue, 09 Jun 2026 16:41:05 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Kelvin Jiang (Gerrit)

            unread,
            Jun 9, 2026, 7:33:58 PM (2 days ago) Jun 9
            to Olivier Flückiger, Nate Chapin, Adam Rice, Aldo Culquicondor, Ben Kelly, Benoit Lize, Arthur Sonzogni, Chromium IPC Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
            Attention needed from Benoit Lize and Olivier Flückiger

            Kelvin Jiang voted and added 1 comment

            Votes added by Kelvin Jiang

            Code-Review+1

            1 comment

            Patchset-level comments
            Kelvin Jiang . resolved

            extensions webrequest LGTM

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Benoit Lize
            • Olivier Flückiger
            Gerrit-Comment-Date: Tue, 09 Jun 2026 23:33:42 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Benoit Lize (Gerrit)

            unread,
            Jun 10, 2026, 3:58:16 AM (yesterday) Jun 10
            to Olivier Flückiger, Kelvin Jiang, Nate Chapin, Adam Rice, Aldo Culquicondor, Ben Kelly, Arthur Sonzogni, Chromium IPC Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org
            Attention needed from Olivier Flückiger

            Benoit Lize voted and added 1 comment

            Votes added by Benoit Lize

            Code-Review+1

            1 comment

            Patchset-level comments
            Benoit Lize . resolved

            lgtm

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Olivier Flückiger
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
            Gerrit-Comment-Date: Wed, 10 Jun 2026 07:57:50 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Olivier Flückiger (Gerrit)

            unread,
            Jun 10, 2026, 4:02:25 AM (yesterday) Jun 10
            to Benoit Lize, Kelvin Jiang, Nate Chapin, Adam Rice, Aldo Culquicondor, Ben Kelly, Arthur Sonzogni, Chromium IPC Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org

            Olivier Flückiger voted and added 2 comments

            Votes added by Olivier Flückiger

            Commit-Queue+2

            2 comments

            Patchset-level comments
            Olivier Flückiger . resolved

            thanks all 😊

            File extensions/browser/api/web_request/web_request_resource_type.cc
            Line 83, Patchset 15 (Latest): case network::mojom::RequestDestination::kText:
            Aldo Culquicondor . resolved

            why is it grouped together?

            Olivier Flückiger

            They are all used for JS modules. In the spec text and json are called "synthetic modules".

            See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with

            Olivier Flückiger

            Acknowledged

            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Gerrit-Comment-Date: Wed, 10 Jun 2026 08:01:49 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              Comment-In-Reply-To: Aldo Culquicondor <aco...@chromium.org>
              Comment-In-Reply-To: Olivier Flückiger <ol...@chromium.org>
              satisfied_requirement
              open
              diffy

              Chromium LUCI CQ (Gerrit)

              unread,
              Jun 10, 2026, 5:02:33 AM (yesterday) Jun 10
              to Olivier Flückiger, Benoit Lize, Kelvin Jiang, Nate Chapin, Adam Rice, Aldo Culquicondor, Ben Kelly, Arthur Sonzogni, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kevin McNee, James Maclean, antoniosarto...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, arthursonzog...@chromium.org, mkwst+w...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, storage...@chromium.org

              Chromium LUCI CQ submitted the change

              Change information

              Commit message:
              import text: Add text mojom::RequestDestination (2/3)

              Add the required request types for the the TC39 feature "import text".

              See https://github.com/tc39/proposal-import-text
              Bug: 494350643
              Change-Id: I52e851b4555e76e2f20816421e1d6c50f1bbae2f
              Reviewed-by: Ben Kelly <wande...@meta.com>
              Reviewed-by: Benoit Lize <li...@chromium.org>
              Commit-Queue: Olivier Flückiger <ol...@chromium.org>
              Reviewed-by: Kelvin Jiang <kelvi...@chromium.org>
              Reviewed-by: Aldo Culquicondor <aco...@chromium.org>
              Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
              Reviewed-by: Nate Chapin <jap...@chromium.org>
              Reviewed-by: Adam Rice <ri...@chromium.org>
              Cr-Commit-Position: refs/heads/main@{#1644524}
              Files:
              • M chrome/browser/predictors/loading_predictor_tab_helper.cc
              • M chrome/browser/predictors/prefetch_manager.cc
              • M components/guest_view/browser/slim_web_view/request_utils.cc
              • M components/services/storage/service_worker/service_worker_database.cc
              • M components/services/storage/service_worker/service_worker_database.proto
              • M extensions/browser/api/web_request/web_request_resource_type.cc
              • M services/network/cors/cors_url_loader_factory.cc
              • M services/network/public/cpp/request_destination.cc
              • M services/network/public/mojom/fetch_api.mojom
              • M third_party/blink/common/loader/network_utils.cc
              • M third_party/blink/public/mojom/fetch/fetch_api_request.mojom
              • M third_party/blink/renderer/core/fetch/request.cc
              • M third_party/blink/renderer/core/fetch/request.idl
              • M third_party/blink/renderer/core/fetch/request_util.cc
              • M third_party/blink/renderer/core/frame/csp/content_security_policy.cc
              • M third_party/blink/renderer/core/inspector/inspector_audits_issue.cc
              • M third_party/blink/renderer/core/inspector/inspector_issue_conversion.cc
              • M third_party/blink/renderer/core/loader/mixed_content_checker.cc
              • M third_party/blink/renderer/platform/loader/fetch/fetch_utils.cc
              • M third_party/blink/renderer/platform/loader/fetch/url_loader/request_conversion.cc
              • M third_party/blink/renderer/platform/loader/mixed_content.cc
              Change size: M
              Delta: 21 files changed, 63 insertions(+), 25 deletions(-)
              Branch: refs/heads/main
              Submit Requirements:
              • requirement satisfiedCode-Review: +1 by Kelvin Jiang, +1 by Aldo Culquicondor, +1 by Adam Rice, +1 by Nate Chapin, +1 by Arthur Sonzogni, +1 by Benoit Lize, +1 by Ben Kelly
              Open in Gerrit
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: merged
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I52e851b4555e76e2f20816421e1d6c50f1bbae2f
              Gerrit-Change-Number: 7895444
              Gerrit-PatchSet: 16
              Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
              Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
              Gerrit-Reviewer: Aldo Culquicondor <aco...@chromium.org>
              Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
              Gerrit-Reviewer: Ben Kelly <wande...@meta.com>
              Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
              Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
              Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
              Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
              open
              diffy
              satisfied_requirement
              Reply all
              Reply to author
              Forward
              0 new messages