| Commit-Queue | +1 |
Ptal, also open to suggestions on how to make this easier to get it reviewed by all owners 😊
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: arthurs...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): arthurs...@chromium.org
Reviewer source(s):
arthurs...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ATTRIBUTION_SRC,
AUDIO,
BEACON,
CSP_REPORT,
DOWNLOAD,
EMBED,
EVENT_SOURCE,
FAVICON,
FETCH,
FONT,
FORM,
FRAME,
HYPERLINK,
IFRAME,
IMAGE,
IMAGE_SET,
INTERNAL,
JSON,
LOCATION,
MANIFEST,
OBJECT,
PING,
PLUGIN,
PREFETCH,
SCRIPT,
SERVICE_WORKER,
SHARED_WORKER,
SPECULATION_RULES,
SUBRESOURCE,
SUBRESOURCE_WEBBUNDLE,
STYLE,
TRACK,
VIDEO,
WORKER,
XML_HTTP_REQUEST,
XSLT,
TEXT,This enum seems sorted. Should we continue to keep it sorted?
case network::mojom::RequestDestination::kText:
return V8RequestDestination::Enum::kText;nit: In all of the enums, when it makes sense, keep the entries sorted.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ATTRIBUTION_SRC,This enum seems sorted. Should we continue to keep it sorted?
Done
case network::mojom::RequestDestination::kText:
return V8RequestDestination::Enum::kText;nit: In all of the enums, when it makes sense, keep the entries sorted.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ptal, adding additional reviewers now that the 1/3 part landed and we got the mojo review.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
case network::mojom::RequestDestination::kText:why is it grouped together?
case network::mojom::RequestDestination::kText:why is it grouped together?
They are all used for JS modules. In the spec text and json are called "synthetic modules".
See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with
| Code-Review | +1 |
+1 on slim_web_view, assuming it matches extensions/
| Code-Review | +1 |
//services/network and //third_party/blink/renderer/core/fetch lgtm
| Commit-Queue | +2 |
thanks all 😊
case network::mojom::RequestDestination::kText:Olivier Flückigerwhy is it grouped together?
They are all used for JS modules. In the spec text and json are called "synthetic modules".
See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with
Acknowledged
import text: Add text mojom::RequestDestination (2/3)
Add the required request types for the the TC39 feature "import text".
See https://github.com/tc39/proposal-import-text
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |