[WebAudio] Core URL Plumbing & Promise Rejection Enrichment (3/3) [chromium/src : main]
0 views
Skip to first unread message
Mahesh Kannan (Gerrit)
Jul 30, 2026, 12:46:24 PM (17 hours ago) Jul 30
to Hongchan Choi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Hiroki Nakagawa, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
Attention needed from Mahesh Kannan
Message from Mahesh Kannan![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Mahesh Kannan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mahesh Kannan (Gerrit)
Jul 30, 2026, 12:47:08 PM (17 hours ago) Jul 30
to Nate Chapin, Hongchan Choi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
Attention needed from Nate Chapin
Mahesh Kannan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 11 (Latest):
Mahesh Kannan . resolved
Last CL part of this series. Thank you for your reviews. PTAL!
Related details
Attention is currently required from:
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Jul 30, 2026, 1:46:27 PM (16 hours ago) Jul 30
to Mahesh Kannan, Hongchan Choi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
Attention needed from Mahesh Kannan
Nate Chapin voted and added 4 comments![]( "Open in Gerrit")
Votes added by Nate Chapin
| Code-Review | +1 |
4 comments
File third_party/blink/renderer/core/workers/worklet_module_tree_client.cc
Line 126, Patchset 11 (Latest):
if (global_scope && global_scope->GetModuleResponsesMap()) {Nate Chapin . unresolved
I think `global_scope` is guaranteed non-null here?
Line 169, Patchset 11 (Latest):
ToV8Traits<DOMException>::ToV8(script_state_, dom_exception);Nate Chapin . unresolved
`dom_exception->ToV8(script_state_);` is a little more direct and cleaner - you can use it for an class that is a subclass of `ScriptWrappable` and is guaranteed non-null.
File third_party/blink/renderer/core/workers/worklet_pending_tasks.cc
Line 50, Patchset 11 (Latest):
if (script_state && script_state->ContextIsValid()) {Nate Chapin . unresolved
`script_state` should be guaranteed non-null.
Line 51, Patchset 11 (Latest):
ScriptState::Scope scope(script_state);Nate Chapin . unresolved
I think this can stay inside the `if (error_to_rethrow) {}` block. ScriptPromiseResolver takes care of ensuring we're in-scope, so we only need to enter the scope for `Deserialize()`
Related details
Attention is currently required from:
- Mahesh Kannan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mahesh Kannan (Gerrit)
Jul 30, 2026, 6:54:43 PM (11 hours ago) Jul 30
to Nate Chapin, Hongchan Choi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
Mahesh Kannan added 4 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/workers/worklet_module_tree_client.cc
Line 126, Patchset 11:
if (global_scope && global_scope->GetModuleResponsesMap()) {Nate Chapin . resolved
I think `global_scope` is guaranteed non-null here?
Mahesh Kannan
Acknowledged
Line 169, Patchset 11:
ToV8Traits<DOMException>::ToV8(script_state_, dom_exception);Nate Chapin . resolved
`dom_exception->ToV8(script_state_);` is a little more direct and cleaner - you can use it for an class that is a subclass of `ScriptWrappable` and is guaranteed non-null.
Mahesh Kannan
Thank you, applied
File third_party/blink/renderer/core/workers/worklet_pending_tasks.cc
`script_state` should be guaranteed non-null.
Mahesh Kannan
Done
I think this can stay inside the `if (error_to_rethrow) {}` block. ScriptPromiseResolver takes care of ensuring we're in-scope, so we only need to enter the scope for `Deserialize()`
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages