[soft navs] Remove navigation id from browser [chromium/src : main]
0 views
Skip to first unread message
Johannes Henkel (Gerrit)
Feb 17, 2026, 8:19:51 PM (3 days ago) Feb 17
to Annie Sullivan, Michal Mocny, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan and Michal Mocny
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Annie Sullivan
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Feb 17, 2026, 11:36:09 PM (3 days ago) Feb 17
to Johannes Henkel, Annie Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan and Johannes Henkel
Michal Mocny added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Michal Mocny . resolved
tryjobs failing, but the CL looks good to me.
Commit Message
Line 19, Patchset 4 (Latest):
Therefore, marking SoftNavigation:NavigationId as DEPRECATEDMichal Mocny . unresolved
Just checking: was this reporting the pseudo random number before? Agree that isn't useful for UKM.
File components/page_load_metrics/renderer/page_timing_metrics_sender.cc
Line 132, Patchset 4 (Parent):
CHECK_NE(new_metrics.navigation_id, soft_navigation_metrics_->navigation_id);Michal Mocny . resolved
I was going to ask if this is still useful to enforce on the renderer-side even if we don't send to UKM.
But (1) we already check that count increased, at least, and (2) we should just move this check higher up to the "emit" location rather than on the exported data from blink side.
Related details
Attention is currently required from:
- Annie Sullivan
- Johannes Henkel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Feb 17, 2026, 11:58:54 PM (3 days ago) Feb 17
to Annie Sullivan, Michal Mocny, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan and Michal Mocny
Johannes Henkel added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Commit Message
Line 19, Patchset 4:
Therefore, marking SoftNavigation:NavigationId as DEPRECATEDMichal Mocny . resolved
Just checking: was this reporting the pseudo random number before? Agree that isn't useful for UKM.
Attention is currently required from:
- Annie Sullivan
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Feb 18, 2026, 3:46:34 PM (2 days ago) Feb 18
to Chromium IPC Reviews, Chris Harrelson, Robert Kaplow, Annie Sullivan, Michal Mocny, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Chris Harrelson, Chromium IPC Reviews, Michal Mocny and Robert Kaplow
Johannes Henkel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Johannes Henkel . resolved
Hi, since this will need reviews/approvals for:
ukm.xml - Adding Robert
web_performance_metrics_for_reporting - Adding Chris
page_load_metrics.mojom - adding Chromium IPC Reviews
Thanks!
Related details
Attention is currently required from:
- Annie Sullivan
- Chris Harrelson
- Chromium IPC Reviews
- Michal Mocny
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Feb 18, 2026, 3:49:43 PM (2 days ago) Feb 18
to Johannes Henkel, Chromium IPC Reviews, Fred Shih, Chris Harrelson, Robert Kaplow, Annie Sullivan, Michal Mocny, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Chris Harrelson, Fred Shih, Michal Mocny and Robert Kaplow
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ff...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ff...@chromium.org
Reviewer source(s):
ff...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Annie Sullivan
- Chris Harrelson
- Fred Shih
- Michal Mocny
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Kaplow (Gerrit)
Feb 18, 2026, 4:25:17 PM (2 days ago) Feb 18
to Johannes Henkel, Chromium IPC Reviews, Fred Shih, Chris Harrelson, Annie Sullivan, Michal Mocny, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Chris Harrelson, Fred Shih, Johannes Henkel and Michal Mocny
Robert Kaplow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Annie Sullivan
- Chris Harrelson
- Fred Shih
- Johannes Henkel
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
Feb 18, 2026, 4:32:07 PM (2 days ago) Feb 18
to Johannes Henkel, Chris Harrelson, Robert Kaplow, Chromium IPC Reviews, Fred Shih, Annie Sullivan, Michal Mocny, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Chris Harrelson, Fred Shih, Johannes Henkel and Michal Mocny
Scott Haseley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Haseley
| Code-Review | +1 |
1 comment
Patchset-level comments
Scott Haseley . resolved
LGTM
Related details
Attention is currently required from:
- Annie Sullivan
- Chris Harrelson
- Fred Shih
- Johannes Henkel
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fred Shih (Gerrit)
Feb 18, 2026, 5:34:46 PM (2 days ago) Feb 18
to Johannes Henkel, Scott Haseley, Chris Harrelson, Robert Kaplow, Chromium IPC Reviews, Annie Sullivan, Michal Mocny, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Chris Harrelson, Johannes Henkel and Michal Mocny
Fred Shih voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Annie Sullivan
- Chris Harrelson
- Johannes Henkel
- Michal Mocny
Michal Mocny (Gerrit)
Feb 19, 2026, 11:54:21 AM (yesterday) Feb 19
to Johannes Henkel, Fred Shih, Scott Haseley, Chris Harrelson, Robert Kaplow, Chromium IPC Reviews, Annie Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Chris Harrelson and Johannes Henkel
Michal Mocny voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Annie Sullivan
- Chris Harrelson
- Johannes Henkel
Submit Requirements:
Code-Coverage
Code-Owners
Johannes Henkel (Gerrit)
Feb 19, 2026, 11:56:29 AM (yesterday) Feb 19
to Michal Mocny, Fred Shih, Scott Haseley, Chris Harrelson, Robert Kaplow, Chromium IPC Reviews, Annie Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan and Chris Harrelson
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Annie Sullivan
- Chris Harrelson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 19, 2026, 1:02:06 PM (yesterday) Feb 19
to Johannes Henkel, Michal Mocny, Fred Shih, Scott Haseley, Chris Harrelson, Robert Kaplow, Chromium IPC Reviews, Annie Sullivan, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, core-timi...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[soft navs] Remove navigation id from browser
We don't need the navigation id to record soft
navigations correctly, and there's no practical
use to have the navigation id in UKM.
For uniquely identifying soft navigations
in the browser, we will use the soft navigation count,
which we also log to UKM. Or something equivalent.
But having the redundant navigation id around
is not healthy or useful.
Therefore, marking SoftNavigation:NavigationId as DEPRECATED
in ukm.xml.
Bug: 480156637
Change-Id: Ib252da583424b913526c405d6dcaa669da379701
Reviewed-by: Fred Shih <ff...@chromium.org>
Reviewed-by: Michal Mocny <mmo...@chromium.org>
Commit-Queue: Johannes Henkel <joha...@chromium.org>
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Reviewed-by: Scott Haseley <shas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1587241}
Files:
- M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
- M chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer.cc
- M chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer_unittest.cc
- M components/page_load_metrics/common/page_load_metrics.mojom
- M components/page_load_metrics/common/page_load_metrics_debug_string.cc
- M components/page_load_metrics/common/page_load_metrics_debug_string_unittest.cc
- M components/page_load_metrics/common/page_load_timing.cc
- M components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc
- M components/page_load_metrics/renderer/page_timing_metrics_sender.cc
- M third_party/blink/public/web/web_performance_metrics_for_reporting.h
- M third_party/blink/renderer/core/timing/soft_navigation_heuristics.cc
- M tools/metrics/ukm/ukm.xml
Change size: S
Delta: 12 files changed, 8 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michal Mocny, +1 by Scott Haseley, +1 by Robert Kaplow, +1 by Fred Shih
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages