[soft navs] Add SoftNavigationRecorder, to be invoked from ukm observers. [chromium/src : main]

0 views

Skip to first unread message

Johannes Henkel (Gerrit)

unread,

Apr 29, 2026, 6:30:25 PMApr 29

to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, core-web-vita...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Johannes Henkel voted and added 2 comments

Votes added by Johannes Henkel

Commit-Queue

2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Johannes Henkel . resolved

I'll refine SoftNavigationRecorder some more while adding support for prerender and bfcache (will do stacked cls for that), but figure it's good to send out what I have now so it's not a huge pile at once.

File chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer.cc

Line 198, Patchset 6 (Parent):

// These are the high bounds of each bucket, in enum order. The index into this
// array is cast to an enum value when recording UKM. These should correspond to
// the upper bounds of the BitsPerPixelExponential enum in
// //tools/metrics/histograms/enums.xml.
static const double kLCPEntropyBucketThresholds[] = {
    0.0,  0.00001, 0.0001, 0.001, 0.01, 0.02, 0.03, 0.04,  0.05,   0.06,   0.07,
    0.08, 0.09,    0.1,    0.2,   0.3,  0.4,  0.5,  0.6,   0.7,    0.8,    0.9,
    1.0,  2.0,     3.0,    4.0,   5.0,  6.0,  7.0,  8.0,   9.0,    10.0,   20.0,
    30.0, 40.0,    50.0,   60.0,  70.0, 80.0, 90.0, 100.0, 1000.0, 10000.0};

int64_t CalculateLCPEntropyBucket(double bpp) {
  return std::lower_bound(std::begin(kLCPEntropyBucketThresholds),
                          std::end(kLCPEntropyBucketThresholds), bpp) -
         std::begin(kLCPEntropyBucketThresholds);
}

Johannes Henkel . unresolved

I moved this routine to page_load_metrics_util.{h,cc} so it can be shared between soft navigation recorder and this observer.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Johannes Henkel (Gerrit)

unread,

May 19, 2026, 1:03:05 PM (14 hours ago) May 19

Johannes Henkel abandoned this change.

View Change

Abandoned

went with soft navigation page load metrics observer instead

Johannes Henkel abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages