Evict speculative decode image candidates that are too small [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
Sep 15, 2025, 3:42:38 PM (2 days ago) Sep 15
to Stefan Zager, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Stefan Zager

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Philip Rogers . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5a6f1d9fce2f1b713a10ec8e7d77282d17e0b2d0
Gerrit-Change-Number: 6950963
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 19:42:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Sep 15, 2025, 4:17:30 PM (2 days ago) Sep 15
to Stefan Zager, Philip Rogers, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Stefan Zager

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12711fd2510000

Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5a6f1d9fce2f1b713a10ec8e7d77282d17e0b2d0
Gerrit-Change-Number: 6950963
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 20:17:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Stefan Zager (Gerrit)

unread,
Sep 15, 2025, 4:22:03 PM (2 days ago) Sep 15
to chrom...@appspot.gserviceaccount.com, Philip Rogers, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org

Stefan Zager voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5a6f1d9fce2f1b713a10ec8e7d77282d17e0b2d0
Gerrit-Change-Number: 6950963
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 20:21:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Sep 15, 2025, 4:48:17 PM (2 days ago) Sep 15
to Stefan Zager, Philip Rogers, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Stefan Zager

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf-pgo/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11711fd2510000

Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5a6f1d9fce2f1b713a10ec8e7d77282d17e0b2d0
Gerrit-Change-Number: 6950963
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 20:48:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 15, 2025, 5:07:27 PM (2 days ago) Sep 15
to Stefan Zager, chrom...@appspot.gserviceaccount.com, Philip Rogers, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Evict speculative decode image candidates that are too small
Bug: chromium:441844763,chromium:378623805
Change-Id: I5a6f1d9fce2f1b713a10ec8e7d77282d17e0b2d0
Commit-Queue: Stefan Zager <sza...@chromium.org>
Reviewed-by: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1515710}
Files:
  • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Rogers
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5a6f1d9fce2f1b713a10ec8e7d77282d17e0b2d0
Gerrit-Change-Number: 6950963
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages