Reland "[soft navs] Re-enable improved LargestContentfulPaint UKM test." [chromium/src : main]
0 views
Skip to first unread message
Johannes Henkel (Gerrit)
Sep 11, 2025, 2:25:24 PM (6 days ago) Sep 11
to Michal Mocny, Rubber Stamper, Nidhi Jaju, Shunya Shishido, Chromium LUCI CQ, Annie Sullivan, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metr...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Attention needed from Annie Sullivan, Michal Mocny, Nidhi Jaju and Shunya Shishido
Message from Johannes Henkel![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Annie Sullivan
- Michal Mocny
- Nidhi Jaju
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Sep 11, 2025, 2:26:15 PM (6 days ago) Sep 11
to Johannes Henkel, Michal Mocny, Nidhi Jaju, Shunya Shishido, Chromium LUCI CQ, Annie Sullivan, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metr...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Attention needed from Annie Sullivan, Michal Mocny, Nidhi Jaju and Shunya Shishido
Message from Rubber Stamper![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Annie Sullivan (Gerrit)
Sep 11, 2025, 2:30:33 PM (6 days ago) Sep 11
to Johannes Henkel, Michal Mocny, Nidhi Jaju, Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metr...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Annie Sullivan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Sep 11, 2025, 3:56:35 PM (6 days ago) Sep 11
to Annie Sullivan, Michal Mocny, Nidhi Jaju, Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metr...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Attention needed from Annie Sullivan, Johannes Henkel, Michal Mocny, Nidhi Jaju and Shunya Shishido
Message from Johannes Henkel![]( "Open in Gerrit")
Attention is currently required from:
- Annie Sullivan
- Johannes Henkel
- Michal Mocny
- Nidhi Jaju
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Sep 11, 2025, 3:57:55 PM (6 days ago) Sep 11
to Annie Sullivan, Michal Mocny, Nidhi Jaju, Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metr...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Attention needed from Annie Sullivan, Michal Mocny, Nidhi Jaju and Shunya Shishido
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Johannes Henkel . resolved
Thanks a lot!
I'll give this one another try. I ran the bfcache try-bots which did fail on the previous attempt (which got reverted). Hopefully this time it can stick.
Related details
Attention is currently required from:
- Annie Sullivan
Chromium LUCI CQ (Gerrit)
Sep 11, 2025, 4:01:32 PM (6 days ago) Sep 11
to Johannes Henkel, Annie Sullivan, Michal Mocny, Nidhi Jaju, Shunya Shishido, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metr...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[soft navs] Re-enable improved LargestContentfulPaint UKM test."
This reverts commit 12961c0594c913970ddf9b582983f68b9f5ef829.
Reason for revert: Failures leading to revert no longer reproduce.
Original change's description:
> Revert "[soft navs] Re-enable improved LargestContentfulPaint UKM test."
>
> This reverts commit 5375726a6ef855c67d6eb7c99af011f0be1526a6.
>
> Reason for revert: Causing consistent failures for SoftNavgationTest.*LargestContentPaint
> i.e. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/75083/overview
>
> Bug: 425398556, 382245480
> Original change's description:
> > [soft navs] Re-enable improved LargestContentfulPaint UKM test.
> >
> > This change splits the LargestContentfulPaint into two tests, one for
> > image lcp, and one for text. It uses a new, simpler test file,
> > soft_navigation_basics.html, which does not have javascript except the
> > simple stuff to make the page work.
> >
> > Bug: 425398556, 382245480
> > Change-Id: I6ad9b84c9fbdbd7ab9f859376a0d532c06475721
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6656159
> > Reviewed-by: Shunya Shishido <sisid...@chromium.org>
> > Commit-Queue: Johannes Henkel <joha...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1493222}
>
> Bug: 425398556, 382245480
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: If6f085477328313706ab253da612197299f4f905
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6796469
> Owners-Override: Nidhi Jaju <nidh...@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Auto-Submit: Nidhi Jaju <nidh...@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1493259}
Bug: 425398556, 382245480
Change-Id: I6248cb64efea6ad293f6da848d853a00eeeaceca
Commit-Queue: Johannes Henkel <joha...@chromium.org>
Reviewed-by: Annie Sullivan <sull...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1514473}
Files:
- A chrome/browser/page_load_metrics/integration_tests/data/soft_navigation_basics.html
- M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
Change size: L
Delta: 2 files changed, 242 insertions(+), 131 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Annie Sullivan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages