Replace some uses of String::Truncate with StringView [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Jan 29, 2026, 9:13:33 AM (2 days ago) Jan 29
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, dmurph+watch...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, webap...@microsoft.com
Attention needed from Kent Tamura

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iccff3ae131c4d9befa741aac28ab4c9716ad06b9
Gerrit-Change-Number: 7532617
Gerrit-PatchSet: 1
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 14:13:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Jan 29, 2026, 5:03:22 PM (2 days ago) Jan 29
to Fredrik Söderquist, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, dmurph+watch...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, webap...@microsoft.com
Attention needed from Fredrik Söderquist

Kent Tamura voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccff3ae131c4d9befa741aac28ab4c9716ad06b9
    Gerrit-Change-Number: 7532617
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Thu, 29 Jan 2026 22:02:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 29, 2026, 5:43:15 PM (2 days ago) Jan 29
    to Fredrik Söderquist, Kent Tamura, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, dmurph+watch...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, webap...@microsoft.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Replace some uses of String::Truncate with StringView

    In both these case we can use a StringView the same result without
    creating a new String.
    Bug: 473854537
    Change-Id: Iccff3ae131c4d9befa741aac28ab4c9716ad06b9
    Reviewed-by: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Kent Tamura <tk...@chromium.org>
    Auto-Submit: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1576870}
    Files:
    • M third_party/blink/renderer/modules/manifest/manifest_parser.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource.cc
    Change size: XS
    Delta: 2 files changed, 3 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kent Tamura
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccff3ae131c4d9befa741aac28ab4c9716ad06b9
    Gerrit-Change-Number: 7532617
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages