[iframe] Reset the size when navigating cross-origin [chromium/src : main]
0 views
Skip to first unread message
Koji Ishii (Gerrit)
Jun 4, 2026, 7:16:13 AM (7 days ago) Jun 4
to Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Ian Kilpatrick
Koji Ishii added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jun 9, 2026, 1:59:38 AM (2 days ago) Jun 9
to Koji Ishii, Kent Tamura, Code Review Nudger, Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Ian Kilpatrick and Koji Ishii
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Jun 9, 2026, 11:47:48 PM (2 days ago) Jun 9
to Koji Ishii, Kent Tamura, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Koji Ishii
Ian Kilpatrick voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Koji Ishii
Koji Ishii (Gerrit)
Jun 10, 2026, 2:40:42 AM (yesterday) Jun 10
to Ian Kilpatrick, Kent Tamura, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Koji Ishii (Gerrit)
Jun 10, 2026, 2:59:19 AM (yesterday) Jun 10
to Rakina Zata Amni, Ian Kilpatrick, Kent Tamura, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Rakina Zata Amni
Koji Ishii added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Koji Ishii . resolved
Rakina, PTAL `content/*`.
Related details
Attention is currently required from:
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Jun 10, 2026, 3:07:38 AM (yesterday) Jun 10
to Koji Ishii, Ian Kilpatrick, Kent Tamura, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Koji Ishii
Rakina Zata Amni voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 10, 2026, 3:21:38 AM (yesterday) Jun 10
to Koji Ishii, Rakina Zata Amni, Ian Kilpatrick, Kent Tamura, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Koji Ishii
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60522.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Jun 10, 2026, 8:10:36 AM (23 hours ago) Jun 10
to Blink W3C Test Autoroller, Rakina Zata Amni, Ian Kilpatrick, Kent Tamura, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Chromium LUCI CQ (Gerrit)
Jun 10, 2026, 9:12:20 AM (22 hours ago) Jun 10
to Koji Ishii, Blink W3C Test Autoroller, Rakina Zata Amni, Ian Kilpatrick, Kent Tamura, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iframe] Reset the size when navigating cross-origin
This patch resets the intrinsic size info from `<iframe>`
content when the content navigates cross-origin, to prevent
leaking the size information.
To do this, when `DocumentLoader` for an `<iframe>` child
content checks if it's a cross-origin navigation in
`CommitNavigation()`, and clears the natural dimension if so.
`FrameLoader` is changed to keep the old document origin.
`RenderWidgetHostViewChildFrame` needs a new queue for the
intrinsic size events, as its `frame_connector_` isn't set yet
at the `CommitNavigation()` timing.
`content_switch_dependent_feature_overrides.cc` is needed to
change to enable the flag in the browser when testing. In the
non-testing environments, the flag in Blink and Browser are
automatically synchronized.
The existing test `responsive-iframe-navigation.html` is
extended to test cross-origin as a new variant. In addition,
it tests the initial viewport size of the child frame.
All changes are under a runtime flag.
Bug: 418397278
Change-Id: If8977a4fab2f9bf0c7bdb7bd2dc7c939b2b03f64
Commit-Queue: Koji Ishii <ko...@chromium.org>
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1644590}
Files:
- M content/browser/renderer_host/render_widget_host_view_child_frame.cc
- M content/browser/renderer_host/render_widget_host_view_child_frame.h
- M content/public/common/content_switch_dependent_feature_overrides.cc
- M third_party/blink/renderer/core/frame/frame_owner.h
- M third_party/blink/renderer/core/frame/frame_view.h
- M third_party/blink/renderer/core/frame/local_frame_view.cc
- M third_party/blink/renderer/core/frame/local_frame_view.h
- M third_party/blink/renderer/core/frame/remote_frame_owner.cc
- M third_party/blink/renderer/core/frame/remote_frame_owner.h
- M third_party/blink/renderer/core/frame/remote_frame_view.h
- M third_party/blink/renderer/core/frame/web_local_frame_impl.cc
- M third_party/blink/renderer/core/html/html_frame_owner_element.cc
- M third_party/blink/renderer/core/html/html_frame_owner_element.h
- M third_party/blink/renderer/core/loader/document_loader.cc
- M third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
- M third_party/blink/renderer/core/loader/frame_loader.cc
- M third_party/blink/renderer/core/loader/old_document_info_for_commit.h
- M third_party/blink/web_tests/external/wpt/css/css-sizing/responsive-iframe/resources/iframe-contents-navigation.html
- M third_party/blink/web_tests/external/wpt/css/css-sizing/responsive-iframe/resources/iframe-contents-slow.html
- M third_party/blink/web_tests/external/wpt/css/css-sizing/responsive-iframe/responsive-iframe-navigation-unsized.html
- M third_party/blink/web_tests/external/wpt/css/css-sizing/responsive-iframe/responsive-iframe-navigation.html
Change size: M
Delta: 21 files changed, 133 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick, +1 by Rakina Zata Amni, +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 10, 2026, 9:53:23 AM (21 hours ago) Jun 10
to Chromium LUCI CQ, Koji Ishii, Rakina Zata Amni, Ian Kilpatrick, Kent Tamura, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Kenneth Rohde Christiansen, Zhe Su, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, keithle...@chromium.org, loading...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60522
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages