[LNA] Rename PNA-named files to LNA-named files [chromium/src : main]

0 views
Skip to first unread message

Hubert Chao (Gerrit)

unread,
Jan 28, 2026, 7:44:30 PM (2 days ago) Jan 28
to Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Nate Chapin, James Maclean, blink-re...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, devtools-re...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Chris Thompson

Hubert Chao added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Hubert Chao . resolved

@cth...@chromium.org for initial review

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Thompson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I86cce114feff36cbf2d84439ba2bd44e59f5548f
Gerrit-Change-Number: 7528398
Gerrit-PatchSet: 7
Gerrit-Owner: Hubert Chao <hc...@chromium.org>
Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Chris Thompson <cth...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 00:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Chris Thompson (Gerrit)

unread,
Jan 30, 2026, 1:16:33 PM (12 hours ago) Jan 30
to Hubert Chao, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Nate Chapin, James Maclean, blink-re...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, devtools-re...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Hubert Chao

Chris Thompson added 4 comments

Patchset-level comments
Chris Thompson . resolved

Overall LGTM -- thanks for pushing through all the rename bits (the old references to PNA continue to occasionally cause confusion). Some small edits in-line, plus a question about enums.xml and histograms.

File services/network/public/cpp/local_network_access_check_result.h
Line 72, Patchset 7 (Latest):// LINT.ThenChange(//tools/metrics/histograms/metadata/security/enums.xml:LocalNetworkAccessCheckResult)
Chris Thompson . unresolved

Must also change that name in enums.xml -- I think that's safe to do, but we should double check it and any usage of that enum name in UMA histogram definitions.

Line 20, Patchset 7 (Latest):// Please keep in sync with "PrivateNetworkAccessCheckResult" in
Chris Thompson . unresolved

```suggestion
// Please keep in sync with "LocalNetworkAccessCheckResult" in
```

File services/network/url_loader.cc
Line 856, Patchset 7 (Latest): // Delegate the PNA check to the interceptor.
Chris Thompson . unresolved
```suggestion
  // Delegate the LNA check to the interceptor.
```
Open in Gerrit

Related details

Attention is currently required from:
  • Hubert Chao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I86cce114feff36cbf2d84439ba2bd44e59f5548f
    Gerrit-Change-Number: 7528398
    Gerrit-PatchSet: 7
    Gerrit-Owner: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
    Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Hubert Chao <hc...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 18:16:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Chris Thompson (Gerrit)

    unread,
    Jan 30, 2026, 1:16:48 PM (12 hours ago) Jan 30
    to Hubert Chao, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Nate Chapin, James Maclean, blink-re...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, devtools-re...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Hubert Chao

    Chris Thompson voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hubert Chao
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I86cce114feff36cbf2d84439ba2bd44e59f5548f
      Gerrit-Change-Number: 7528398
      Gerrit-PatchSet: 7
      Gerrit-Owner: Hubert Chao <hc...@chromium.org>
      Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
      Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-Attention: Hubert Chao <hc...@chromium.org>
      Gerrit-Comment-Date: Fri, 30 Jan 2026 18:16:34 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages