Record Google Search HTTP status codes for incognito profiles. [chromium/src : main]

0 views
Skip to first unread message

Keita Suzuki (Gerrit)

unread,
Feb 18, 2026, 3:02:25 AM (2 days ago) Feb 18
to Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org
Attention needed from Takashi Toyoshima

Keita Suzuki added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Keita Suzuki . resolved

PTAL. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I03b80deef54ac5aff851063dfdb52fcdb4b00a87
Gerrit-Change-Number: 7586665
Gerrit-PatchSet: 1
Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Feb 2026 08:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Feb 19, 2026, 1:13:56 AM (yesterday) Feb 19
to Keita Suzuki, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org
Attention needed from Keita Suzuki

Takashi Toyoshima voted and added 1 comment

Votes added by Takashi Toyoshima

Code-Review+1

1 comment

Patchset-level comments
Takashi Toyoshima . resolved

thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Keita Suzuki
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I03b80deef54ac5aff851063dfdb52fcdb4b00a87
Gerrit-Change-Number: 7586665
Gerrit-PatchSet: 1
Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Comment-Date: Thu, 19 Feb 2026 06:13:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Keita Suzuki (Gerrit)

unread,
Feb 19, 2026, 1:14:47 AM (yesterday) Feb 19
to Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org

Keita Suzuki voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I03b80deef54ac5aff851063dfdb52fcdb4b00a87
Gerrit-Change-Number: 7586665
Gerrit-PatchSet: 1
Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 06:14:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 19, 2026, 1:17:46 AM (yesterday) Feb 19
to Keita Suzuki, Takashi Toyoshima, Chromium Metrics Reviews, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Record Google Search HTTP status codes for incognito profiles.

This change adds a new UMA histogram variant to track HTTP status codes
for Google Search page loads specifically when the user is in an
incognito profile. The existing
PageLoad.Clients.GoogleSearch.HttpStatusCode histograms will now have an
".Incognito" suffix when recorded from an incognito session.
Bug: 473593133
Change-Id: I03b80deef54ac5aff851063dfdb52fcdb4b00a87
Commit-Queue: Keita Suzuki <suzuk...@chromium.org>
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1586900}
Files:
  • M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
  • M tools/metrics/histograms/metadata/page/histograms.xml
Change size: S
Delta: 2 files changed, 21 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Takashi Toyoshima
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I03b80deef54ac5aff851063dfdb52fcdb4b00a87
Gerrit-Change-Number: 7586665
Gerrit-PatchSet: 2
Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages