Separate between HTML streaming and <template for> patching [chromium/src : main]

0 views
Skip to first unread message

Philip Jägenstedt (Gerrit)

unread,
Mar 12, 2026, 5:52:26 AM (19 hours ago) Mar 12
to Noam Rosenthal, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Noam Rosenthal

Philip Jägenstedt voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic411e1af7c5644be3062564683d039d6847427b5
Gerrit-Change-Number: 7657845
Gerrit-PatchSet: 4
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 09:52:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Mar 12, 2026, 5:55:40 AM (19 hours ago) Mar 12
to Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Noam Rosenthal voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic411e1af7c5644be3062564683d039d6847427b5
Gerrit-Change-Number: 7657845
Gerrit-PatchSet: 4
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 09:55:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Mar 12, 2026, 6:00:06 AM (19 hours ago) Mar 12
to Noam Rosenthal, Philip Jägenstedt, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Separate between HTML streaming and <template for> patching

HTML streaming, as well as the new positional methods, receive a
"NewHTMLSettingMethods" runtime flag, and move to domparsing/tentative,
to separate them from the somewhat orthogonal <template for> patching.
Bug: 491743369
Change-Id: Ic411e1af7c5644be3062564683d039d6847427b5
Reviewed-by: Philip Jägenstedt <foo...@chromium.org>
Commit-Queue: Noam Rosenthal <nrose...@google.com>
Cr-Commit-Position: refs/heads/main@{#1598305}
Files:
  • M third_party/blink/renderer/core/dom/child_node.idl
  • M third_party/blink/renderer/core/dom/element.idl
  • M third_party/blink/renderer/core/dom/shadow_root.idl
  • M third_party/blink/renderer/core/html/html_stream.cc
  • M third_party/blink/renderer/core/html/parser/html_construction_site.cc
  • M third_party/blink/renderer/core/html/parser/html_document_parser.cc
  • M third_party/blink/renderer/core/html/parser/html_tree_builder.cc
  • M third_party/blink/renderer/core/trustedtypes/trusted_parser_options.idl
  • M third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
  • A third_party/blink/web_tests/external/wpt/domparsing/tentative/OWNERS
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/positional-methods-with-trusted-types.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/positional-methods.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/resources/util.js
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-append-html-unsafe.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-append-html.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-custom-element.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-defer-async-script.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-run-scripts-option.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-sanitizer.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-unsafe.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-trusted-types-error-in-policy.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-trusted-types-no-createParserOptions.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-trusted-types-no-policy.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-trusted-types-pass-trusted.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-trusted-types-runScripts-cannot-be-turned-on.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-trusted-types-runScripts-off.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-trusted-types-sanitizer.html
  • R third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html.html
Change size: M
Delta: 29 files changed, 42 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Jägenstedt
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic411e1af7c5644be3062564683d039d6847427b5
Gerrit-Change-Number: 7657845
Gerrit-PatchSet: 5
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
open
diffy
satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,
Mar 12, 2026, 7:22:14 AM (17 hours ago) Mar 12
to Chromium LUCI CQ, Noam Rosenthal, Philip Jägenstedt, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58450

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic411e1af7c5644be3062564683d039d6847427b5
Gerrit-Change-Number: 7657845
Gerrit-PatchSet: 5
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 11:22:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages