Jiacheng Guo (Gerrit)

unread,

Jun 9, 2026, 12:54:05 AM (2 days ago) Jun 9

to chromium...@chromium.org, Nate Chapin, Chromium Metrics Reviews, Daniel Cheng, asvitkine...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, schedule...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org

Jiacheng Guo has uploaded the change for review

Commit message

Clean up Blink frame rate throttling feature flags and tests.

Clean up the remaining Blink-side logic, runtime features,
UseCounters, HTML blocking attribute tokens, field trial configs,
enums, histograms, and associated tests for the frame rate throttling
feature.

This CL removes the `RenderBlockingFullFrameRate` runtime feature
and the `kThrottleFrameRateOnInitialization` feature param. It also
marks the associated `BlockingAttributeFullFrameRateToken` UseCounter
as obsolete, removes `full-frame-rate` token parsing and checking from
`BlockingAttribute`, simplifies `Document` and
`RenderBlockingResourceManager` by removing frame-rate-specific
blocking plumbing, deletes `full_frame_rate_blocking_link_test.cc`,
simplifies `render_blocking_element_link_map_test.cc`, and cleans up
the related histograms and field trial testing config.

Bug: 521610226

Change-Id: Ia6869b5a4d9a78045f75d75c2c3e73cbfdbb2dba

Change diff

Change information

Files:

M testing/variations/fieldtrial_testing_config.json
M third_party/blink/common/features.cc
M third_party/blink/public/common/features.h
M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/dom/document.h
M third_party/blink/renderer/core/html/blocking_attribute.cc
M third_party/blink/renderer/core/html/blocking_attribute.h
M third_party/blink/renderer/core/html/blocking_attribute_test.cc
M third_party/blink/renderer/core/html/keywords.json5
M third_party/blink/renderer/core/loader/build.gni
D third_party/blink/renderer/core/loader/full_frame_rate_blocking_link_test.cc
M third_party/blink/renderer/core/loader/render_blocking_element_link_map.h
M third_party/blink/renderer/core/loader/render_blocking_element_link_map_test.cc
M third_party/blink/renderer/core/loader/render_blocking_level.h
M third_party/blink/renderer/core/loader/render_blocking_resource_manager.cc
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M tools/metrics/histograms/metadata/blink/enums.xml
M tools/metrics/histograms/metadata/blink/histograms.xml

Change size: L

Delta: 19 files changed, 17 insertions(+), 382 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vladimir Levin (Gerrit)

unread,

Jun 9, 2026, 1:31:05 PM (2 days ago) Jun 9

to Jiacheng Guo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, schedule...@chromium.org

Attention needed from Jiacheng Guo

Vladimir Levin added 1 comment

File third_party/blink/renderer/core/dom/document.cc

Line 1130, Patchset 2 (Latest): LiveDocumentSet().insert(this);

Vladimir Levin . unresolved

This doesn't seem to be used anywhere other than this insert. Remove?

If it's necessary for something, then it needs to be behind a `#if DCHECK_IS_ON()` macro guard instead of `#ifndef NDEBUG`

Open in Gerrit

Related details

Attention is currently required from:

Jiacheng Guo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jiacheng Guo (Gerrit)

unread,

12:17 AM (10 hours ago) 12:17 AM

to Vladimir Levin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, schedule...@chromium.org

Attention needed from Vladimir Levin

Jiacheng Guo added 1 comment

File third_party/blink/renderer/core/dom/document.cc

Line 1130, Patchset 2 (Latest): LiveDocumentSet().insert(this);

Vladimir Levin . unresolved

This doesn't seem to be used anywhere other than this insert. Remove?
If it's necessary for something, then it needs to be behind a `#if DCHECK_IS_ON()` macro guard instead of `#ifndef NDEBUG`

Jiacheng Guo

The debug only LiveDocumentSet and all its references are currently guarded by `NDEBUG` macro. I've created crbug.com/522516536 for migration and added a TODO in the CL.

Open in Gerrit

Related details

Attention is currently required from:

Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jiacheng Guo (Gerrit)

unread,

1:38 AM (9 hours ago) 1:38 AM

to Vladimir Levin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, schedule...@chromium.org

Attention needed from Vladimir Levin

Jiacheng Guo added 1 comment

File third_party/blink/renderer/core/dom/document.cc

Line 1130, Patchset 2: LiveDocumentSet().insert(this);

Vladimir Levin . unresolved

This doesn't seem to be used anywhere other than this insert. Remove?
If it's necessary for something, then it needs to be behind a `#if DCHECK_IS_ON()` macro guard instead of `#ifndef NDEBUG`

Jiacheng Guo

The debug only LiveDocumentSet and all its references are currently guarded by `NDEBUG` macro. I've created crbug.com/522516536 for migration and added a TODO in the CL.

Jiacheng Guo

Created https://chromium-review.git.corp.google.com/c/chromium/src/+/7924686/2 for migration.

Open in Gerrit

Related details

Attention is currently required from:

Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Clean up Blink frame rate throttling feature flags and tests. [chromium/src : main]

Jiacheng Guo (Gerrit)

Jiacheng Guo has uploaded the change for review

Commit message

Change diff

Change information

Related details

Vladimir Levin (Gerrit)

Vladimir Levin added 1 comment

Related details

Jiacheng Guo (Gerrit)

Jiacheng Guo added 1 comment

Related details

Jiacheng Guo (Gerrit)

Jiacheng Guo added 1 comment

Related details