[net] Decouple NetModule into a standalone build target [chromium/src : main]
0 views
Skip to first unread message
Kenichi Ishibashi (Gerrit)
Jun 9, 2026, 1:27:27 AMJun 9
to Alexis Hétu, Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Alexis Hétu and Sylvain Defresne
Kenichi Ishibashi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kenichi Ishibashi . resolved
The change itself seems reasonable. Can we have README.md in net/base/module and explain that we should keep the contents of the directory minimum.
Related details
Attention is currently required from:
- Alexis Hétu
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
Jun 9, 2026, 4:59:07 AMJun 9
to Alexis Hétu, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Alexis Hétu
Sylvain Defresne voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sylvain Defresne
| Code-Review | +1 |
1 comment
Patchset-level comments
Sylvain Defresne . resolved
lgtm
Related details
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Jun 9, 2026, 12:18:37 PMJun 9
to Sylvain Defresne, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Kenichi Ishibashi and Sylvain Defresne
Alexis Hétu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kenichi Ishibashi . resolved
The change itself seems reasonable. Can we have README.md in net/base/module and explain that we should keep the contents of the directory minimum.
Attention is currently required from:
- Kenichi Ishibashi
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
Jun 9, 2026, 10:12:50 PMJun 9
to Alexis Hétu, Theresa Wellington, Tsuyoshi Horo, Mike West, Etienne Dechamps, Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Alexis Hétu, Etienne Dechamps, Mike West, Sylvain Defresne, Theresa Wellington and Tsuyoshi Horo
Kenichi Ishibashi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alexis Hétu
- Etienne Dechamps
- Mike West
- Sylvain Defresne
- Theresa Wellington
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Jun 10, 2026, 3:42:59 AMJun 10
to Alexis Hétu, Kenichi Ishibashi, Theresa Wellington, Tsuyoshi Horo, Etienne Dechamps, Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Alexis Hétu, Etienne Dechamps, Sylvain Defresne, Theresa Wellington and Tsuyoshi Horo
Mike West voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mike West
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alexis Hétu
- Etienne Dechamps
Etienne Dechamps (Gerrit)
Jun 10, 2026, 3:45:31 AMJun 10
to Alexis Hétu, Etienne Dechamps, Mike West, Kenichi Ishibashi, Theresa Wellington, Tsuyoshi Horo, Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Alexis Hétu, Sylvain Defresne, Theresa Wellington and Tsuyoshi Horo
Etienne Dechamps voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Dechamps
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alexis Hétu
Tsuyoshi Horo (Gerrit)
Jun 10, 2026, 5:08:42 AMJun 10
to Alexis Hétu, Etienne Dechamps, Mike West, Kenichi Ishibashi, Theresa Wellington, Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Alexis Hétu, Sylvain Defresne and Theresa Wellington
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Code-Review | +1 |
1 comment
Patchset-level comments
Tsuyoshi Horo . resolved
lgtm
Related details
Attention is currently required from:
- Alexis Hétu
- Sylvain Defresne
- Theresa Wellington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
Jun 10, 2026, 5:34:45 AMJun 10
to Alexis Hétu, Tsuyoshi Horo, Etienne Dechamps, Mike West, Kenichi Ishibashi, Theresa Wellington, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Alexis Hétu and Theresa Wellington
Sylvain Defresne voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sylvain Defresne
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alexis Hétu
- Theresa Wellington
Theresa Wellington (Gerrit)
Jun 10, 2026, 11:07:37 AM (14 days ago) Jun 10
to Alexis Hétu, Sylvain Defresne, Tsuyoshi Horo, Etienne Dechamps, Mike West, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Attention needed from Alexis Hétu
Theresa Wellington voted and added 1 comment![]( "Open in Gerrit")
Votes added by Theresa Wellington
| Code-Review | +1 |
1 comment
Patchset-level comments
Theresa Wellington . resolved
adding rubber stamp on trivial changes in //chrome/browser/chrome_browser_main.cc and //chrome/renderer/chrome_render_thread_observer.cc
Related details
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Jun 10, 2026, 11:16:37 AM (14 days ago) Jun 10
to Theresa Wellington, Sylvain Defresne, Tsuyoshi Horo, Etienne Dechamps, Mike West, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Alexis Hétu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 10, 2026, 11:29:19 AM (14 days ago) Jun 10
to Alexis Hétu, Theresa Wellington, Sylvain Defresne, Tsuyoshi Horo, Etienne Dechamps, Mike West, Kenichi Ishibashi, chromium...@chromium.org, Peter Beverloo, bnc+...@chromium.org, ios-r...@chromium.org, kinuko+...@chromium.org, loading...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[net] Decouple NetModule into a standalone build target
Extract NetModule and its dependent directory listing
functionality out of the monolithic //net build target into a
dedicated //net/base/module source set.
This modularization enables lightweight consumers to utilize core
//net/base functionality while using assert_no_deps to explicitly
restrict //net/base/module and avoid unneeded resources in iOS app
extensions, for example.
Bug: 517073397
Bypass-Check-License: Files were moved
Change-Id: I5d5f440e7ed82573679f79497661bdcf06a32148
Reviewed-by: Mike West <mk...@chromium.org>
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Reviewed-by: Etienne Dechamps <edec...@google.com>
Reviewed-by: Sylvain Defresne <sdef...@chromium.org>
Commit-Queue: Alexis Hétu <su...@chromium.org>
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Reviewed-by: Theresa Wellington <twell...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1644663}
Files:
- M chrome/browser/chrome_browser_main.cc
- M chrome/renderer/chrome_render_thread_observer.cc
- M components/cronet/android/dependencies.txt
- M content/browser/file_system/file_system_url_loader_factory.cc
- M content/browser/file_system/file_system_url_loader_factory_browsertest.cc
- M content/browser/loader/file_url_loader_factory.cc
- M content/shell/browser/shell_browser_main_parts.cc
- M content/web_test/browser/web_test_browser_main_parts.cc
- M ios/build/config.gni
- M net/BUILD.gn
- M net/base/directory_listing_unittest.cc
- A net/base/module/BUILD.gn
- A net/base/module/README.md
- R net/base/module/directory_listing.cc
- R net/base/module/directory_listing.h
- R net/base/module/net_module.cc
- R net/base/module/net_module.h
- M net/url_request/url_request_unittest.cc
Change size: M
Delta: 18 files changed, 69 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Dechamps, +1 by Theresa Wellington, +1 by Kenichi Ishibashi, +1 by Sylvain Defresne, +1 by Tsuyoshi Horo, +1 by Mike West
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages