Remove aliases for base::DictValue and base::ListValue [chromium/src : main]

0 views
Skip to first unread message

Avi Drissman (Gerrit)

unread,
Jan 27, 2026, 2:38:34 PM (3 days ago) Jan 27
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 22 (Latest):
Avi Drissman . resolved

dcheng: please review; this is strictly mechanical except where noted, so OO-ing is appropriate.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6
Gerrit-Change-Number: 7513889
Gerrit-PatchSet: 22
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Jan 2026 19:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 27, 2026, 6:06:28 PM (3 days ago) Jan 27
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 24 (Latest):
Daniel Cheng . resolved

Though if this ends up being reverted, please separate the removal into a separate CL :)

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6
Gerrit-Change-Number: 7513889
Gerrit-PatchSet: 24
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Jan 2026 23:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 28, 2026, 2:00:42 AM (3 days ago) Jan 28
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Wed, 28 Jan 2026 07:00:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
Jan 28, 2026, 10:04:51 AM (3 days ago) Jan 28
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng

Avi Drissman voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Wed, 28 Jan 2026 15:04:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 28, 2026, 2:38:37 PM (2 days ago) Jan 28
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6
Gerrit-Change-Number: 7513889
Gerrit-PatchSet: 25
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Wed, 28 Jan 2026 19:38:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 28, 2026, 3:55:21 PM (2 days ago) Jan 28
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, webauthn...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6
Gerrit-Change-Number: 7513889
Gerrit-PatchSet: 26
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Wed, 28 Jan 2026 20:55:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 28, 2026, 4:42:46 PM (2 days ago) Jan 28
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, webauthn...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6
Gerrit-Change-Number: 7513889
Gerrit-PatchSet: 27
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Wed, 28 Jan 2026 21:42:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
Jan 29, 2026, 11:39:15 AM (2 days ago) Jan 29
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, webauthn...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng

Avi Drissman voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6
Gerrit-Change-Number: 7513889
Gerrit-PatchSet: 28
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 16:39:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 29, 2026, 1:01:03 PM (2 days ago) Jan 29
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, webauthn...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 18:00:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 29, 2026, 6:58:26 PM (2 days ago) Jan 29
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, webauthn...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Thu, 29 Jan 2026 23:58:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 30, 2026, 1:14:26 AM (yesterday) Jan 30
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, webauthn...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Gerrit-Comment-Date: Fri, 30 Jan 2026 06:14:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 30, 2026, 1:14:44 AM (yesterday) Jan 30
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, webauthn...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng added 1 comment

Patchset-level comments
File-level comment, Patchset 28 (Latest):
Daniel Cheng . resolved

I am just going to manually submit this. The desktop builder is clearly broken in a way unrelated to this CL.

Gerrit-Comment-Date: Fri, 30 Jan 2026 06:14:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 30, 2026, 1:15:11 AM (yesterday) Jan 30
to Avi Drissman, Daniel Cheng, Andrew Rayskiy, Akihiro Ota, James Maclean, Sarah Krakowiak, (Julie)Jeongeun Kim, Mathias Bynens, Simon Hangl, Kevin McNee, Hiroki Nakagawa, Rijubrata Bhaumik, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, derinel+wat...@google.com, webauthn...@chromium.org, cbe-cep-eng...@google.com, tmartino+tran...@chromium.org, joeantonetti+wa...@google.com, yuzo+...@chromium.org, rmcelra...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, sloboda...@chromium.org, oshima...@chromium.org, ios-r...@chromium.org, ajayramamurthy+w...@google.com, marq+...@chromium.org, cros-setti...@google.com, francisjp...@google.com, japhet+...@chromium.org, abigailbk...@google.com, hansberry+wat...@chromium.org, dibyapal+wa...@chromium.org, jonmann+watc...@chromium.org, nektar...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, josiah...@chromium.org, jackshira+wat...@google.com, jshin...@chromium.org, halliwe...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, rrsilva+wat...@google.com, dmurph+watc...@chromium.org, ios-revie...@chromium.org, dtseng...@chromium.org, mek+w...@chromium.org, extension...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, kyungjunle...@google.com, chromotin...@chromium.org, mfoltz+wa...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, shimazu+se...@chromium.org, horo+...@chromium.org, cros-ed...@google.com, chromium-a...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, devtools...@chromium.org, blink-work...@chromium.org, speed-metrics...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, druber...@chromium.org, grt+...@chromium.org, dmurph+wat...@chromium.org, nwoked...@chromium.org, kinuko+ser...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, andysjl...@chromium.org, kinuko...@chromium.org

Daniel Cheng submitted the change

Change information

Commit message:
Remove aliases for base::DictValue and base::ListValue

This removes a few last stragglers as well.
Fixed: 478100525
Cq-Include-Trybots: luci.chromium.try:win-official,mac-official,linux-official,android-official,android-desktop-x64-official
Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6
Auto-Submit: Avi Drissman <a...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1577038}
Files:
  • M PRESUBMIT.py
  • M base/values.h
  • M net/quic/quic_event_logger.cc
  • M net/socket/tls_stream_attempt.cc
Change size: S
Delta: 4 files changed, 3 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6
Gerrit-Change-Number: 7513889
Gerrit-PatchSet: 29
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages