Move AdvanceStringExpecting* helper functions to SegmentedString [chromium/src : main]
0 views
Skip to first unread message
Kent Tamura (Gerrit)
May 17, 2026, 11:20:53 PM (2 days ago) May 17
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Fredrik Söderquist
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
May 18, 2026, 4:27:41 AM (2 days ago) May 18
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Kent Tamura
Fredrik Söderquist voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fredrik Söderquist
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/platform/text/segmented_string.h
Line 300, Patchset 4 (Latest):
inline void AdvanceExpectingIgnoringCase(Fredrik Söderquist . unresolved
Should this be named `...IgnoringAsciiCase` now?
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
May 18, 2026, 8:12:39 PM (2 days ago) May 18
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/platform/text/segmented_string.h
Should this be named `...IgnoringAsciiCase` now?
Kent Tamura
Good point! Done.
I also found the CL description didn't mention that this CL replaced Unicode case-folding with ASCII case-insensitive. Updated the description.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 18, 2026, 8:48:27 PM (2 days ago) May 18
to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/html/parser/html_tokenizer.cc
Insertions: 3, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/renderer/platform/text/segmented_string.h
Insertions: 3, Deletions: 3.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Move AdvanceStringExpecting* helper functions to SegmentedString
This change moves the string-expecting advance methods from being
standalone helper functions to member functions of SegmentedString.
Additionally, it optimizes these methods for non-DCHECK builds. By
moving the character comparison into a DCHECK, we avoid accessing the
underlying string content and performing comparisons in release builds,
where we only need to advance the SegmentedString.
This changes AdvanceStringExpectingIgnoringCase() so that it applies
ASCII case-insensitive matching, instead of Unicode case-insensitive
matching. This is not a behavior change because all expected strings
are ASCII, and no `k`, which matches to U+212A.
Change-Id: I810883690db24bbad241a39c4aa89636837c8322
Reviewed-by: Fredrik Söderquist <f...@opera.com>
Commit-Queue: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1632535}
Files:
- M third_party/blink/renderer/core/html/parser/html_tokenizer.cc
- M third_party/blink/renderer/core/html/parser/markup_tokenizer_inlines.h
- M third_party/blink/renderer/platform/text/segmented_string.h
Change size: M
Delta: 3 files changed, 32 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fredrik Söderquist
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
May 19, 2026, 4:19:27 AM (23 hours ago) May 19
to Chromium LUCI CQ, Kent Tamura, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Fredrik Söderquist added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/text/segmented_string.h
Line 300, Patchset 4:
inline void AdvanceExpectingIgnoringCase(Fredrik Söderquist . resolved
Kent TamuraShould this be named `...IgnoringAsciiCase` now?
Good point! Done.
I also found the CL description didn't mention that this CL replaced Unicode case-folding with ASCII case-insensitive. Updated the description.
Fredrik Söderquist
👍
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages