Move rather than copying the encoded page state when possible [chromium/src : main]

0 views

Skip to first unread message

Daniel Cheng (Gerrit)

unread,

Jan 29, 2026, 8:06:20 PM (yesterday) Jan 29

to Daniel Cheng, Alex Moshchuk, Nate Chapin, Olga Gerchikov, Menard, Alexis, AyeAye, Chromium LUCI CQ, alexmo...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, blink-revie...@chromium.org, gavinp...@chromium.org, android-web...@chromium.org, creis...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, blink-re...@chromium.org

Attention needed from Alex Moshchuk

Daniel Cheng added 1 comment

File content/browser/renderer_host/navigation_request.cc

Line 3401, Patchset 1: std::move(commit_params_->page_state));

Daniel Cheng . unresolved

I'm kind of uncertain about this particular change. It's really an obfuscated way of saying "clear this if it's not empty"... so we could just write `commit_params_->page_state.empty()`. But that's also kind of a layering violation... so I just left it as-is and wrote a long comment.

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Moshchuk (Gerrit)

unread,

10:42 PM (1 hour ago) 10:42 PM

to Daniel Cheng, Nate Chapin, Olga Gerchikov, Menard, Alexis, AyeAye, Chromium LUCI CQ, alexmo...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, blink-revie...@chromium.org, gavinp...@chromium.org, android-web...@chromium.org, creis...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, blink-re...@chromium.org

Attention needed from Daniel Cheng

Alex Moshchuk voted and added 2 comments

Votes added by Alex Moshchuk

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alex Moshchuk . resolved

LGTM

File content/browser/renderer_host/navigation_request.cc

Line 3401, Patchset 1: std::move(commit_params_->page_state));

Daniel Cheng . resolved

I'm kind of uncertain about this particular change. It's really an obfuscated way of saying "clear this if it's not empty"... so we could just write `commit_params_->page_state.empty()`. But that's also kind of a layering violation... so I just left it as-is and wrote a long comment.

Alex Moshchuk

Yeah, agreed with your assessment. The new comment helps clarify what's going on, at least.