Delete V8 extensions registration infrastructure [chromium/src : main]
0 views
Skip to first unread message
Jochen Eisinger (Gerrit)
Jul 21, 2026, 6:00:09 AM (10 days ago) Jul 21
to Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Kentaro Hara
Jochen Eisinger voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jochen Eisinger
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Jul 21, 2026, 7:05:46 AM (10 days ago) Jul 21
to Jochen Eisinger, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Jochen Eisinger
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jochen Eisinger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jochen Eisinger (Gerrit)
Jul 21, 2026, 7:07:32 AM (10 days ago) Jul 21
to Marc Treib, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Jochen Eisinger and Marc Treib
Jochen Eisinger voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jochen Eisinger
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jochen Eisinger
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jochen Eisinger (Gerrit)
Jul 21, 2026, 7:08:54 AM (10 days ago) Jul 21
to Dominic Battré, Camille Lamy, Marc Treib, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Camille Lamy, Dominic Battré and Marc Treib
Jochen Eisinger added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Camille Lamy
- Dominic Battré
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jul 21, 2026, 7:22:44 AM (10 days ago) Jul 21
to Jochen Eisinger, Marc Treib, Dominic Battré, Camille Lamy, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Camille Lamy, Dominic Battré and Jochen Eisinger
Marc Treib voted and added 2 comments![]( "Open in Gerrit")
Votes added by Marc Treib
| Code-Review | +1 |
2 comments
Patchset-level comments
Marc Treib . resolved
\o/
File chrome/renderer/chrome_content_renderer_client.cc
Line 1507, Patchset 4 (Latest):
if (url::Origin::Create(script_url).scheme() ==Marc Treib . unresolved
Is this different vs just getting the scheme directly from `script_url.scheme()`?
Related details
Attention is currently required from:
- Camille Lamy
- Dominic Battré
- Jochen Eisinger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Jul 21, 2026, 8:22:27 AM (10 days ago) Jul 21
to Jochen Eisinger, Marc Treib, Dominic Battré, Camille Lamy, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Camille Lamy, Dominic Battré and Jochen Eisinger
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Dominic Battré (Gerrit)
Jul 21, 2026, 8:28:34 AM (10 days ago) Jul 21
to Jochen Eisinger, Kouhei Ueno, Marc Treib, Camille Lamy, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Camille Lamy and Jochen Eisinger
Dominic Battré voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominic Battré
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Camille Lamy
- Jochen Eisinger
Jochen Eisinger (Gerrit)
Jul 21, 2026, 9:23:12 AM (10 days ago) Jul 21
to Dominic Battré, Kouhei Ueno, Marc Treib, Camille Lamy, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Camille Lamy
Jochen Eisinger added 1 comment![]( "Open in Gerrit")
File chrome/renderer/chrome_content_renderer_client.cc
Line 1507, Patchset 4 (Latest):
if (url::Origin::Create(script_url).scheme() ==Marc Treib . resolved
Is this different vs just getting the scheme directly from `script_url.scheme()`?
Jochen Eisinger
Yes, script_url.scheme() wouldn't unwrap nested inner origins such as blob:chrome-extension://
Related details
Attention is currently required from:
- Camille Lamy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camille Lamy (Gerrit)
Jul 22, 2026, 9:15:14 AM (9 days ago) Jul 22
to Jochen Eisinger, Dominic Battré, Kouhei Ueno, Marc Treib, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Jochen Eisinger
Camille Lamy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Camille Lamy
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jochen Eisinger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jochen Eisinger (Gerrit)
Jul 30, 2026, 1:39:43 PM (16 hours ago) Jul 30
to Camille Lamy, Dominic Battré, Kouhei Ueno, Marc Treib, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Jochen Eisinger voted Commit-Queue+2![]( "Open in Gerrit")
Chromium LUCI CQ (Gerrit)
Jul 30, 2026, 3:29:23 PM (14 hours ago) Jul 30
to Jochen Eisinger, Camille Lamy, Dominic Battré, Kouhei Ueno, Marc Treib, Kentaro Hara, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kouhei...@chromium.org, loading...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Delete V8 extensions registration infrastructure
Remove legacy v8::Extension registration and loading pipeline end-to-end.
TAG=agy
CONV=9fc3b0ac-a815-428d-a2de-1f835441e8d4
Bug: 40347662
Change-Id: Ic72da940c2bb7410141b52e3410b2763a4b1aa30
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Dominic Battré <bat...@chromium.org>
Commit-Queue: Jochen Eisinger <joc...@chromium.org>
Reviewed-by: Camille Lamy <cl...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Marc Treib <tr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1671319}
Files:
- M PRESUBMIT.py
- M chrome/renderer/chrome_content_renderer_client.cc
- M chrome/renderer/chrome_content_renderer_client.h
- M chrome/test/base/chrome_render_view_test.cc
- M content/public/renderer/content_renderer_client.cc
- M content/public/renderer/content_renderer_client.h
- M content/renderer/renderer_blink_platform_impl.cc
- M content/renderer/renderer_blink_platform_impl.h
- M third_party/blink/public/BUILD.gn
- M third_party/blink/public/platform/platform.h
- D third_party/blink/public/web/web_script_controller.h
- M third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc
- M third_party/blink/renderer/bindings/core/v8/script_controller.cc
- M third_party/blink/renderer/bindings/core/v8/script_controller.h
- M third_party/blink/renderer/bindings/core/v8/shadow_realm_context.cc
- M third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
- M third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.h
- M third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc
- M third_party/blink/renderer/bindings/modules/v8/v8_context_snapshot_impl.cc
- M third_party/blink/renderer/bindings/modules/v8/v8_context_snapshot_impl.h
- M third_party/blink/renderer/core/execution_context/execution_context.h
- M third_party/blink/renderer/core/exported/build.gni
- D third_party/blink/renderer/core/exported/web_script_controller.cc
- M third_party/blink/renderer/core/frame/local_dom_window.cc
- M third_party/blink/renderer/core/frame/local_dom_window.h
- M third_party/blink/renderer/core/frame/local_frame_client.h
- M third_party/blink/renderer/core/frame/local_frame_client_impl.cc
- M third_party/blink/renderer/core/frame/local_frame_client_impl.h
- M third_party/blink/renderer/core/loader/empty_clients.h
- M third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
- M third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
Change size: L
Delta: 31 files changed, 17 insertions(+), 234 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kentaro Hara, +1 by Kouhei Ueno, +1 by Marc Treib, +1 by Camille Lamy, +1 by Dominic Battré
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages