Revert "[soft navs] Re-enable improved LargestContentfulPaint UKM test." [chromium/src : main]

0 views
Skip to first unread message

Nidhi Jaju (Gerrit)

unread,
Jul 28, 2025, 11:15:46 PMJul 28
to Rubber Stamper, Michal Mocny, Shunya Shishido, Chromium LUCI CQ, Annie Sullivan, Johannes Henkel, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Johannes Henkel, Michal Mocny and Shunya Shishido

Nidhi Jaju voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Annie Sullivan
  • Johannes Henkel
  • Michal Mocny
  • Shunya Shishido
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6f085477328313706ab253da612197299f4f905
Gerrit-Change-Number: 6796469
Gerrit-PatchSet: 1
Gerrit-Owner: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Johannes Henkel <joha...@chromium.org>
Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
Gerrit-Attention: Annie Sullivan <sull...@chromium.org>
Gerrit-Attention: Johannes Henkel <joha...@chromium.org>
Gerrit-Comment-Date: Tue, 29 Jul 2025 03:15:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Jul 28, 2025, 11:16:15 PMJul 28
to Nidhi Jaju, Michal Mocny, Shunya Shishido, Chromium LUCI CQ, Annie Sullivan, Johannes Henkel, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Johannes Henkel, Michal Mocny and Shunya Shishido

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Annie Sullivan
  • Johannes Henkel
  • Michal Mocny
  • Shunya Shishido
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If6f085477328313706ab253da612197299f4f905
    Gerrit-Change-Number: 6796469
    Gerrit-PatchSet: 1
    Gerrit-Owner: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Johannes Henkel <joha...@chromium.org>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
    Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Attention: Annie Sullivan <sull...@chromium.org>
    Gerrit-Attention: Johannes Henkel <joha...@chromium.org>
    Gerrit-Comment-Date: Tue, 29 Jul 2025 03:16:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 28, 2025, 11:16:36 PMJul 28
    to Nidhi Jaju, Rubber Stamper, Michal Mocny, Shunya Shishido, Annie Sullivan, Johannes Henkel, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[soft navs] Re-enable improved LargestContentfulPaint UKM test."

    This reverts commit 5375726a6ef855c67d6eb7c99af011f0be1526a6.

    Reason for revert: Causing consistent failures for SoftNavgationTest.*LargestContentPaint
    i.e. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/75083/overview

    Bug: 425398556, 382245480
    Original change's description:
    > [soft navs] Re-enable improved LargestContentfulPaint UKM test.
    >
    > This change splits the LargestContentfulPaint into two tests, one for
    > image lcp, and one for text. It uses a new, simpler test file,
    > soft_navigation_basics.html, which does not have javascript except the
    > simple stuff to make the page work.
    >
    > Bug: 425398556, 382245480
    > Change-Id: I6ad9b84c9fbdbd7ab9f859376a0d532c06475721
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6656159
    > Reviewed-by: Shunya Shishido <sisid...@chromium.org>
    > Commit-Queue: Johannes Henkel <joha...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1493222}
    Bug: 425398556, 382245480
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: If6f085477328313706ab253da612197299f4f905
    Owners-Override: Nidhi Jaju <nidh...@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Auto-Submit: Nidhi Jaju <nidh...@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1493259}
    Files:
    • D chrome/browser/page_load_metrics/integration_tests/data/soft_navigation_basics.html
    • M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
    Change size: L
    Delta: 2 files changed, 134 insertions(+), 234 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If6f085477328313706ab253da612197299f4f905
    Gerrit-Change-Number: 6796469
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Johannes Henkel (Gerrit)

    unread,
    Jul 29, 2025, 1:32:39 PMJul 29
    to Nidhi Jaju, Chromium LUCI CQ, Rubber Stamper, Michal Mocny, Shunya Shishido, Annie Sullivan, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org

    Johannes Henkel has created a revert of this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: revert
    satisfied_requirement
    open
    diffy

    Johannes Henkel (Gerrit)

    unread,
    Sep 11, 2025, 2:25:24 PM (6 days ago) Sep 11
    to Nidhi Jaju, Chromium LUCI CQ, Rubber Stamper, Michal Mocny, Shunya Shishido, Annie Sullivan, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    satisfied_requirement
    open
    diffy

    Johannes Henkel (Gerrit)

    unread,
    Sep 11, 2025, 3:56:35 PM (6 days ago) Sep 11
    to Nidhi Jaju, Chromium LUCI CQ, Rubber Stamper, Michal Mocny, Shunya Shishido, Annie Sullivan, chromium...@chromium.org, Code Review Nudger, AyeAye, speed-metrics...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages