[soft navs] Small cleanups to integration test. [chromium/src : main]
0 views
Skip to first unread message
Johannes Henkel (Gerrit)
Apr 1, 2026, 7:02:39 PM (2 days ago) Apr 1
to Michal Mocny, Scott Haseley, Annie Sullivan, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Michal Mocny and Scott Haseley
Johannes Henkel voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Annie Sullivan
- Michal Mocny
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Apr 2, 2026, 10:43:09 AM (yesterday) Apr 2
to Johannes Henkel, Chromium LUCI CQ, Scott Haseley, Annie Sullivan, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan, Johannes Henkel and Scott Haseley
Michal Mocny voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Annie Sullivan
- Johannes Henkel
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Apr 2, 2026, 11:38:58 AM (yesterday) Apr 2
to Scott Haseley, Annie Sullivan, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 11:42:03 AM (yesterday) Apr 2
to Johannes Henkel, Scott Haseley, Annie Sullivan, Michal Mocny, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[soft navs] Small cleanups to integration test.
These are in preparation for adding SoftNavigationCount to
bfcache restores (and testing it here).
- Make the URL set by the Javascript easier to guess in a test
(page.html -> soft_navigation_basics.html).
- Make registering the back button handler optional,
since we only need this one for actually testing back button
support, but don't want it for the bfcache restore test (for example).
Bug: 496664486
Change-Id: I1efe9a490915dc513bd11761edac9193ac2701de
Reviewed-by: Michal Mocny <mmo...@chromium.org>
Commit-Queue: Johannes Henkel <joha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609241}
Files:
- M chrome/browser/page_load_metrics/integration_tests/data/soft_navigation_basics.html
- M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
Change size: S
Delta: 2 files changed, 26 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michal Mocny
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages