navigation.activation.from should not expose initial about:blank [chromium/src : main]

0 views
Skip to first unread message

Rakina Zata Amni (Gerrit)

unread,
Jun 8, 2026, 10:36:09 PM (3 days ago) Jun 8
to Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Noam Rosenthal

Rakina Zata Amni voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d3bffc13d0ca43c1ca18b0f5e4ecd4ff659267b
Gerrit-Change-Number: 7903147
Gerrit-PatchSet: 5
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 02:35:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Jun 11, 2026, 4:02:00 AM (24 hours ago) Jun 11
to Rakina Zata Amni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org

Noam Rosenthal voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d3bffc13d0ca43c1ca18b0f5e4ecd4ff659267b
Gerrit-Change-Number: 7903147
Gerrit-PatchSet: 5
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Jun 2026 08:01:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 11, 2026, 5:07:30 AM (23 hours ago) Jun 11
to Noam Rosenthal, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
navigation.activation.from should not expose initial about:blank

The modified test here makes it equivalent to upstream WPT.

See spec:
https://html.spec.whatwg.org/multipage/browsing-the-web.html#updating-the-document%3Anav-activation-old-entry
Bug: 518880805
Change-Id: I8d3bffc13d0ca43c1ca18b0f5e4ecd4ff659267b
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Commit-Queue: Noam Rosenthal <nrose...@google.com>
Cr-Commit-Position: refs/heads/main@{#1645210}
Files:
  • M content/browser/renderer_host/navigation_controller_impl.cc
  • M third_party/blink/web_tests/external/wpt/navigation-api/navigation-activation/activation-initial-about-blank.html
Change size: XS
Delta: 2 files changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Rakina Zata Amni
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d3bffc13d0ca43c1ca18b0f5e4ecd4ff659267b
Gerrit-Change-Number: 7903147
Gerrit-PatchSet: 6
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages