[DBSC] Allow session registration by default and remove origin trials [chromium/src : main]

0 views
Skip to first unread message

Alex Ilin (Gerrit)

unread,
9:00 AM (14 hours ago) 9:00 AM
to Alex Ilin, Daniel Rubery, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, druber...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Rubery

Alex Ilin added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alex Ilin . resolved

Hey Daniel, could you PTAL at this CL?

I'm not sure whether we want to keep the flag configurable from the renderer. We won't strictly need that to solve the PAC problem. At the same time, this might be helpful in the future, so I'm leaning towards keeping the mojo plumbing.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Rubery
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0f852c9a7b15974d1eaaa4810b6bf72784d45502
Gerrit-Change-Number: 7660660
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Ilin <alex...@chromium.org>
Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Daniel Rubery <dru...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 13:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Rubery (Gerrit)

unread,
12:27 PM (11 hours ago) 12:27 PM
to Alex Ilin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, druber...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Ilin

Daniel Rubery voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Ilin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f852c9a7b15974d1eaaa4810b6bf72784d45502
    Gerrit-Change-Number: 7660660
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Alex Ilin <alex...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 16:27:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Ilin (Gerrit)

    unread,
    12:50 PM (11 hours ago) 12:50 PM
    to Alex Ilin, Kenichi Ishibashi, Takashi Toyoshima, Daniel Rubery, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, druber...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Kenichi Ishibashi and Takashi Toyoshima

    Alex Ilin added 1 comment

    Patchset-level comments
    Alex Ilin . resolved

    Removing overlapping reviewers, sorry for the noise.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kenichi Ishibashi
    • Takashi Toyoshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f852c9a7b15974d1eaaa4810b6bf72784d45502
    Gerrit-Change-Number: 7660660
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 16:49:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Ilin (Gerrit)

    unread,
    12:52 PM (10 hours ago) 12:52 PM
    to Alex Ilin, Arthur Sonzogni, Kenichi Ishibashi, Takashi Toyoshima, Daniel Rubery, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, druber...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Arthur Sonzogni, Kenichi Ishibashi and Takashi Toyoshima

    Alex Ilin added 1 comment

    Patchset-level comments
    Alex Ilin . resolved

    Oops, overlap again

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Arthur Sonzogni
    • Kenichi Ishibashi
    • Takashi Toyoshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f852c9a7b15974d1eaaa4810b6bf72784d45502
    Gerrit-Change-Number: 7660660
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 16:52:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Ilin (Gerrit)

    unread,
    12:53 PM (10 hours ago) 12:53 PM
    to Alex Ilin, Daniel Cheng, Arthur Sonzogni, Kenichi Ishibashi, Takashi Toyoshima, Daniel Rubery, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, druber...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Arthur Sonzogni, Daniel Cheng, Kenichi Ishibashi and Takashi Toyoshima

    Alex Ilin added 1 comment

    Patchset-level comments
    Alex Ilin . resolved

    +@dch...@chromium.org for `third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py`

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Arthur Sonzogni
    • Daniel Cheng
    • Kenichi Ishibashi
    • Takashi Toyoshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f852c9a7b15974d1eaaa4810b6bf72784d45502
    Gerrit-Change-Number: 7660660
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 16:53:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Arthur Sonzogni (Gerrit)

    unread,
    12:57 PM (10 hours ago) 12:57 PM
    to Alex Ilin, Daniel Cheng, Kenichi Ishibashi, Takashi Toyoshima, Daniel Rubery, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, druber...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Alex Ilin, Daniel Cheng, Kenichi Ishibashi and Takashi Toyoshima

    Arthur Sonzogni voted and added 1 comment

    Votes added by Arthur Sonzogni

    Code-Review+1

    1 comment

    Patchset-level comments
    Arthur Sonzogni . resolved
    third_party/blink/common/origin_trials/navigation_origin_trial_features.cc
     LGTM.
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Ilin
    Gerrit-Attention: Alex Ilin <alex...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 16:56:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    2:32 PM (9 hours ago) 2:32 PM
    to Alex Ilin, Daniel Cheng, Arthur Sonzogni, Kenichi Ishibashi, Takashi Toyoshima, Daniel Rubery, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, druber...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Alex Ilin, Kenichi Ishibashi and Takashi Toyoshima

    Daniel Cheng voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Ilin
    • Kenichi Ishibashi
    • Takashi Toyoshima
    Gerrit-Comment-Date: Thu, 12 Mar 2026 18:31:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages