Allow mixed content for cast android builds. [chromium/src : main]
0 views
Skip to first unread message
Sandeep Vijayasekar (Gerrit)
Sep 11, 2025, 2:12:54 AM (9 days ago) Sep 11
to Nate Chapin, AyeAye, gavinp...@chromium.org, blink-...@chromium.org, loading...@chromium.org
Sandeep Vijayasekar abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sandeep Vijayasekar (Gerrit)
Sep 11, 2025, 2:13:04 AM (9 days ago) Sep 11
to Nate Chapin, AyeAye, Chromium LUCI CQ, loading...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
Sandeep Vijayasekar abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simeon Anfinrud (Gerrit)
Sep 11, 2025, 3:01:35 AM (8 days ago) Sep 11
to Sandeep Vijayasekar, Nate Chapin, AyeAye, Antonio Rivera, Chromium LUCI CQ, Takashi Toyoshima, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Sandeep Vijayasekar and Takashi Toyoshima
Simeon Anfinrud added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/loader/mixed_content_checker.cc
Line 513, Patchset 2 (Latest):
#if (BUILDFLAG(IS_FUCHSIA) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_ANDROID)) && \
BUILDFLAG(ENABLE_CAST_RECEIVER)Simeon Anfinrud . unresolved
should this whole expression just be `BUILDFLAG(ENABLE_CAST_RECEIVER)`? I don't think we have the cast receiver enabled on any OSes that aren't one of fuchsia, linux, or android.
Related details
Attention is currently required from:
- Sandeep Vijayasekar
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sandeep Vijayasekar (Gerrit)
Sep 11, 2025, 3:33:07 AM (8 days ago) Sep 11
to Nate Chapin, AyeAye, Antonio Rivera, Chromium LUCI CQ, Takashi Toyoshima, Simeon Anfinrud, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Simeon Anfinrud and Takashi Toyoshima
Sandeep Vijayasekar added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/loader/mixed_content_checker.cc
Line 513, Patchset 2:
#if (BUILDFLAG(IS_FUCHSIA) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_ANDROID)) && \
BUILDFLAG(ENABLE_CAST_RECEIVER)Simeon Anfinrud . resolved
should this whole expression just be `BUILDFLAG(ENABLE_CAST_RECEIVER)`? I don't think we have the cast receiver enabled on any OSes that aren't one of fuchsia, linux, or android.
Attention is currently required from:
- Simeon Anfinrud
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
Sep 11, 2025, 4:15:35 AM (8 days ago) Sep 11
to Sandeep Vijayasekar, Nate Chapin, AyeAye, Antonio Rivera, Chromium LUCI CQ, Simeon Anfinrud, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Sandeep Vijayasekar and Simeon Anfinrud
Takashi Toyoshima added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/loader/mixed_content_checker.cc
Line 514, Patchset 3 (Latest):
// Fuchsia WebEngine can be configured to allow loading Mixed Content fromTakashi Toyoshima . unresolved
Can you update this comment?
This explains why this is needed for Fhchsia WebEngine, but now this is a common problem for the cast receiver supporting systems?
Related details
Attention is currently required from:
- Sandeep Vijayasekar
- Simeon Anfinrud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sandeep Vijayasekar (Gerrit)
Sep 11, 2025, 8:44:02 PM (8 days ago) Sep 11
to Nate Chapin, AyeAye, Antonio Rivera, Chromium LUCI CQ, Takashi Toyoshima, Simeon Anfinrud, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Simeon Anfinrud and Takashi Toyoshima
Sandeep Vijayasekar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sandeep Vijayasekar
| Commit-Queue | +1 |
1 comment
File third_party/blink/renderer/core/loader/mixed_content_checker.cc
Line 514, Patchset 3:
// Fuchsia WebEngine can be configured to allow loading Mixed Content fromTakashi Toyoshima . resolved
Can you update this comment?
This explains why this is needed for Fhchsia WebEngine, but now this is a common problem for the cast receiver supporting systems?
Sandeep Vijayasekar
Done. I think as more cast receivers updated to a newer web runtime, they also started facing this issue.
Related details
Attention is currently required from:
- Simeon Anfinrud
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
Sep 12, 2025, 4:08:33 AM (7 days ago) Sep 12
to Sandeep Vijayasekar, Nate Chapin, AyeAye, Antonio Rivera, Chromium LUCI CQ, Simeon Anfinrud, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Sandeep Vijayasekar and Simeon Anfinrud
Takashi Toyoshima voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Sandeep Vijayasekar
- Simeon Anfinrud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sandeep Vijayasekar (Gerrit)
Sep 12, 2025, 12:24:06 PM (7 days ago) Sep 12
to Takashi Toyoshima, Nate Chapin, AyeAye, Antonio Rivera, Chromium LUCI CQ, Simeon Anfinrud, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Simeon Anfinrud
Sandeep Vijayasekar voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Simeon Anfinrud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 12, 2025, 12:28:04 PM (7 days ago) Sep 12
to Sandeep Vijayasekar, Takashi Toyoshima, Nate Chapin, AyeAye, Antonio Rivera, Simeon Anfinrud, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Allow mixed content for cast android builds.
Bug: internal 444305869
test: cast local file to mediashell
Change-Id: Ia8097cb34b1110c95d16b45306ee69806b97d5fc
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Commit-Queue: Sandeep Vijayasekar <sa...@google.com>
Cr-Commit-Position: refs/heads/main@{#1514912}
Files:
- M third_party/blink/renderer/core/loader/mixed_content_checker.cc
- M third_party/blink/renderer/core/loader/mixed_content_checker_test.cc
Change size: S
Delta: 2 files changed, 6 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Takashi Toyoshima
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages