[refactor] Update callers to use StyleRef when appropriate. [chromium/src : main]

0 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
2:29 PM (7 hours ago) 2:29 PM
to David Grogan, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Daniel Cheng, Olga Gerchikov, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from David Grogan

Ian Kilpatrick voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Grogan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id373b877fce237a1b88186b3206060668345b376
Gerrit-Change-Number: 7727861
Gerrit-PatchSet: 8
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: David Grogan <dgr...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 18:29:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Grogan (Gerrit)

unread,
3:22 PM (6 hours ago) 3:22 PM
to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Daniel Cheng, Olga Gerchikov, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick

David Grogan voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id373b877fce237a1b88186b3206060668345b376
    Gerrit-Change-Number: 7727861
    Gerrit-PatchSet: 8
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 19:22:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    3:47 PM (5 hours ago) 3:47 PM
    to Ian Kilpatrick, David Grogan, Akihiro Ota, Menard, Alexis, chromium...@chromium.org, Daniel Cheng, Olga Gerchikov, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [refactor] Update callers to use StyleRef when appropriate.

    This patch switches callers of LayoutObject::Style() to StyleRef(). It
    rewrites cases:
     - Style()-> to StyleRef(). (didn't check nullptr).
     - *Style() to StyleRef(). (pointer to reference).

    This addresses roughly 1/2 the callers of Style().

    Eventually I'll rename Style() to StylePointer() (or similar) and
    StyleRef() to just Style() as most callers should use the ref variant
    (only layout-tree callsites should really be using the pointer variant).

    Assisted by gemini.

    There should be no behaviour change.
    Change-Id: Id373b877fce237a1b88186b3206060668345b376
    Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
    Auto-Submit: Ian Kilpatrick <ikilp...@chromium.org>
    Reviewed-by: David Grogan <dgr...@chromium.org>
    Commit-Queue: David Grogan <dgr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1609912}
    Files:
    • M third_party/blink/renderer/core/animation/compositor_animations.cc
    • M third_party/blink/renderer/core/css/css_paint_value_test.cc
    • M third_party/blink/renderer/core/css/font_display_auto_lcp_align_test.cc
    • M third_party/blink/renderer/core/css/style_engine.cc
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/core/dom/element_test.cc
    • M third_party/blink/renderer/core/dom/layout_tree_builder_traversal.cc
    • M third_party/blink/renderer/core/dom/scroll_marker_group_data.cc
    • M third_party/blink/renderer/core/dom/scroll_marker_pseudo_element.cc
    • M third_party/blink/renderer/core/dom/text.cc
    • M third_party/blink/renderer/core/editing/commands/composite_edit_command.cc
    • M third_party/blink/renderer/core/editing/commands/delete_selection_command.cc
    • M third_party/blink/renderer/core/editing/commands/editing_commands_utilities.cc
    • M third_party/blink/renderer/core/editing/commands/insert_line_break_command.cc
    • M third_party/blink/renderer/core/editing/commands/insert_paragraph_separator_command.cc
    • M third_party/blink/renderer/core/editing/commands/replace_selection_command.cc
    • M third_party/blink/renderer/core/editing/editing_utilities.cc
    • M third_party/blink/renderer/core/editing/element_inner_text.cc
    • M third_party/blink/renderer/core/editing/iterators/fully_clipped_state_stack.cc
    • M third_party/blink/renderer/core/editing/iterators/simplified_backwards_text_iterator.cc
    • M third_party/blink/renderer/core/editing/iterators/text_iterator.cc
    • M third_party/blink/renderer/core/editing/iterators/text_iterator_text_node_handler.cc
    • M third_party/blink/renderer/core/editing/iterators/text_iterator_text_state.cc
    • M third_party/blink/renderer/core/editing/serializers/html_interchange.cc
    • M third_party/blink/renderer/core/editing/serializers/serialization.cc
    • M third_party/blink/renderer/core/editing/visible_units.cc
    • M third_party/blink/renderer/core/editing/visible_units_paragraph.cc
    • M third_party/blink/renderer/core/frame/frame.cc
    • M third_party/blink/renderer/core/frame/frame_content_as_text.cc
    • M third_party/blink/renderer/core/frame/frame_serializer.cc
    • M third_party/blink/renderer/core/frame/web_frame_test.cc
    • M third_party/blink/renderer/core/html/forms/html_select_element.cc
    • M third_party/blink/renderer/core/html/forms/listed_element.cc
    • M third_party/blink/renderer/core/html/forms/text_control_element.cc
    • M third_party/blink/renderer/core/html/html_anchor_element.cc
    • M third_party/blink/renderer/core/input/event_handler_test.cc
    • M third_party/blink/renderer/core/input/mouse_event_manager_test.cc
    • M third_party/blink/renderer/core/input/scroll_manager.cc
    • M third_party/blink/renderer/core/layout/block_node.cc
    • M third_party/blink/renderer/core/layout/inline/abstract_inline_text_box.cc
    • M third_party/blink/renderer/core/layout/inline/inline_layout_algorithm_test.cc
    • M third_party/blink/renderer/core/layout/inline/inline_node.cc
    • M third_party/blink/renderer/core/layout/inline_layout_test.cc
    • M third_party/blink/renderer/core/layout/layout_box.cc
    • M third_party/blink/renderer/core/layout/layout_object.cc
    • M third_party/blink/renderer/core/layout/layout_object.h
    • M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
    • M third_party/blink/renderer/core/layout/scroll_anchor.cc
    • M third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc
    • M third_party/blink/renderer/core/layout/table/layout_table.cc
    • M third_party/blink/renderer/core/layout/table/layout_table_column.cc
    • M third_party/blink/renderer/core/loader/render_blocking_resource_manager_test.cc
    • M third_party/blink/renderer/core/page/drag_controller.cc
    • M third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
    • M third_party/blink/renderer/core/page/spatial_navigation.cc
    • M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • M third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
    • M third_party/blink/renderer/core/paint/timing/image_element_timing_test.cc
    • M third_party/blink/renderer/core/scroll/scroll_into_view_util.cc
    • M third_party/blink/renderer/core/scroll/scrollable_area.cc
    • M third_party/blink/renderer/modules/accessibility/ax_block_flow_iterator.cc
    • M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
    • M third_party/blink/renderer/modules/content_extraction/ai_page_content_agent.cc
    Change size: L
    Delta: 63 files changed, 140 insertions(+), 134 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by David Grogan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id373b877fce237a1b88186b3206060668345b376
    Gerrit-Change-Number: 7727861
    Gerrit-PatchSet: 9
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages