Restrict script injection in MIME handler host document to its handler [chromium/src : main]

0 views
Skip to first unread message

gwsq (Gerrit)

unread,
7:22 AM (4 hours ago) 7:22 AM
to Maksim Sisov, Chromium IPC Reviews, Nate Chapin, Devlin Cronin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, loading...@chromium.org, creis...@chromium.org, navigation...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org
Attention needed from Devlin Cronin and Nasko Oskov

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: na...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): na...@chromium.org

Note: IPC gwsq added no new reviewers; existing reviewers satisfied requirements!

Reviewer source(s):
na...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
  • Nasko Oskov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I79fe5e9ef96b80335e3a2960f6d26678e5ea6d02
Gerrit-Change-Number: 8054045
Gerrit-PatchSet: 11
Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Attention: Nasko Oskov <na...@chromium.org>
Gerrit-Comment-Date: Thu, 20 Aug 2026 11:22:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages