Parameterize subresource filter tests for v4/v5 [chromium/src : main]

0 views
Skip to first unread message

thefrog (Gerrit)

unread,
Aug 19, 2026, 12:51:22 PM (23 hours ago) Aug 19
to Charles Harrison, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org
Attention needed from Charles Harrison

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Harrison
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib79817dc25897aeacfc665bd8fc58ed8685065a5
Gerrit-Change-Number: 8263641
Gerrit-PatchSet: 4
Gerrit-Owner: thefrog <the...@chromium.org>
Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
Gerrit-Reviewer: thefrog <the...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 16:51:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

thefrog (Gerrit)

unread,
Aug 19, 2026, 12:56:27 PM (23 hours ago) Aug 19
to Simon Pelchat, Charles Harrison, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org
Attention needed from Charles Harrison and Simon Pelchat

thefrog added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
thefrog . resolved

@spel...@chromium.org: please review chrome/browser/navigation_predictor/navigation_predictor_preconnect_client_browsertest.cc
@cshar...@chromium.org: please review the rest of the CL

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Harrison
  • Simon Pelchat
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib79817dc25897aeacfc665bd8fc58ed8685065a5
Gerrit-Change-Number: 8263641
Gerrit-PatchSet: 4
Gerrit-Owner: thefrog <the...@chromium.org>
Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Simon Pelchat <spel...@chromium.org>
Gerrit-Reviewer: thefrog <the...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
Gerrit-Attention: Simon Pelchat <spel...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 16:56:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Simon Pelchat (Gerrit)

unread,
Aug 19, 2026, 1:01:42 PM (23 hours ago) Aug 19
to thefrog, Charles Harrison, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org
Attention needed from Charles Harrison and thefrog

Simon Pelchat voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Charles Harrison
  • thefrog
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib79817dc25897aeacfc665bd8fc58ed8685065a5
    Gerrit-Change-Number: 8263641
    Gerrit-PatchSet: 4
    Gerrit-Owner: thefrog <the...@chromium.org>
    Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
    Gerrit-Reviewer: Simon Pelchat <spel...@chromium.org>
    Gerrit-Reviewer: thefrog <the...@chromium.org>
    Gerrit-CC: Josh Karlin <jka...@chromium.org>
    Gerrit-CC: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: thefrog <the...@chromium.org>
    Gerrit-Attention: Charles Harrison <cshar...@chromium.org>
    Gerrit-Comment-Date: Wed, 19 Aug 2026 17:01:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Charles Harrison (Gerrit)

    unread,
    Aug 19, 2026, 4:21:31 PM (19 hours ago) Aug 19
    to thefrog, Simon Pelchat, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org
    Attention needed from thefrog

    Charles Harrison voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • thefrog
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib79817dc25897aeacfc665bd8fc58ed8685065a5
    Gerrit-Change-Number: 8263641
    Gerrit-PatchSet: 4
    Gerrit-Owner: thefrog <the...@chromium.org>
    Gerrit-Reviewer: Charles Harrison <cshar...@chromium.org>
    Gerrit-Reviewer: Simon Pelchat <spel...@chromium.org>
    Gerrit-Reviewer: thefrog <the...@chromium.org>
    Gerrit-CC: Josh Karlin <jka...@chromium.org>
    Gerrit-CC: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: thefrog <the...@chromium.org>
    Gerrit-Comment-Date: Wed, 19 Aug 2026 20:21:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages