Add TODO to migrate LiveDocumentSet to DCHECK_IS_ON(). [chromium/src : main]

0 views

Skip to first unread message

Jiacheng Guo (Gerrit)

unread,

12:20 AM (7 hours ago) 12:20 AM

to chromium...@chromium.org, Nate Chapin, Chromium Metrics Reviews, Daniel Cheng, asvitkine...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, jmedle...@chromium.org, schedule...@chromium.org, gavinp...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, blink-...@chromium.org, android-web...@chromium.org

Jiacheng Guo has uploaded the change for review

Commit message

Add TODO to migrate LiveDocumentSet to DCHECK_IS_ON().

Introduce a TODO comment linking to the cleanup bug to migrate
LiveDocumentSet in document.cc from NDEBUG to DCHECK_IS_ON() macro
guard.

Bug: 522516536

Change-Id: Ia33dca79e6ae83165d5b58066e2dffcb7886fc19

Change diff

diff --git a/third_party/blink/renderer/core/dom/document.cc b/third_party/blink/renderer/core/dom/document.cc
index 2d00725..04ae687d 100644
--- a/third_party/blink/renderer/core/dom/document.cc
+++ b/third_party/blink/renderer/core/dom/document.cc
@@ -430,6 +430,7 @@
 #ifndef NDEBUG
 using WeakDocumentSet = blink::HeapHashSet<blink::WeakMember<blink::Document>>;
 
+// TODO(crbug.com/522516536): Migrate to DCHECK_IS_ON() instead of NDEBUG.
 WeakDocumentSet& LiveDocumentSet() {
   using WeakDocumentSetHolder = blink::DisallowNewWrapper<WeakDocumentSet>;
   DEFINE_STATIC_LOCAL(blink::Persistent<WeakDocumentSetHolder>, holder,

Change information

Files:

M third_party/blink/renderer/core/dom/document.cc

Change size: XS

Delta: 1 file changed, 1 insertion(+), 0 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jiacheng Guo (Gerrit)

unread,

1:38 AM (5 hours ago) 1:38 AM

to Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, schedule...@chromium.org

Jiacheng Guo abandoned this change.

View Change

Abandoned

Jiacheng Guo abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages