Reapply "[soft navs] Re-enable improved LargestContentfulPaint UKM test." [chromium/src : main]

0 views

Skip to first unread message

Johannes Henkel (Gerrit)

unread,

Aug 8, 2025, 3:29:14 AMAug 8

to Michal Mocny, Shunya Shishido, Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Michal Mocny, Scott Haseley and Shunya Shishido

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Michal Mocny
Scott Haseley
Shunya Shishido

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shunya Shishido (Gerrit)

unread,

Aug 19, 2025, 11:07:06 PMAug 19

to Johannes Henkel, Code Review Nudger, Michal Mocny, Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Johannes Henkel, Michal Mocny and Scott Haseley

Shunya Shishido voted and added 2 comments

Votes added by Shunya Shishido

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Shunya Shishido . resolved

LGTM w/ nit

File chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc

Line 409, Patchset 10 (Latest): LOG(ERROR) << "start times are not unique: " << *it << " at index "

Shunya Shishido . unresolved

Is this a debug code? If so, please remove it.

Open in Gerrit

Related details

Attention is currently required from:

Johannes Henkel
Michal Mocny
Scott Haseley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Johannes Henkel (Gerrit)

unread,

Sep 11, 2025, 4:45:25 PM (6 days ago) Sep 11

to Shunya Shishido, Code Review Nudger, Michal Mocny, Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Johannes Henkel abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages