Kent Tamura (Gerrit)

unread,

Apr 2, 2026, 4:17:05 AM (yesterday) Apr 2

to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, Chromium LUCI CQ, Nate Chapin, AyeAye, android-web...@chromium.org, kinuko+...@chromium.org, gcasto+w...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, browser-comp...@chromium.org, pdf-r...@chromium.org, navigation...@chromium.org, loading...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, alexmo...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org, vasilii+watchlis...@chromium.org

Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:

Fredrik Söderquist

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fredrik Söderquist (Gerrit)

unread,

Apr 2, 2026, 4:34:00 AM (yesterday) Apr 2

to Kent Tamura, chromium...@chromium.org, Chromium LUCI CQ, Nate Chapin, AyeAye, android-web...@chromium.org, kinuko+...@chromium.org, gcasto+w...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, browser-comp...@chromium.org, pdf-r...@chromium.org, navigation...@chromium.org, loading...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, alexmo...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org, vasilii+watchlis...@chromium.org

Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Kent Tamura

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 2, 2026, 5:00:44 AM (yesterday) Apr 2

to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, Nate Chapin, AyeAye, android-web...@chromium.org, kinuko+...@chromium.org, gcasto+w...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, browser-comp...@chromium.org, pdf-r...@chromium.org, navigation...@chromium.org, loading...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, alexmo...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org, vasilii+watchlis...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Rename blink::WebString::FromUTF16() to FromUtf16()

To follow a naming rule of Google C++ style guide.
This CL has no behavior changes.

Bug: 492927412

Change-Id: I29597f96183c0dfc26f883ade0e9491153d78e9a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7723958

Commit-Queue: Fredrik Söderquist <f...@opera.com>

Reviewed-by: Fredrik Söderquist <f...@opera.com>

Owners-Override: Kent Tamura <tk...@chromium.org>

Auto-Submit: Kent Tamura <tk...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1609039}

Files:

M android_webview/renderer/aw_render_frame_ext.cc
M chrome/renderer/autofill/form_autofill_browsertest.cc
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc
M chrome/renderer/chrome_content_renderer_client.cc
M components/autofill/content/renderer/autofill_agent.cc
M components/autofill/content/renderer/autofill_agent_browsertest.cc
M components/autofill/content/renderer/form_autofill_util.cc
M components/autofill/content/renderer/password_autofill_agent.cc
M components/autofill/content/renderer/password_generation_agent.cc
M components/js_injection/renderer/js_binding.cc
M components/js_injection/renderer/js_communication.cc
M components/plugins/renderer/webview_plugin.cc
M components/spellcheck/renderer/spellcheck.cc
M components/spellcheck/renderer/spellcheck_multilingual_unittest.cc
M components/spellcheck/renderer/spellcheck_provider.cc
M content/child/blink_platform_impl.cc
M content/public/test/render_view_test.cc
M content/renderer/render_frame_impl.cc
M content/renderer/render_view_browsertest.cc
M content/renderer/renderer_blink_platform_impl.cc
M content/web_test/renderer/event_sender.cc
M content/web_test/renderer/spell_check_client.cc
M pdf/pdf_view_web_plugin_unittest.cc
M third_party/blink/public/platform/web_string.h
M third_party/blink/renderer/core/exported/web_view_impl.cc
M third_party/blink/renderer/core/html/html_capability_element_base_test.cc
M third_party/blink/renderer/core/html/html_geolocation_element_test.cc
M third_party/blink/renderer/core/loader/history_item.cc
M third_party/blink/renderer/core/page/context_menu_controller.cc
M third_party/blink/renderer/modules/mediastream/media_stream_video_track.cc
M third_party/blink/renderer/platform/exported/file_path_conversion.cc
M third_party/blink/renderer/platform/exported/web_string.cc

Change size: M

Delta: 32 files changed, 106 insertions(+), 106 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Fredrik Söderquist

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Rename blink::WebString::FromUTF16() to FromUtf16() [chromium/src : main]

Kent Tamura (Gerrit)

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

1 comment

Related details

Fredrik Söderquist (Gerrit)

Fredrik Söderquist voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information