[base] Move tracing test helpers to dedicated directory [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Apr 28, 2026, 2:06:45 PM (yesterday) Apr 28
to Gabriel Charette, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Andrew Rayskiy, Heron Yang, Mangesh Ghiware, Hu, Ningxin, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, alexmo...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, devtools-re...@chromium.org, dtapuska+ch...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, phoglun...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org
Attention needed from Gabriel Charette

Victor Vianna voted and added 2 comments

Votes added by Victor Vianna

Auto-Submit+1

2 comments

File base/BUILD.gn
File-level comment, Patchset 5 (Latest):
Victor Vianna . unresolved

Hi gab@, please OO+1

File base/test/OWNERS
File-level comment, Patchset 5 (Latest):
Victor Vianna . resolved

Replaced with an actual owners file in the directory

Open in Gerrit

Related details

Attention is currently required from:
  • Gabriel Charette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c657b09a71f36317da5859f2f5bdfa357050f9b
Gerrit-Change-Number: 7799878
Gerrit-PatchSet: 5
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Gabriel Charette <g...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 18:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Apr 28, 2026, 2:14:23 PM (yesterday) Apr 28
to Gabriel Charette, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Andrew Rayskiy, Heron Yang, Mangesh Ghiware, Hu, Ningxin, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, alexmo...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, devtools-re...@chromium.org, dtapuska+ch...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, phoglun...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org
Attention needed from Gabriel Charette

Victor Vianna voted and added 2 comments

Votes added by Victor Vianna

Auto-Submit+1

2 comments

File base/test/OWNERS
Line 4, Patchset 6 (Parent):# Tracing test utilities:
Victor Vianna . resolved

Replaced with a dedicated owners file in the directory

Line 16, Patchset 6 (Latest):# For the trivial case of adding/removing files.
Open in Gerrit

Related details

Attention is currently required from:
  • Gabriel Charette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c657b09a71f36317da5859f2f5bdfa357050f9b
Gerrit-Change-Number: 7799878
Gerrit-PatchSet: 6
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Gabriel Charette <g...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 18:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Gabriel Charette (Gerrit)

unread,
Apr 28, 2026, 6:48:36 PM (21 hours ago) Apr 28
to Victor Vianna, Gabriel Charette, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Andrew Rayskiy, Heron Yang, Mangesh Ghiware, Hu, Ningxin, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, ios-rev...@chromium.org, alexmo...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, devtools-re...@chromium.org, dtapuska+ch...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, phoglun...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org
Attention needed from Victor Vianna

Gabriel Charette voted and added 1 comment

Votes added by Gabriel Charette

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

File base/BUILD.gn
File-level comment, Patchset 5:
Victor Vianna . resolved

Hi gab@, please OO+1

Gabriel Charette

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c657b09a71f36317da5859f2f5bdfa357050f9b
Gerrit-Change-Number: 7799878
Gerrit-PatchSet: 7
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Tue, 28 Apr 2026 22:48:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Victor Vianna <victor...@google.com>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 28, 2026, 6:53:09 PM (21 hours ago) Apr 28
to Victor Vianna, Gabriel Charette, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Andrew Rayskiy, Heron Yang, Mangesh Ghiware, Hu, Ningxin, Jiewei Qian, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, ios-rev...@chromium.org, alexmo...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, devtools-re...@chromium.org, dtapuska+ch...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, phoglun...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[base] Move tracing test helpers to dedicated directory

No behavior change.
Bypass-Check-License: renamed files
Change-Id: I5c657b09a71f36317da5859f2f5bdfa357050f9b
Commit-Queue: Gabriel Charette <g...@chromium.org>
Owners-Override: Gabriel Charette <g...@chromium.org>
Reviewed-by: Gabriel Charette <g...@chromium.org>
Auto-Submit: Victor Vianna <victor...@google.com>
Cr-Commit-Position: refs/heads/main@{#1622086}
Files:
  • M base/BUILD.gn
  • M base/message_loop/message_pump_glib_unittest.cc
  • M base/task/sequence_manager/sequence_manager_impl_unittest.cc
  • M base/test/BUILD.gn
  • M base/test/OWNERS
  • M base/test/test_suite.h
  • A base/test/tracing/OWNERS
  • R base/test/tracing/test_trace_processor.cc
  • R base/test/tracing/test_trace_processor.h
  • R base/test/tracing/test_trace_processor_example_unittest.cc
  • R base/test/tracing/test_trace_processor_export.h
  • R base/test/tracing/test_trace_processor_impl.cc
  • R base/test/tracing/test_trace_processor_impl.h
  • R base/test/tracing/test_trace_processor_impl.plist
  • R base/test/tracing/trace_event_analyzer.cc
  • R base/test/tracing/trace_event_analyzer.h
  • R base/test/tracing/trace_event_analyzer_unittest.cc
  • R base/test/tracing/trace_test_utils.cc
  • R base/test/tracing/trace_test_utils.h
  • R base/test/tracing/trace_to_file.cc
  • R base/test/tracing/trace_to_file.h
  • M base/trace_event/memory_dump_manager_unittest.cc
  • M base/trace_event/trace_event_unittest.cc
  • M cc/metrics/compositor_frame_reporting_controller_unittest.cc
  • M cc/metrics/predictor_jank_tracker_unittest.cc
  • M cc/metrics/scroll_jank_v4_processor_unittest.cc
  • M cc/metrics/scroll_jank_v4_tracing_recorder_unittest.cc
  • M cc/trees/frame_data_unittest.cc
  • M chrome/browser/actor/aggregated_journal_unittest.cc
  • M chrome/browser/ash/arc/tracing/arc_tracing_bridge_unittest.cc
  • M chrome/browser/extensions/api/automation/automation_apitest.cc
  • M chrome/browser/extensions/api/tab_capture/tab_capture_performance_test_base.h
  • M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc
  • M chrome/browser/media/webrtc/webrtc_video_display_perf_browsertest.cc
  • M chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
  • M chrome/browser/page_load_metrics/integration_tests/first_input_delay_browsertest.cc
  • M chrome/browser/page_load_metrics/integration_tests/interaction_to_next_paint_browsertest.cc
  • M chrome/browser/page_load_metrics/integration_tests/largest_contentful_paint_browsertest.cc
  • M chrome/browser/page_load_metrics/integration_tests/layout_instability_browsertest.cc
  • M chrome/browser/page_load_metrics/integration_tests/metric_integration_test.cc
  • M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer_unittest.cc
  • M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
  • M components/input/test/input_browsertest.cc
  • M components/page_load_metrics/browser/observers/core/uma_page_load_metrics_observer_unittest.cc
  • M components/private_ai/phosphor/token_fetcher_impl_unittest.cc
  • M components/tracing/test/trace_event_perftest.cc
  • M components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
  • M content/browser/performance_timeline_browsertest.cc
  • M content/browser/renderer_host/input/scroll_latency_browsertest.cc
  • M content/browser/renderer_host/input/scroll_tracing_browsertest.cc
  • M content/browser/renderer_host/render_widget_host_view_android_browsertest.cc
  • M content/browser/site_per_process_browsertest.cc
  • M content/browser/tracing/background_tracing_manager_browsertest.cc
  • M content/browser/tracing/tracing_end_to_end_browsertest.cc
  • M docs/trace_events.md
  • M gin/v8_isolate_memory_dump_provider_unittest.cc
  • M gpu/command_buffer/service/gpu_persistent_cache_unittest.cc
  • M gpu/ipc/service/gpu_channel_manager_unittest.cc
  • M ios/chrome/browser/tracing/ios_tracing_controller_unittest.mm
  • M ios/web/navigation/crw_wk_navigation_states_unittest.mm
  • M net/log/trace_net_log_observer_unittest.cc
  • M services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
  • M services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
  • M services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer_proto_unittest.cc
  • M services/tracing/public/cpp/perfetto/producer_test_utils.h
  • M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler_unittest.cc
  • M services/webnn/public/cpp/webnn_trace_unittest.cc
  • M third_party/blink/renderer/core/css/element_rule_collector_test.cc
  • M third_party/blink/renderer/core/frame/webdx_feature_tracing_test.cc
  • M third_party/blink/renderer/core/inspector/invalidation_set_to_selector_map_test.cc
  • M third_party/blink/renderer/core/paint/DEPS
  • M third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
  • M third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.h
  • M third_party/blink/renderer/core/paint/paint_layer_painter_test.cc
  • M third_party/blink/renderer/core/paint/timing/image_paint_timing_detector_test.cc
  • M third_party/blink/renderer/core/paint/timing/largest_contentful_paint_calculator_test.cc
  • M third_party/blink/renderer/core/paint/timing/text_paint_timing_detector_test.cc
  • M third_party/blink/renderer/core/timing/DEPS
  • M third_party/blink/renderer/core/timing/window_performance_test.cc
  • M third_party/blink/renderer/core/timing/worker_performance_test.cc
  • M third_party/blink/renderer/platform/scheduler/common/tracing_helper_unittest.cc
  • M third_party/blink/renderer/platform/widget/input/input_handler_proxy_unittest.cc
Change size: L
Delta: 83 files changed, 134 insertions(+), 136 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Gabriel Charette
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c657b09a71f36317da5859f2f5bdfa357050f9b
Gerrit-Change-Number: 7799878
Gerrit-PatchSet: 8
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages