[Connection-Allowlist] Add browser test for link header modulepreload [chromium/src : main]

0 views
Skip to first unread message

Andrew Verge (Gerrit)

unread,
Jan 28, 2026, 9:54:40 AM (3 days ago) Jan 28
to Xiaochen Zhou, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Attention needed from Xiaochen Zhou

Andrew Verge voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Xiaochen Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4aa623e76a308fec3585f7e8f2534f12dab46b11
Gerrit-Change-Number: 7513389
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Attention: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Comment-Date: Wed, 28 Jan 2026 14:54:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kenichi Ishibashi (Gerrit)

unread,
Jan 28, 2026, 8:53:19 PM (2 days ago) Jan 28
to Xiaochen Zhou, Andrew Verge, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Attention needed from Xiaochen Zhou

Kenichi Ishibashi voted and added 1 comment

Votes added by Kenichi Ishibashi

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kenichi Ishibashi . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Xiaochen Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4aa623e76a308fec3585f7e8f2534f12dab46b11
Gerrit-Change-Number: 7513389
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Attention: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 01:52:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Verge (Gerrit)

unread,
Jan 29, 2026, 8:08:00 AM (2 days ago) Jan 29
to Xiaochen Zhou, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Attention needed from Xiaochen Zhou

Andrew Verge voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Xiaochen Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4aa623e76a308fec3585f7e8f2534f12dab46b11
Gerrit-Change-Number: 7513389
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Attention: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 13:07:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 29, 2026, 9:08:28 AM (2 days ago) Jan 29
to Xiaochen Zhou, Andrew Verge, Kenichi Ishibashi, chromium...@chromium.org, loading...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Connection-Allowlist] Add browser test for link header modulepreload
Bug: 447954811
Change-Id: I4aa623e76a308fec3585f7e8f2534f12dab46b11
Reviewed-by: Andrew Verge <ave...@chromium.org>
Commit-Queue: Andrew Verge <ave...@chromium.org>
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1576541}
Files:
  • M content/browser/loader/connection_allowlist_browsertest.cc
Change size: S
Delta: 1 file changed, 31 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kenichi Ishibashi, +1 by Andrew Verge
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4aa623e76a308fec3585f7e8f2534f12dab46b11
Gerrit-Change-Number: 7513389
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Xiaochen Zhou <xiaoc...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages